The Chemistry Development Kit / Patches / #575 [bug:1278] AtomContainerPermutatorpatch and cleanup

#575 [bug:1278] AtomContainerPermutatorpatch and cleanup

Milestone: Accepted

Status: closed

Owner: nobody

Labels: graph (5)

Branch: cdk-1.4.x

Priority: 1

Updated: 2013-03-26

Created: 2012-11-09

Creator: John May

Private: No

Fixed a bug where a cast to implementation was expected.
Reword documentation - this is a really useful class
Reordered implementation so it read clearer and added logging method for exception

https://github.com/johnmay/cdk/commits/cdk-1.4.x+

Related

Patches: ~~#575~~

Discussion

Egon Willighagen - 2012-11-09

For the URL, please use @cdk.cite (see GitHub). The other two look good to me.

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Egon Willighagen - 2012-12-12

milestone: Needs_Review --> Needs_Revision
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

John May - 2012-12-12

missing comment again?

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

John May - 2013-03-21

summary: [bug:1278] patch and cleanup --> [bug:1278] AtomContainerPermutatorpatch and cleanup
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Egon Willighagen - 2013-03-23

OK, the first patch is applied, but I requested some updates for the other two... See the GitHub comments:

https://github.com/johnmay/cdk/commit/24a981006f799060ec5b361f93899fc8b056272c#commitcomment-2866488
https://github.com/johnmay/cdk/commit/15735a4146d3a6ed8b3420946ed9b660cc0da41b

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

John May - 2013-03-23

Not sure if it worked responding from the email...

Could you be more specific with the changes. Are they fixed by the additional ones I added? There is another comment on the final commit about the LoggingTool/LoggingToolFactory which I don't understand.

There are two more on the branch:
https://github.com/johnmay/cdk/commits/cdk-1.4.x%2B/src/main/org/openscience/cdk/graph/AtomContainerAtomPermutor.java

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

John May - 2013-03-23

Could you be more specific with the changes. Are they fixed by the additional ones I added?

There are two more on the branch:
https://github.com/johnmay/cdk/commits/cdk-1.4.x%2B/src/main/org/openscience/cdk/graph/AtomContainerAtomPermutor.java

On 23 Mar 2013, at 14:46, Egon Willighagen egonw@users.sf.net wrote:

OK, the first patch is applied, but I requested some updates for the other two... See the GitHub comments:

https://github.com/johnmay/cdk/commit/24a981006f799060ec5b361f93899fc8b056272c#commitcomment-2866488
https://github.com/johnmay/cdk/commit/15735a4146d3a6ed8b3420946ed9b660cc0da41b

[patches:#575] [bug:1278] AtomContainerPermutatorpatch and cleanup

Status: open
Labels: graph
Created: Fri Nov 09, 2012 08:34 PM UTC by John May
Last Updated: Thu Mar 21, 2013 08:41 AM UTC
Owner: nobody

Fixed a bug where a cast to implementation was expected.
Reword documentation - this is a really useful class
Reordered implementation so it read clearer and added logging method for exception
https://github.com/johnmay/cdk/commits/cdk-1.4.x+

Sent from sourceforge.net because you indicated interest in https://sourceforge.net/p/cdk/patches/575/

To unsubscribe from further messages, please visit https://sourceforge.net/auth/prefs/

Related

Patches: ~~#575~~

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Egon Willighagen - 2013-03-23

Yes, you're correct. Doing the documentation patches now. That leaves the missing unit testing...

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Egon Willighagen - 2013-03-23

OK, and these two documentation patches don't apply to master :(

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

John May - 2013-03-23

Yes Gilleain has rewritten the entire class. Will be good to be back on a single branch :).

Last edit: John May 2013-03-23

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

John May - 2013-03-26

applied and pushed by Egon - also these classes were changed in master by gilleain

If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

John May - 2013-03-26

status: open --> closed

milestone: Needs_Revision --> Accepted
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:

Log in to post a comment.