#551 Unit tests and optimisations for shortest path fingerprinter

Accepted
closed
John May
master
1
2013-03-26
2012-10-10
John May
No

This patch fixes some issues raised with the shortest path fingerprint patch

Please note these need to be applied in order

  • Unit tests for RandomNumber, Canonicallisation and Comparator [0001]
  • Moved classes from standard to fingerprint [0002]
  • Added some JavaDoc (more required)
  • Optimizations on some parts I spotted [0003-0006,0008]
  • Renaming variable/removed SVN tags (more needed) [0007]
  • Changed class name to noun instead of verb (which should be reserved for methods) [0009]

Looks like I have to upload these 1 by 1

1 Attachments

Discussion

  • John May

    John May - 2012-10-28
    • Milestone: Accepted --> Needs_Review
     
  • Egon Willighagen

    • branch: --> master
    • milestone: Needs_Review --> Needs_Revision
     
  • Egon Willighagen

    I'll keep this patch open for the small updates, if you like.

     
  • John May

    John May - 2012-12-12

    Okay, what needs revision?

     
  • Egon Willighagen

    Argh... where did that comment go?? Darn.

    OK, from my memory: a few files had missing copyright headers (0002 I think)

    There was a JavaDoc about @param 'n' with an incomplete JavaDoc ending with "... the".

    That was it.

     
  • John May

    John May - 2012-12-12

    Okay cool, I thought it was a stray comment :-)

     
  • John May

    John May - 2012-12-21

    Okay have made the revisions.

     
  • John May

    John May - 2012-12-21
    • milestone: Needs_Revision --> Needs_Review
     
  • John May

    John May - 2013-03-26
    • status: open --> closed
    • milestone: Needs_Review --> Accepted
     
  • John May

    John May - 2013-03-26

    applied and pushed by Egon

     

Log in to post a comment.