#538 fix for the EntryTest and EntryReactTest

Accepted
closed
master (162)
master
5
2013-05-11
2012-08-06
No

fixing the bug reported in:

https://sourceforge.net/tracker/?func=detail&aid=3553754&group_id=20024&atid=120024

It introduces the design pattern of an abstract super test class and a method to set the tested class, a pattern we use for many other 'interfaces' too, such as readers and writers. I added a @After test to show that the tested class is indeed what we expect it to be.

Discussion

  • John May

    John May - 2012-08-14

    I think DictionaryTest, OWLFileTest and OWLReactTest might also need updating?
    These all extend EntryTest also but are not sub-classes of Entry and I think another
    'setClass()' might be missing.

    J

     
  • Egon Willighagen

    Yes, I think you're right.

     
  • Egon Willighagen

    You were very right. DictionaryTest was never intended to extend EntryTest, as Dictionary does not extend Entry.

    I have updated the patch, introducing an AbstractDictionaryTest now superclassing DictionaryTest, OWLFileTest, and OWLReactTest, just like what the patch already did for Entry.

     
  • Egon Willighagen

    • Branch: --> master
    • Group: Needs_Revision --> Needs_Review
     
  • John May

    John May - 2013-05-03

    Should be to take a look at these this afternoon.

     
  • Egon Willighagen

    OK, got it.

     
  • John May

    John May - 2013-05-11
    • status: open --> closed
     
  • John May

    John May - 2013-05-11
    • Group: Needs_Review --> Accepted
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks