Patch for bug https://sourceforge.net/tracker/?func=detail&aid=3474522&group_id=20024&atid=120024:
The changes look good but line 673 should be:
if (lineLength >= 80) and not if(lineLength >= 79)
String frag = cLine.substring(78, 80).trim();
may throw an index out of bounds exception.
Probably fine though as if I remember correctly the PDB dates back to fortran where everything's always 80 characters.
Only spotted this from doing the checks on the MDL*Reader's :-).
John, how about this updated patch?
Do you know how to 'sign off' a patch?
Just applied it to some new local branch, make sure things compile with 'ant clean dist-all test-dist-all' and then run:
git commit --amend --signoff
If you could then place it somewhere online, then Rajarshi or I can push it to the repository, and everyone will see that you reviewed and approved the patch.
Looks good, have signed off.
What do I need to place online? If it's just the patch file for the sign off, here it is:
If not let me know.
No, this is exactly what I need :) thanx!
Log in to post a comment.
Sign up for the SourceForge newsletter:
You seem to have CSS turned off.
Please don't fill out this field.