#432 Makes the smiles module independent from the data module

Needs_Review
closed
nobody
master (162)
5
2012-10-28
2011-11-07
No

By creating a IChemObjectBuilder when needed.

Discussion

  • Rajarshi Guha

    Rajarshi Guha - 2011-11-07

    Applied. But after applying, the build fails:

    compile-module:
    [echo] Compiling classes for CDK's smiles module from src/main...
    [echo] Datafiles defined: ${module.datafiles.present}
    [echo] Extra files defined: ${module.extrafiles.present}
    [echo] CDK dependencies defined: true
    [echo] Library dependencies defined: true
    [echo] Developer Library dependencies defined: ${module.devellibdepends.present}
    [echo] Autogenerated files specified: ${module.autogenerated.present}
    [mkdir] Created dir: /Users/rguha/src/java/cdk/build/src/smiles
    [mkdir] Created dir: /Users/rguha/src/java/cdk/build/smiles
    [copy] Copying 8 files to /Users/rguha/src/java/cdk/build/src/smiles
    [javac] Compiling 8 source files to /Users/rguha/src/java/cdk/build/smiles
    [javac] /Users/rguha/src/java/cdk/build/src/smiles/org/openscience/cdk/smiles/SmilesParser.java:49: cannot find symbol
    [javac] symbol : class TetrahedralChirality
    [javac] location: package org.openscience.cdk.stereo
    [javac] import org.openscience.cdk.stereo.TetrahedralChirality;
    [javac] ^
    [javac] /Users/rguha/src/java/cdk/build/src/smiles/org/openscience/cdk/smiles/DeduceBondSystemTool.java:34: cannot find symbol
    [javac] symbol : class Atom
    [javac] location: package org.openscience.cdk
    [javac] import org.openscience.cdk.Atom;
    [javac] ^
    [javac] /Users/rguha/src/java/cdk/build/src/smiles/org/openscience/cdk/smiles/DeduceBondSystemTool.java:36: cannot find symbol
    [javac] symbol : class Molecule
    [javac] location: package org.openscience.cdk
    [javac] import org.openscience.cdk.Molecule;
    ...

     
  • Egon Willighagen

    Rajarshi, can you please try again. I merged in the interface patches that went into 1.4.x into master now (merged 1.4.x into master), and it compiles for me now.

    Sorry for the inconvenience... :/

     
  • Rajarshi Guha

    Rajarshi Guha - 2011-11-08

    Applied and pushed

     

Log in to post a comment.