#393 small patch with unit test clean up

Needs_Review
closed
nobody
cdk-1.4.x (181)
5
2012-10-28
2011-08-13
No

My son decided he wanted to help me with my work load, so we agreed he would help with CDK development. This is his first result.

It's a small patch doing some assert() fixes, very much like a junior job, but simpler. I demoed the first, he did the rest. Per regulations, he's in my 'group', so someone else needs to do the reviewing. I forgot to get his Eclipse/EGit checkout set to cdk-1.4.x, so the path was written against master.

Discussion

  • Asad

    Asad - 2011-08-14

    This patch is clean and it works at my end.
    Well done Lars, welcome to the CDK club :-)

    Asad

     
  • Egon Willighagen

    Hi Asad, thanx! Can you please sign off the patch, and attach that version to this report? If the more recent patch in a branch is the one you reviewed, you can do this from the command line with:

    git commit --amend --sign-off
    git format-patch -1

    He worked a bit today, resulting in a similar path: 0002-$foo.patch, which is a bit larger, but the same type of changes.

     
  • Asad

    Asad - 2011-08-16

    Hi Egon,
    I have used the following steps to check the patches and sign off

    a) git apply --stat foo.patch
    b) git apply --check foo.patch
    c) git am --signoff < foo.patch
    d) git format-patch -1

    The sign-off patches are attached.

     
  • Egon Willighagen

    Thanx! Pushed to the repository.

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks