#242 Weird use of the ILoggingTool in MolHandler

Accepted
closed
Asad
master (162)
5
2012-10-28
2010-08-01
No

The current code uses:

Logger.error(Level.SEVERE, null, ex);

  • please start variable names with lower case chars
  • the ILoggingTool takes one or more text elements which as messages... use ex.getMessage()
  • why does that call have a null parameter?

Discussion

  • Jules Kerssemakers

    From the looks of it, Asad used another logging toolkit before that had this as call syntax, since CDK logging is so forgiving with its varargs, the compiler didn't complain when asad refactored the code to cdk-logging.

    I've made a patch, but since I can't add it here (no add-a-file button?), I'll send it to cdk-patches instead

     
  • Egon Willighagen

    Jules, please talk with Asad, as he is the best person to review this patch. I'll move it to the patch tracker.

     
  • Asad

    Asad - 2010-08-11

    Hi Jules, could you send me the patches by e-mail once we have 1.0.2 code accepted

     
  • Asad

    Asad - 2010-08-24

    This change has been included in the patch 3037137.
    @Egon:
    why does that call have a null parameter?
    -This was default netbeans implementation.

     
  • Asad

    Asad - 2010-08-30

    accepted and added to the latest smsd code 1.2.0

     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks