#10 CDKException instantions should keep stack trace

Needs_Review
closed
None
5
2012-10-28
2008-01-05
No

There are several CDKException instantiations which look like:

new CDKException("Error occured during clone " + e);

Such calls are wrong in two ways:

1.the new error message should contain the error message of the parent exception:

"Error occured during clone " + e.getMessage

But, this report is really about keeping the stack trace, which is done by adding the catched exception 'e' as second parameter to the CDKException constructor:

new CDKException("Error occured during clone " + e.getMessage(), e);

Discussion

  • paul turner

    paul turner - 2009-01-03

    paulturner: have started work on this one... work area is branches/paulturner-jj1864371

     
  • paul turner

    paul turner - 2009-01-19

    branch ready for merge.

    oops:please excuse the email i sent instead of putting comment here.

     
  • Egon Willighagen

    Moving to Patches.

     
  • Egon Willighagen

    Open for review.

     
  • Egon Willighagen

    Patch looks fine to me.

     
  • Rajarshi Guha

    Rajarshi Guha - 2009-04-27

    Looks good to me - Egon, can be committed

     
  • Egon Willighagen

    Rajarshi, please signoff the last commit (I only seem to be able to signoff the last of a series of patches, not sure why) and commit to SF.

     
  • Rajarshi Guha

    Rajarshi Guha - 2009-04-27

    signed off and commited to cdk-1.2.x on SF. Merged with master

     

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks