[Cdk-devel] [ cdk-Patches-3002409 ] misleading Javadoc in SMILES parser test
|
From: SourceForge.net <noreply@so...> - 2010-05-20 22:49:35
|
Patches item #3002409, was opened at 2010-05-16 11:27 Message generated for change (Comment added) made by rajarshi You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3002409&group_id=20024 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. >Category: master >Group: Accepted >Status: Closed >Resolution: Accepted Priority: 5 Private: No Submitted By: Rajarshi Guha (rajarshi) Assigned to: Rajarshi Guha (rajarshi) Summary: misleading Javadoc in SMILES parser test Initial Comment: testAtAt() has a comment that says Per SMILES specification, this hydrogen is the atom towards the viewer, and will therefore end up as first atom in the array but the code has Assert.assertEquals("Br", ligands[0].getSymbol()); Assert.assertEquals("H", ligands[1].getSymbol()); Assert.assertEquals("Cl", ligands[2].getSymbol()); Assert.assertEquals("I", ligands[3].getSymbol()); where H comes *after* Br, contradicting the comment. Needs to be synced. Same with testAt() ---------------------------------------------------------------------- >Comment By: Rajarshi Guha (rajarshi) Date: 2010-05-20 18:49 Message: Applied and pushed ---------------------------------------------------------------------- Comment By: Egon Willighagen (egonw) Date: 2010-05-20 10:01 Message: Patch attached. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3002409&group_id=20024 |