[Cdk-devel] [ cdk-Junior Jobs-1802586 ] Misuse of assertTrue for tested expected Strings

[SourceForge.net <no...@so...>]

Junior Jobs item #1802586, was opened at 2007-09-26 11:46
Message generated for change (Tracker Item Submitted) made by Item Submitter
You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=997721&aid=1802586&group_id=20024

Please note that this message will contain a full copy of the comment thread,
including the initial issue submission, for this request,
not just the latest update.
Category: None
Group: None
Status: Open
Resolution: None
Priority: 5
Private: No
Submitted By: Egon Willighagen (egonw)
Assigned to: Nobody/Anonymous (nobody)
Summary: Misuse of assertTrue for tested expected Strings

Initial Comment:
Many JUnit tests in org.openscience.cdk.test use improper
JUnit assert methods to test for expected behavior. This JJ deals
with the following pattern:

assertTrue(smiles1.equals("[H]OC(=O)[C@](F)(C([H])([H])[H])N([H])[H]"));

This must really be:

assertEquals("[H]OC(=O)[C@](F)(C([H])([H])[H])N([H])[H]", smiles1);

Using the method assertEquals(EXPECTED_VALUE, FOUND_VALUE).


Required skills: you can compile the CDK and run the JUnit tests using Ant or Eclipse.

----------------------------------------------------------------------

You can respond by visiting: 
https://sourceforge.net/tracker/?func=detail&atid=997721&aid=1802586&group_id=20024