From: SourceForge.net <no...@so...> - 2011-11-07 13:34:11
|
Patches item #3434496, was opened at 2011-11-07 05:34 Message generated for change (Tracker Item Submitted) made by egonw You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3434496&group_id=20024 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: master Group: Needs Review Status: Open Resolution: None Priority: 5 Private: No Submitted By: Egon Willighagen (egonw) Assigned to: Nobody/Anonymous (nobody) Summary: Makes the smiles module independent from the data module Initial Comment: By creating a IChemObjectBuilder when needed. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3434496&group_id=20024 |
From: SourceForge.net <no...@so...> - 2011-11-07 13:42:43
|
Patches item #3434496, was opened at 2011-11-07 05:34 Message generated for change (Comment added) made by egonw You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3434496&group_id=20024 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: master Group: Needs Review Status: Open Resolution: None Priority: 5 Private: No Submitted By: Egon Willighagen (egonw) Assigned to: Nobody/Anonymous (nobody) Summary: Makes the smiles module independent from the data module Initial Comment: By creating a IChemObjectBuilder when needed. ---------------------------------------------------------------------- >Comment By: Egon Willighagen (egonw) Date: 2011-11-07 05:42 Message: This patch probably depends on these patches to be applied to: https://sourceforge.net/tracker/?func=detail&aid=3411511&group_id=20024&atid=320024 https://sourceforge.net/tracker/?func=detail&aid=3411538&group_id=20024&atid=320024 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3434496&group_id=20024 |
From: SourceForge.net <no...@so...> - 2011-11-07 22:54:39
|
Patches item #3434496, was opened at 2011-11-07 05:34 Message generated for change (Comment added) made by rajarshi You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3434496&group_id=20024 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: master Group: Needs Review Status: Open Resolution: None Priority: 5 Private: No Submitted By: Egon Willighagen (egonw) Assigned to: Nobody/Anonymous (nobody) Summary: Makes the smiles module independent from the data module Initial Comment: By creating a IChemObjectBuilder when needed. ---------------------------------------------------------------------- >Comment By: Rajarshi Guha (rajarshi) Date: 2011-11-07 14:54 Message: Applied. But after applying, the build fails: compile-module: [echo] Compiling classes for CDK's smiles module from src/main... [echo] Datafiles defined: ${module.datafiles.present} [echo] Extra files defined: ${module.extrafiles.present} [echo] CDK dependencies defined: true [echo] Library dependencies defined: true [echo] Developer Library dependencies defined: ${module.devellibdepends.present} [echo] Autogenerated files specified: ${module.autogenerated.present} [mkdir] Created dir: /Users/rguha/src/java/cdk/build/src/smiles [mkdir] Created dir: /Users/rguha/src/java/cdk/build/smiles [copy] Copying 8 files to /Users/rguha/src/java/cdk/build/src/smiles [javac] Compiling 8 source files to /Users/rguha/src/java/cdk/build/smiles [javac] /Users/rguha/src/java/cdk/build/src/smiles/org/openscience/cdk/smiles/SmilesParser.java:49: cannot find symbol [javac] symbol : class TetrahedralChirality [javac] location: package org.openscience.cdk.stereo [javac] import org.openscience.cdk.stereo.TetrahedralChirality; [javac] ^ [javac] /Users/rguha/src/java/cdk/build/src/smiles/org/openscience/cdk/smiles/DeduceBondSystemTool.java:34: cannot find symbol [javac] symbol : class Atom [javac] location: package org.openscience.cdk [javac] import org.openscience.cdk.Atom; [javac] ^ [javac] /Users/rguha/src/java/cdk/build/src/smiles/org/openscience/cdk/smiles/DeduceBondSystemTool.java:36: cannot find symbol [javac] symbol : class Molecule [javac] location: package org.openscience.cdk [javac] import org.openscience.cdk.Molecule; ... ---------------------------------------------------------------------- Comment By: Egon Willighagen (egonw) Date: 2011-11-07 05:42 Message: This patch probably depends on these patches to be applied to: https://sourceforge.net/tracker/?func=detail&aid=3411511&group_id=20024&atid=320024 https://sourceforge.net/tracker/?func=detail&aid=3411538&group_id=20024&atid=320024 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3434496&group_id=20024 |
From: SourceForge.net <no...@so...> - 2011-11-08 06:18:01
|
Patches item #3434496, was opened at 2011-11-07 05:34 Message generated for change (Comment added) made by egonw You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3434496&group_id=20024 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: master Group: Needs Review Status: Open Resolution: None Priority: 5 Private: No Submitted By: Egon Willighagen (egonw) Assigned to: Nobody/Anonymous (nobody) Summary: Makes the smiles module independent from the data module Initial Comment: By creating a IChemObjectBuilder when needed. ---------------------------------------------------------------------- >Comment By: Egon Willighagen (egonw) Date: 2011-11-07 22:18 Message: Rajarshi, can you please try again. I merged in the interface patches that went into 1.4.x into master now (merged 1.4.x into master), and it compiles for me now. Sorry for the inconvenience... :/ ---------------------------------------------------------------------- Comment By: Rajarshi Guha (rajarshi) Date: 2011-11-07 14:54 Message: Applied. But after applying, the build fails: compile-module: [echo] Compiling classes for CDK's smiles module from src/main... [echo] Datafiles defined: ${module.datafiles.present} [echo] Extra files defined: ${module.extrafiles.present} [echo] CDK dependencies defined: true [echo] Library dependencies defined: true [echo] Developer Library dependencies defined: ${module.devellibdepends.present} [echo] Autogenerated files specified: ${module.autogenerated.present} [mkdir] Created dir: /Users/rguha/src/java/cdk/build/src/smiles [mkdir] Created dir: /Users/rguha/src/java/cdk/build/smiles [copy] Copying 8 files to /Users/rguha/src/java/cdk/build/src/smiles [javac] Compiling 8 source files to /Users/rguha/src/java/cdk/build/smiles [javac] /Users/rguha/src/java/cdk/build/src/smiles/org/openscience/cdk/smiles/SmilesParser.java:49: cannot find symbol [javac] symbol : class TetrahedralChirality [javac] location: package org.openscience.cdk.stereo [javac] import org.openscience.cdk.stereo.TetrahedralChirality; [javac] ^ [javac] /Users/rguha/src/java/cdk/build/src/smiles/org/openscience/cdk/smiles/DeduceBondSystemTool.java:34: cannot find symbol [javac] symbol : class Atom [javac] location: package org.openscience.cdk [javac] import org.openscience.cdk.Atom; [javac] ^ [javac] /Users/rguha/src/java/cdk/build/src/smiles/org/openscience/cdk/smiles/DeduceBondSystemTool.java:36: cannot find symbol [javac] symbol : class Molecule [javac] location: package org.openscience.cdk [javac] import org.openscience.cdk.Molecule; ... ---------------------------------------------------------------------- Comment By: Egon Willighagen (egonw) Date: 2011-11-07 05:42 Message: This patch probably depends on these patches to be applied to: https://sourceforge.net/tracker/?func=detail&aid=3411511&group_id=20024&atid=320024 https://sourceforge.net/tracker/?func=detail&aid=3411538&group_id=20024&atid=320024 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3434496&group_id=20024 |
From: SourceForge.net <no...@so...> - 2011-11-08 12:39:45
|
Patches item #3434496, was opened at 2011-11-07 05:34 Message generated for change (Comment added) made by rajarshi You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3434496&group_id=20024 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: master >Group: Accepted >Status: Closed >Resolution: Accepted Priority: 5 Private: No Submitted By: Egon Willighagen (egonw) Assigned to: Nobody/Anonymous (nobody) Summary: Makes the smiles module independent from the data module Initial Comment: By creating a IChemObjectBuilder when needed. ---------------------------------------------------------------------- >Comment By: Rajarshi Guha (rajarshi) Date: 2011-11-08 04:39 Message: Applied and pushed ---------------------------------------------------------------------- Comment By: Egon Willighagen (egonw) Date: 2011-11-07 22:18 Message: Rajarshi, can you please try again. I merged in the interface patches that went into 1.4.x into master now (merged 1.4.x into master), and it compiles for me now. Sorry for the inconvenience... :/ ---------------------------------------------------------------------- Comment By: Rajarshi Guha (rajarshi) Date: 2011-11-07 14:54 Message: Applied. But after applying, the build fails: compile-module: [echo] Compiling classes for CDK's smiles module from src/main... [echo] Datafiles defined: ${module.datafiles.present} [echo] Extra files defined: ${module.extrafiles.present} [echo] CDK dependencies defined: true [echo] Library dependencies defined: true [echo] Developer Library dependencies defined: ${module.devellibdepends.present} [echo] Autogenerated files specified: ${module.autogenerated.present} [mkdir] Created dir: /Users/rguha/src/java/cdk/build/src/smiles [mkdir] Created dir: /Users/rguha/src/java/cdk/build/smiles [copy] Copying 8 files to /Users/rguha/src/java/cdk/build/src/smiles [javac] Compiling 8 source files to /Users/rguha/src/java/cdk/build/smiles [javac] /Users/rguha/src/java/cdk/build/src/smiles/org/openscience/cdk/smiles/SmilesParser.java:49: cannot find symbol [javac] symbol : class TetrahedralChirality [javac] location: package org.openscience.cdk.stereo [javac] import org.openscience.cdk.stereo.TetrahedralChirality; [javac] ^ [javac] /Users/rguha/src/java/cdk/build/src/smiles/org/openscience/cdk/smiles/DeduceBondSystemTool.java:34: cannot find symbol [javac] symbol : class Atom [javac] location: package org.openscience.cdk [javac] import org.openscience.cdk.Atom; [javac] ^ [javac] /Users/rguha/src/java/cdk/build/src/smiles/org/openscience/cdk/smiles/DeduceBondSystemTool.java:36: cannot find symbol [javac] symbol : class Molecule [javac] location: package org.openscience.cdk [javac] import org.openscience.cdk.Molecule; ... ---------------------------------------------------------------------- Comment By: Egon Willighagen (egonw) Date: 2011-11-07 05:42 Message: This patch probably depends on these patches to be applied to: https://sourceforge.net/tracker/?func=detail&aid=3411511&group_id=20024&atid=320024 https://sourceforge.net/tracker/?func=detail&aid=3411538&group_id=20024&atid=320024 ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3434496&group_id=20024 |