From: SourceForge.net <no...@so...> - 2012-07-28 16:22:20
|
Patches item #3550908, was opened at 2012-07-28 09:22 Message generated for change (Tracker Item Submitted) made by egonw You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3550908&group_id=20024 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: master Group: Needs Review Status: Open Resolution: None Priority: 5 Private: No Submitted By: Egon Willighagen (egonw) Assigned to: Nobody/Anonymous (nobody) Summary: Additional unit tests for the dict module Initial Comment: Added some 77 new tests. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3550908&group_id=20024 |
From: SourceForge.net <no...@so...> - 2012-07-29 20:58:46
|
Patches item #3550908, was opened at 2012-07-28 09:22 Message generated for change (Comment added) made by jwmay You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3550908&group_id=20024 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: master Group: Needs Review Status: Open Resolution: None Priority: 5 Private: No Submitted By: Egon Willighagen (egonw) Assigned to: Nobody/Anonymous (nobody) Summary: Additional unit tests for the dict module Initial Comment: Added some 77 new tests. ---------------------------------------------------------------------- Comment By: John May (jwmay) Date: 2012-07-29 13:58 Message: Looks good ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3550908&group_id=20024 |
From: SourceForge.net <no...@so...> - 2012-07-30 06:16:03
|
Patches item #3550908, was opened at 2012-07-28 09:22 Message generated for change (Comment added) made by egonw You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3550908&group_id=20024 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: master Group: Needs Review Status: Open Resolution: None Priority: 5 Private: No Submitted By: Egon Willighagen (egonw) Assigned to: Nobody/Anonymous (nobody) Summary: Additional unit tests for the dict module Initial Comment: Added some 77 new tests. ---------------------------------------------------------------------- >Comment By: Egon Willighagen (egonw) Date: 2012-07-29 23:16 Message: Ah, John... can you sign off the patch, and upload a new patch (or put it on GitHub)? You can do that by applying the patch (making sure it compiles), and then run: git commit --amend --signoff Then people later can see you reviewed it. You should also set the "Group" field of this ticket to "Accepted" or "Needs revision" based on the outcome of your reviewing... ---------------------------------------------------------------------- Comment By: John May (jwmay) Date: 2012-07-29 13:58 Message: Looks good ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3550908&group_id=20024 |
From: SourceForge.net <no...@so...> - 2012-08-02 14:47:04
|
Patches item #3550908, was opened at 2012-07-28 09:22 Message generated for change (Comment added) made by jwmay You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3550908&group_id=20024 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: master Group: Needs Review Status: Open Resolution: None Priority: 5 Private: No Submitted By: Egon Willighagen (egonw) Assigned to: Nobody/Anonymous (nobody) Summary: Additional unit tests for the dict module Initial Comment: Added some 77 new tests. ---------------------------------------------------------------------- Comment By: John May (jwmay) Date: 2012-08-02 07:47 Message: I can't change the group - do I need to be added to the SF project? ---------------------------------------------------------------------- Comment By: Egon Willighagen (egonw) Date: 2012-07-29 23:16 Message: Ah, John... can you sign off the patch, and upload a new patch (or put it on GitHub)? You can do that by applying the patch (making sure it compiles), and then run: git commit --amend --signoff Then people later can see you reviewed it. You should also set the "Group" field of this ticket to "Accepted" or "Needs revision" based on the outcome of your reviewing... ---------------------------------------------------------------------- Comment By: John May (jwmay) Date: 2012-07-29 13:58 Message: Looks good ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3550908&group_id=20024 |
From: SourceForge.net <no...@so...> - 2012-08-02 14:50:01
|
Patches item #3550908, was opened at 2012-07-28 09:22 Message generated for change (Comment added) made by egonw You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3550908&group_id=20024 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: master Group: Needs Review Status: Open Resolution: None Priority: 5 Private: No Submitted By: Egon Willighagen (egonw) Assigned to: Nobody/Anonymous (nobody) Summary: Additional unit tests for the dict module Initial Comment: Added some 77 new tests. ---------------------------------------------------------------------- >Comment By: Egon Willighagen (egonw) Date: 2012-08-02 07:50 Message: Yes, but please try now. ---------------------------------------------------------------------- Comment By: John May (jwmay) Date: 2012-08-02 07:47 Message: I can't change the group - do I need to be added to the SF project? ---------------------------------------------------------------------- Comment By: Egon Willighagen (egonw) Date: 2012-07-29 23:16 Message: Ah, John... can you sign off the patch, and upload a new patch (or put it on GitHub)? You can do that by applying the patch (making sure it compiles), and then run: git commit --amend --signoff Then people later can see you reviewed it. You should also set the "Group" field of this ticket to "Accepted" or "Needs revision" based on the outcome of your reviewing... ---------------------------------------------------------------------- Comment By: John May (jwmay) Date: 2012-07-29 13:58 Message: Looks good ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3550908&group_id=20024 |
From: SourceForge.net <no...@so...> - 2012-08-02 16:08:17
|
Patches item #3550908, was opened at 2012-07-28 09:22 Message generated for change (Comment added) made by jwmay You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3550908&group_id=20024 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: master Group: Needs Review Status: Open Resolution: None Priority: 5 Private: No Submitted By: Egon Willighagen (egonw) Assigned to: Nobody/Anonymous (nobody) Summary: Additional unit tests for the dict module Initial Comment: Added some 77 new tests. ---------------------------------------------------------------------- Comment By: John May (jwmay) Date: 2012-08-02 09:08 Message: Applied and signed: patch/3550908 ---------------------------------------------------------------------- Comment By: Egon Willighagen (egonw) Date: 2012-08-02 07:50 Message: Yes, but please try now. ---------------------------------------------------------------------- Comment By: John May (jwmay) Date: 2012-08-02 07:47 Message: I can't change the group - do I need to be added to the SF project? ---------------------------------------------------------------------- Comment By: Egon Willighagen (egonw) Date: 2012-07-29 23:16 Message: Ah, John... can you sign off the patch, and upload a new patch (or put it on GitHub)? You can do that by applying the patch (making sure it compiles), and then run: git commit --amend --signoff Then people later can see you reviewed it. You should also set the "Group" field of this ticket to "Accepted" or "Needs revision" based on the outcome of your reviewing... ---------------------------------------------------------------------- Comment By: John May (jwmay) Date: 2012-07-29 13:58 Message: Looks good ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3550908&group_id=20024 |
From: SourceForge.net <no...@so...> - 2012-08-02 16:08:26
|
Patches item #3550908, was opened at 2012-07-28 09:22 Message generated for change (Settings changed) made by jwmay You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3550908&group_id=20024 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: master >Group: Accepted Status: Open Resolution: None Priority: 5 Private: No Submitted By: Egon Willighagen (egonw) Assigned to: Nobody/Anonymous (nobody) Summary: Additional unit tests for the dict module Initial Comment: Added some 77 new tests. ---------------------------------------------------------------------- Comment By: John May (jwmay) Date: 2012-08-02 09:08 Message: Applied and signed: patch/3550908 ---------------------------------------------------------------------- Comment By: Egon Willighagen (egonw) Date: 2012-08-02 07:50 Message: Yes, but please try now. ---------------------------------------------------------------------- Comment By: John May (jwmay) Date: 2012-08-02 07:47 Message: I can't change the group - do I need to be added to the SF project? ---------------------------------------------------------------------- Comment By: Egon Willighagen (egonw) Date: 2012-07-29 23:16 Message: Ah, John... can you sign off the patch, and upload a new patch (or put it on GitHub)? You can do that by applying the patch (making sure it compiles), and then run: git commit --amend --signoff Then people later can see you reviewed it. You should also set the "Group" field of this ticket to "Accepted" or "Needs revision" based on the outcome of your reviewing... ---------------------------------------------------------------------- Comment By: John May (jwmay) Date: 2012-07-29 13:58 Message: Looks good ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3550908&group_id=20024 |
From: SourceForge.net <no...@so...> - 2012-08-02 17:51:18
|
Patches item #3550908, was opened at 2012-07-28 09:22 Message generated for change (Comment added) made by egonw You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3550908&group_id=20024 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: master Group: Accepted >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: Egon Willighagen (egonw) Assigned to: Nobody/Anonymous (nobody) Summary: Additional unit tests for the dict module Initial Comment: Added some 77 new tests. ---------------------------------------------------------------------- >Comment By: Egon Willighagen (egonw) Date: 2012-08-02 10:51 Message: OK, thanx. Absolutely no comments at all? ---------------------------------------------------------------------- Comment By: John May (jwmay) Date: 2012-08-02 09:08 Message: Applied and signed: patch/3550908 ---------------------------------------------------------------------- Comment By: Egon Willighagen (egonw) Date: 2012-08-02 07:50 Message: Yes, but please try now. ---------------------------------------------------------------------- Comment By: John May (jwmay) Date: 2012-08-02 07:47 Message: I can't change the group - do I need to be added to the SF project? ---------------------------------------------------------------------- Comment By: Egon Willighagen (egonw) Date: 2012-07-29 23:16 Message: Ah, John... can you sign off the patch, and upload a new patch (or put it on GitHub)? You can do that by applying the patch (making sure it compiles), and then run: git commit --amend --signoff Then people later can see you reviewed it. You should also set the "Group" field of this ticket to "Accepted" or "Needs revision" based on the outcome of your reviewing... ---------------------------------------------------------------------- Comment By: John May (jwmay) Date: 2012-07-29 13:58 Message: Looks good ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3550908&group_id=20024 |