From: SourceForge.net <no...@so...> - 2012-07-28 16:40:53
|
Patches item #3550912, was opened at 2012-07-28 09:40 Message generated for change (Tracker Item Submitted) made by egonw You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3550912&group_id=20024 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: master Group: Needs Revision Status: Open Resolution: None Priority: 5 Private: No Submitted By: Egon Willighagen (egonw) Assigned to: Jonathan Alvarsson (jonalv) Summary: Fixes for the signature fingerprinter's unit tests Initial Comment: ... adding a missing unit test, and updating a test for a method previously unimplemented. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3550912&group_id=20024 |
From: SourceForge.net <no...@so...> - 2012-07-30 10:14:47
|
Patches item #3550912, was opened at 2012-07-28 09:40 Message generated for change (Comment added) made by jonalv You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3550912&group_id=20024 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: master >Group: Accepted Status: Open >Resolution: Accepted Priority: 5 Private: No Submitted By: Egon Willighagen (egonw) Assigned to: Jonathan Alvarsson (jonalv) Summary: Fixes for the signature fingerprinter's unit tests Initial Comment: ... adding a missing unit test, and updating a test for a method previously unimplemented. ---------------------------------------------------------------------- >Comment By: Jonathan Alvarsson (jonalv) Date: 2012-07-30 03:14 Message: Looks good. I had some complaints about now newline at end of file but that can't be so important can it? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3550912&group_id=20024 |
From: SourceForge.net <no...@so...> - 2012-07-30 10:53:39
|
Patches item #3550912, was opened at 2012-07-28 09:40 Message generated for change (Comment added) made by egonw You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3550912&group_id=20024 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: master >Group: Needs Revision Status: Open >Resolution: None Priority: 5 Private: No Submitted By: Egon Willighagen (egonw) Assigned to: Jonathan Alvarsson (jonalv) Summary: Fixes for the signature fingerprinter's unit tests Initial Comment: ... adding a missing unit test, and updating a test for a method previously unimplemented. ---------------------------------------------------------------------- >Comment By: Egon Willighagen (egonw) Date: 2012-07-30 03:53 Message: :) I'll take the newline comment into account next time... I hardly ever edit the last line, and guess this is git magic in action? ---------------------------------------------------------------------- Comment By: Jonathan Alvarsson (jonalv) Date: 2012-07-30 03:14 Message: Looks good. I had some complaints about now newline at end of file but that can't be so important can it? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3550912&group_id=20024 |
From: SourceForge.net <no...@so...> - 2012-08-02 08:50:49
|
Patches item #3550912, was opened at 2012-07-28 09:40 Message generated for change (Comment added) made by egonw You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3550912&group_id=20024 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: master >Group: Accepted >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: Egon Willighagen (egonw) Assigned to: Jonathan Alvarsson (jonalv) Summary: Fixes for the signature fingerprinter's unit tests Initial Comment: ... adding a missing unit test, and updating a test for a method previously unimplemented. ---------------------------------------------------------------------- >Comment By: Egon Willighagen (egonw) Date: 2012-08-02 01:50 Message: Thanx for the review! ---------------------------------------------------------------------- Comment By: Egon Willighagen (egonw) Date: 2012-07-30 03:53 Message: :) I'll take the newline comment into account next time... I hardly ever edit the last line, and guess this is git magic in action? ---------------------------------------------------------------------- Comment By: Jonathan Alvarsson (jonalv) Date: 2012-07-30 03:14 Message: Looks good. I had some complaints about now newline at end of file but that can't be so important can it? ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3550912&group_id=20024 |