From: SourceForge.net <no...@so...> - 2010-10-24 11:25:44
|
Patches item #3067857, was opened at 2010-09-16 21:33 Message generated for change (Comment added) made by egonw You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3067857&group_id=20024 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. >Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Wayne Volkmuth (volkmuth) Assigned to: Nobody/Anonymous (nobody) Summary: copy/paste to/from other drawing tools (w/ patch) Initial Comment: Attached is a patch against 3.0.1 adding a native flavor of MDLCT, a lowest common denominator clipboard format supported by e.g. ChemDraw and ISIS/Draw. MDLCT is MDL Mol format except that individual lines are concatenated, Pascal-like strings with no EOL separating them. I've tested the patch with ChemDraw and ISIS/Draw. Copy/paste works in both to and from JChemPaint and those two apps. I'm happy to clean this up for trunk if someone will guide me (offline) so that I follow your coding standards. There's a philosophical question: I put the MDLCT reading/writing into CopyPasteAction. Arguably it belongs in CDK itself but I was reluctant to "pollute" CDK with a class for a format that is, so far as I can tell, only used by applications in interactions with the clipboard. On the other hand, any CDK-based GUI app probably wants to support copy/paste to/from popular commercial software, so putting it into CDK avoids the need to have each GUI app reinvent the wheel. ---------------------------------------------------------------------- >Comment By: Egon Willighagen (egonw) Date: 2010-10-24 13:25 Message: Patch filed with JChemPaint too, at: https://sourceforge.net/apps/trac/jchempaint/attachment/ticket/114/ ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3067857&group_id=20024 |
From: SourceForge.net <no...@so...> - 2012-02-20 09:35:21
|
Patches item #3067857, was opened at 2010-09-16 12:33 Message generated for change (Comment added) made by egonw You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3067857&group_id=20024 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed >Resolution: Duplicate Priority: 5 Private: No Submitted By: Wayne Volkmuth (volkmuth) Assigned to: Nobody/Anonymous (nobody) Summary: copy/paste to/from other drawing tools (w/ patch) Initial Comment: Attached is a patch against 3.0.1 adding a native flavor of MDLCT, a lowest common denominator clipboard format supported by e.g. ChemDraw and ISIS/Draw. MDLCT is MDL Mol format except that individual lines are concatenated, Pascal-like strings with no EOL separating them. I've tested the patch with ChemDraw and ISIS/Draw. Copy/paste works in both to and from JChemPaint and those two apps. I'm happy to clean this up for trunk if someone will guide me (offline) so that I follow your coding standards. There's a philosophical question: I put the MDLCT reading/writing into CopyPasteAction. Arguably it belongs in CDK itself but I was reluctant to "pollute" CDK with a class for a format that is, so far as I can tell, only used by applications in interactions with the clipboard. On the other hand, any CDK-based GUI app probably wants to support copy/paste to/from popular commercial software, so putting it into CDK avoids the need to have each GUI app reinvent the wheel. ---------------------------------------------------------------------- >Comment By: Egon Willighagen (egonw) Date: 2012-02-20 01:35 Message: Closing this now, as it is filed with JChemPaint already, and that the patch does not touch CDK itself. ---------------------------------------------------------------------- Comment By: Egon Willighagen (egonw) Date: 2010-10-24 04:25 Message: Patch filed with JChemPaint too, at: https://sourceforge.net/apps/trac/jchempaint/attachment/ticket/114/ ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3067857&group_id=20024 |
From: SourceForge.net <no...@so...> - 2012-02-20 09:39:54
|
Patches item #3067857, was opened at 2010-09-16 12:33 Message generated for change (Comment added) made by egonw You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3067857&group_id=20024 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Closed Resolution: Duplicate Priority: 5 Private: No Submitted By: Wayne Volkmuth (volkmuth) Assigned to: Nobody/Anonymous (nobody) Summary: copy/paste to/from other drawing tools (w/ patch) Initial Comment: Attached is a patch against 3.0.1 adding a native flavor of MDLCT, a lowest common denominator clipboard format supported by e.g. ChemDraw and ISIS/Draw. MDLCT is MDL Mol format except that individual lines are concatenated, Pascal-like strings with no EOL separating them. I've tested the patch with ChemDraw and ISIS/Draw. Copy/paste works in both to and from JChemPaint and those two apps. I'm happy to clean this up for trunk if someone will guide me (offline) so that I follow your coding standards. There's a philosophical question: I put the MDLCT reading/writing into CopyPasteAction. Arguably it belongs in CDK itself but I was reluctant to "pollute" CDK with a class for a format that is, so far as I can tell, only used by applications in interactions with the clipboard. On the other hand, any CDK-based GUI app probably wants to support copy/paste to/from popular commercial software, so putting it into CDK avoids the need to have each GUI app reinvent the wheel. ---------------------------------------------------------------------- >Comment By: Egon Willighagen (egonw) Date: 2012-02-20 01:39 Message: Wayne, a patch for the MDLCT is most welcome, btw! (and I wish the CDK community had more resources to do things, so that that should not have taken 18 months to get a reply... I am deeply sorry about that...) Regarding the coding for that: - write a IChemFormat class for MDLCT - write a reader I can assist, by creating the format class or so... ---------------------------------------------------------------------- Comment By: Egon Willighagen (egonw) Date: 2012-02-20 01:35 Message: Closing this now, as it is filed with JChemPaint already, and that the patch does not touch CDK itself. ---------------------------------------------------------------------- Comment By: Egon Willighagen (egonw) Date: 2010-10-24 04:25 Message: Patch filed with JChemPaint too, at: https://sourceforge.net/apps/trac/jchempaint/attachment/ticket/114/ ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3067857&group_id=20024 |