From: SourceForge.net <no...@so...> - 2010-08-30 11:13:35
|
Patches item #3055976, was opened at 2010-08-30 12:13 Message generated for change (Tracker Item Submitted) made by asadrahman You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3055976&group_id=20024 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: master Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Asad (asadrahman) Assigned to: Nobody/Anonymous (nobody) Summary: Missing SMSD 1.2.0 patches Initial Comment: The first commit and changes in the CDK has lead to changes in the SMSD lib. I am attaching the updated code/missing patches for review. Thanks Asad ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3055976&group_id=20024 |
From: SourceForge.net <no...@so...> - 2010-08-30 11:52:03
|
Patches item #3055976, was opened at 2010-08-30 13:13 Message generated for change (Settings changed) made by egonw You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3055976&group_id=20024 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: master >Group: Needs Revision Status: Open Resolution: None Priority: 5 Private: No Submitted By: Asad (asadrahman) >Assigned to: Asad (asadrahman) Summary: Missing SMSD 1.2.0 patches Initial Comment: The first commit and changes in the CDK has lead to changes in the SMSD lib. I am attaching the updated code/missing patches for review. Thanks Asad ---------------------------------------------------------------------- >Comment By: Egon Willighagen (egonw) Date: 2010-08-30 13:52 Message: >From IRC: [08/30/10 13:43] <egonw> s9asad: patch 0001: the commit message is incorrect [08/30/10 13:43] <egonw> it does not just add IMatcher, it also removes many files... ?? [08/30/10 13:44] <egonw> e.g. it remov Isomorphism.java which is added by 0002 again ?? [08/30/10 13:44] <egonw> 0003: new methods in this patch do not have JavaDoc [08/30/10 13:46] <egonw> 0004: you could split up that patch into: 0004a: remove outcommented code; 0004b: updated for change in index API: what used to be null is now reflected as -1 (which I guess what is going on) [08/30/10 13:47] <egonw> 0005: you import the wrong Assert class... use the org.junit.Assert instead [08/30/10 13:48] <egonw> "a)constructor call fixed" -> bad commit message... instead, describe what was wrong, and *how* you fixed it [08/30/10 13:49] <egonw> (that was 0006) [08/30/10 13:50] <egonw> 0007: there is no need to add empty methods for @BeforeClass, @AfterClass, and @After ... empty constructors are not needed either [08/30/10 13:51] <egonw> oh.... and 0001 does not even add an IMatcher interface as promised in the commit message ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3055976&group_id=20024 |
From: SourceForge.net <no...@so...> - 2010-08-30 14:58:29
|
Patches item #3055976, was opened at 2010-08-30 12:13 Message generated for change (Comment added) made by asadrahman You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3055976&group_id=20024 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: master Group: Needs Revision Status: Open Resolution: None Priority: 5 Private: No Submitted By: Asad (asadrahman) Assigned to: Asad (asadrahman) Summary: Missing SMSD 1.2.0 patches Initial Comment: The first commit and changes in the CDK has lead to changes in the SMSD lib. I am attaching the updated code/missing patches for review. Thanks Asad ---------------------------------------------------------------------- Comment By: Asad (asadrahman) Date: 2010-08-30 15:58 Message: I have updated the patches as advised. ---------------------------------------------------------------------- Comment By: Egon Willighagen (egonw) Date: 2010-08-30 12:52 Message: >From IRC: [08/30/10 13:43] <egonw> s9asad: patch 0001: the commit message is incorrect [08/30/10 13:43] <egonw> it does not just add IMatcher, it also removes many files... ?? [08/30/10 13:44] <egonw> e.g. it remov Isomorphism.java which is added by 0002 again ?? [08/30/10 13:44] <egonw> 0003: new methods in this patch do not have JavaDoc [08/30/10 13:46] <egonw> 0004: you could split up that patch into: 0004a: remove outcommented code; 0004b: updated for change in index API: what used to be null is now reflected as -1 (which I guess what is going on) [08/30/10 13:47] <egonw> 0005: you import the wrong Assert class... use the org.junit.Assert instead [08/30/10 13:48] <egonw> "a)constructor call fixed" -> bad commit message... instead, describe what was wrong, and *how* you fixed it [08/30/10 13:49] <egonw> (that was 0006) [08/30/10 13:50] <egonw> 0007: there is no need to add empty methods for @BeforeClass, @AfterClass, and @After ... empty constructors are not needed either [08/30/10 13:51] <egonw> oh.... and 0001 does not even add an IMatcher interface as promised in the commit message ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3055976&group_id=20024 |
From: SourceForge.net <no...@so...> - 2010-08-30 15:06:57
|
Patches item #3055976, was opened at 2010-08-30 13:13 Message generated for change (Comment added) made by egonw You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3055976&group_id=20024 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: master >Group: Accepted Status: Open Resolution: None Priority: 5 Private: No Submitted By: Asad (asadrahman) Assigned to: Asad (asadrahman) Summary: Missing SMSD 1.2.0 patches Initial Comment: The first commit and changes in the CDK has lead to changes in the SMSD lib. I am attaching the updated code/missing patches for review. Thanks Asad ---------------------------------------------------------------------- >Comment By: Egon Willighagen (egonw) Date: 2010-08-30 17:06 Message: OK, the patches are much more clean now. I can now actually understand what has changed. There are problems with the patches, which I'll ask you to fix later: * "Default constructor added" is not a proper JavaDoc... JavaDoc is not for developer documentation * there is JavaDoc lacking here and there (please check the Nightly reports for the SMSD module and try to fix some of them... perhaps ask people to help you with that... these can be good junior jobs (see the special tracker)) ---------------------------------------------------------------------- Comment By: Asad (asadrahman) Date: 2010-08-30 16:58 Message: I have updated the patches as advised. ---------------------------------------------------------------------- Comment By: Egon Willighagen (egonw) Date: 2010-08-30 13:52 Message: >From IRC: [08/30/10 13:43] <egonw> s9asad: patch 0001: the commit message is incorrect [08/30/10 13:43] <egonw> it does not just add IMatcher, it also removes many files... ?? [08/30/10 13:44] <egonw> e.g. it remov Isomorphism.java which is added by 0002 again ?? [08/30/10 13:44] <egonw> 0003: new methods in this patch do not have JavaDoc [08/30/10 13:46] <egonw> 0004: you could split up that patch into: 0004a: remove outcommented code; 0004b: updated for change in index API: what used to be null is now reflected as -1 (which I guess what is going on) [08/30/10 13:47] <egonw> 0005: you import the wrong Assert class... use the org.junit.Assert instead [08/30/10 13:48] <egonw> "a)constructor call fixed" -> bad commit message... instead, describe what was wrong, and *how* you fixed it [08/30/10 13:49] <egonw> (that was 0006) [08/30/10 13:50] <egonw> 0007: there is no need to add empty methods for @BeforeClass, @AfterClass, and @After ... empty constructors are not needed either [08/30/10 13:51] <egonw> oh.... and 0001 does not even add an IMatcher interface as promised in the commit message ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3055976&group_id=20024 |
From: SourceForge.net <no...@so...> - 2010-08-30 15:10:46
|
Patches item #3055976, was opened at 2010-08-30 12:13 Message generated for change (Comment added) made by asadrahman You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3055976&group_id=20024 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: master Group: Accepted Status: Open Resolution: None Priority: 5 Private: No Submitted By: Asad (asadrahman) Assigned to: Asad (asadrahman) Summary: Missing SMSD 1.2.0 patches Initial Comment: The first commit and changes in the CDK has lead to changes in the SMSD lib. I am attaching the updated code/missing patches for review. Thanks Asad ---------------------------------------------------------------------- Comment By: Asad (asadrahman) Date: 2010-08-30 16:10 Message: OK, will try and update the docs in the next version/submission. ---------------------------------------------------------------------- Comment By: Egon Willighagen (egonw) Date: 2010-08-30 16:06 Message: OK, the patches are much more clean now. I can now actually understand what has changed. There are problems with the patches, which I'll ask you to fix later: * "Default constructor added" is not a proper JavaDoc... JavaDoc is not for developer documentation * there is JavaDoc lacking here and there (please check the Nightly reports for the SMSD module and try to fix some of them... perhaps ask people to help you with that... these can be good junior jobs (see the special tracker)) ---------------------------------------------------------------------- Comment By: Asad (asadrahman) Date: 2010-08-30 15:58 Message: I have updated the patches as advised. ---------------------------------------------------------------------- Comment By: Egon Willighagen (egonw) Date: 2010-08-30 12:52 Message: >From IRC: [08/30/10 13:43] <egonw> s9asad: patch 0001: the commit message is incorrect [08/30/10 13:43] <egonw> it does not just add IMatcher, it also removes many files... ?? [08/30/10 13:44] <egonw> e.g. it remov Isomorphism.java which is added by 0002 again ?? [08/30/10 13:44] <egonw> 0003: new methods in this patch do not have JavaDoc [08/30/10 13:46] <egonw> 0004: you could split up that patch into: 0004a: remove outcommented code; 0004b: updated for change in index API: what used to be null is now reflected as -1 (which I guess what is going on) [08/30/10 13:47] <egonw> 0005: you import the wrong Assert class... use the org.junit.Assert instead [08/30/10 13:48] <egonw> "a)constructor call fixed" -> bad commit message... instead, describe what was wrong, and *how* you fixed it [08/30/10 13:49] <egonw> (that was 0006) [08/30/10 13:50] <egonw> 0007: there is no need to add empty methods for @BeforeClass, @AfterClass, and @After ... empty constructors are not needed either [08/30/10 13:51] <egonw> oh.... and 0001 does not even add an IMatcher interface as promised in the commit message ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3055976&group_id=20024 |
From: SourceForge.net <no...@so...> - 2010-08-30 15:37:28
|
Patches item #3055976, was opened at 2010-08-30 13:13 Message generated for change (Comment added) made by egonw You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3055976&group_id=20024 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: master Group: Accepted >Status: Closed >Resolution: Fixed Priority: 5 Private: No Submitted By: Asad (asadrahman) Assigned to: Asad (asadrahman) Summary: Missing SMSD 1.2.0 patches Initial Comment: The first commit and changes in the CDK has lead to changes in the SMSD lib. I am attaching the updated code/missing patches for review. Thanks Asad ---------------------------------------------------------------------- >Comment By: Egon Willighagen (egonw) Date: 2010-08-30 17:37 Message: Applied to master. ---------------------------------------------------------------------- Comment By: Asad (asadrahman) Date: 2010-08-30 17:10 Message: OK, will try and update the docs in the next version/submission. ---------------------------------------------------------------------- Comment By: Egon Willighagen (egonw) Date: 2010-08-30 17:06 Message: OK, the patches are much more clean now. I can now actually understand what has changed. There are problems with the patches, which I'll ask you to fix later: * "Default constructor added" is not a proper JavaDoc... JavaDoc is not for developer documentation * there is JavaDoc lacking here and there (please check the Nightly reports for the SMSD module and try to fix some of them... perhaps ask people to help you with that... these can be good junior jobs (see the special tracker)) ---------------------------------------------------------------------- Comment By: Asad (asadrahman) Date: 2010-08-30 16:58 Message: I have updated the patches as advised. ---------------------------------------------------------------------- Comment By: Egon Willighagen (egonw) Date: 2010-08-30 13:52 Message: >From IRC: [08/30/10 13:43] <egonw> s9asad: patch 0001: the commit message is incorrect [08/30/10 13:43] <egonw> it does not just add IMatcher, it also removes many files... ?? [08/30/10 13:44] <egonw> e.g. it remov Isomorphism.java which is added by 0002 again ?? [08/30/10 13:44] <egonw> 0003: new methods in this patch do not have JavaDoc [08/30/10 13:46] <egonw> 0004: you could split up that patch into: 0004a: remove outcommented code; 0004b: updated for change in index API: what used to be null is now reflected as -1 (which I guess what is going on) [08/30/10 13:47] <egonw> 0005: you import the wrong Assert class... use the org.junit.Assert instead [08/30/10 13:48] <egonw> "a)constructor call fixed" -> bad commit message... instead, describe what was wrong, and *how* you fixed it [08/30/10 13:49] <egonw> (that was 0006) [08/30/10 13:50] <egonw> 0007: there is no need to add empty methods for @BeforeClass, @AfterClass, and @After ... empty constructors are not needed either [08/30/10 13:51] <egonw> oh.... and 0001 does not even add an IMatcher interface as promised in the commit message ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=320024&aid=3055976&group_id=20024 |