From: Stefan K. <ste...@un...> - 2007-01-29 12:21:00
|
The point is (for me) that the parameter is optional. At least the GasteigerMasilliBla class has a default for it, so I think the descriptor should use the default as well - that's what my implementation does (I believe). Stefan Am Monday 29 January 2007 13:04 schrieb Egon Willighagen: > On Monday 29 January 2007, sh...@us... wrote: > > @@ -102,6 +102,8 @@ > > if (!(params[0] instanceof Integer) ){ > > throw new CDKException("The parameter must be of type > > Integer"); } > > + if(params.length=3D=3D0) > > + return; > > maxIterations =3D ((Integer) params[0]).intValue(); > > } > > Stefan, > > I am not sure this is the right way to do this: fail silently when > incorrect input has been given. The NPE it did before it not great eith= er, > but at least shows that something is wrong in the code of the user of t= his > class. > > At least I would suggest to throw a CDKException, like: > > if (params.length!=3D1) throw new CDKException("Expected one parameter = of > class Integer."); > > Or combine them into one if-statement: > > if (params.length!=3D1 || !(params[0] instanceof Integer) ){ > throw new CDKException("The parameter must be of type > Integer"); } > > There are likely many such incomplete testing in the QSAR descriptors, = as > everyone copy/pasted code :) > > Egon -- Stefan Kuhn B. Sc. M. A. Cologne University BioInformatics Center (http://www.cubic.uni-koeln.de) Z=FClpicher Str. 47, 50674 Cologne Tel: +49(0)221-470-7428 Fax: +49 (0) 221-470-7786 My public PGP key is available at http://pgp.mit.edu ------------------------------------------------------- --=20 Stefan Kuhn B. Sc. M. A. Cologne University BioInformatics Center (http://www.cubic.uni-koeln.de) Z=FClpicher Str. 47, 50674 Cologne Tel: +49(0)221-470-7428 Fax: +49 (0) 221-470-7786 My public PGP key is available at http://pgp.mit.edu |