On Friday 27 April 2007, Nina Jeliazkova wrote:
Here is the story.
1) Create (somehow) a structure as IMolecule (e.g. benzene with
alternating single/double bonds)
2) Run HueckelAromaticityDetector to perceive aromaticity
3) Write the structure into CML
4) Read the structure back from CML into a new IMolecule
5) Now the new IMolecule has bond orders 1.5 , while the origin one as in
1) has bond orders 1.0 and 2.0
Ah... that sounds like a bug. CDK in the early days used 1.5 bond order == an aromatic bond, but drop that in favour of IBond.setFlag(CDKConstancs.ISAROMATIC). Seems that the CMLReader has not been updated.
This doesn't break isomorphism test and fingerprints, but does break atom
types recognition as per HybridizationStateATMatcher. In this example,
atom types of the original molecule will be C.sp2, while in the new
molecule will be Caromatic.sp2.
Atom type perception is a tricky thing indeed. What suprises me that the first type is not aromatic too! Because you did do atomiticity detection. Actually, since the atom type list contains the the concept of aromaticity, it must be done prior to calling the perception tool. Maybe a second bug?
Not sure this breaks anything else than my atom environments code, but I am
wondering what's the best way to handle the issue.Attached is JUnit test.
Thanx!
Logged In: YES
user_id=25678
Originator: YES
I solved this by not storing aromatic bonds like:
<bond order="A"/>
but with:
<bond order="1">
<bondType dictRef="cdk:aromaticBond"/>
</bond>
see commit 8301.
Logged In: YES
user_id=1025007
Originator: NO
This solved the issue with bond aromaticity flags, however, atom aromaticity flag is lost in the CML roundtrip.
Reopened with respect to the atom aromaticity.
Bug fix patch for atom aromaticity is available from:
https://sourceforge.net/tracker/?group_id=20024&atid=320024
I presume this is fixed/quirk of CML. Marking for closure.