#1254 Incorrect Method on Manipulator

master
closed
nobody
None
5
2013-09-23
2012-09-19
John May
No

The atomcontainer manipulator which has a method named getTotalHydrogenCount which actually returns the number of implicit hydrogens only.

Patch
- Changed method to reflect it's name and actually get the total hydrogen count (+ modified unit test result)
- Added new method just for implicit hydrogens (+ unit tests)
- Checked usages of getTotalHydrogenCount and the only usages are in AtomContainer/Molecule-SetManipulator and have check the tests still pass for these also.
- Increased documentation

Could be applied to 1.4.x or master - as it's an change in functionality (to match method name) I would vote for master.

Discussion

  • John May

    John May - 2012-11-03

    okay cool will patch this up

     
  • John May

    John May - 2012-11-03
    • status: open --> accepted
     
  • John May

    John May - 2013-09-23
    • status: accepted --> closed