Re: [cclib-devel] Another Refactoring change

[Karol L. <kar...@kn...>]

On Monday 30 April 2007 08:54, Noel O'Boyle wrote:
> Maybe someone has already suggested this, but here's an idea to handle
> updating the "self.updateprogress".
>
> Every time an attribute is set by __setattr__, it should change the
> updateprogress string to the name of the attribute rather than having
> to do this in the subclass.

Good idea. This doesn't cover the whole range of situations 
LogFile.updateprogress is used in, though.

> Just a note:
>
> Line 197 of logfileparser:
>             self.updateprogress(inputfile, "Unsupported information",
> cupdate)
>
> If inputfile and cupdate are attributes of logfileparser, then there's
> no need to pass them in to updateprogress.

Yup.

-Karol

-- 
written by Karol Langner
Mon Apr 30 12:16:37 CEST 2007