Re: [cclib-devel] Refactoring

[Karol L. <kar...@kn...>]

On Thursday 01 of February 2007 17:55, Noel O'Boyle wrote:
> Nice work on the refactoring, Karol.

Thanks... it might be worthwhile to move some more things to LogFile.pares, 
but I need your input on these.

1)  The stuff before the loop (inputfile.seek, initialize self.progress, 
etc.). For this, inputfile, nstep, and oldstep would need to be attributes of 
the class. However, since they are temporary (parsing is never aborted before 
it's finished, I think), this may not be a good idea.

2) The code that uses cupdate, fupdate, nstep, and oldstep (condition "if 
self.progress and random.random() < fupdate") is repeated multiple times, but 
the same question arises as the above.

Could you perhaps explain the full purpose of LogFile.progress? Maybe there 
would be some advantages in making the logfile file object an attribute of 
LogFile (as in self.intputfile)?

Karol

-- 
written by Karol Langner
Fri Feb  2 12:21:24 CET 2007