Re: [cclib-devel] broken vibdisps

[Adam T. <a-t...@st...>]

> I would say that this is a regression, and so belongs in
> regressions.py. I would just do (1) but rather than save it to a text
> file I would just paste it into regression.py. Perhaps in future we
> should add a regression test to regression.py before rewriting
> sections.

I agree that it's a regression and so should go into regressions.py.  
And yes, we should probably make sure we have a regression test before  
rewriting sections.

> Is there any way of protecting against this particular sort of error
> in parsers, for example, by considering the effect of the error? I
> haven't checked but I think it caused the same data to be included
> several times as x, y, and z. Maybe we can test for this in testvib?

The error basically caused the first frequency of a set of three to be  
parsed correctly (ie. [x1, y1, z1]) while the second and third  
frequencies were parsed as [y1, z1, x2] and [z1, x2, y2], respectively.

Adam