From: Noel O'B. <bao...@gm...> - 2007-09-21 11:11:44
|
Karol, I'm getting bogged down in the changes you made to setup.py in r643. I didn't realise (from the log message at the time) that you had done this, and I'm not sure what the purpose of these changes are. You appear to have hardcoded the location of site-package on the user's system, for example. This is just asking for trouble... I'm trying to track down the problems with the files included in the distribution (when I create it on Windows). Currently, even the .svn directories in the data dir are being included. This encourages me to go back to using manifest.py, rather than MANIFEST.in... I'd like to get out a beta release as soon as possible... Noel |
From: Noel O'B. <bao...@gm...> - 2007-09-21 11:31:06
|
On 21/09/2007, Noel O'Boyle <bao...@gm...> wrote: > Karol, > > I'm getting bogged down in the changes you made to setup.py in r643. I > didn't realise (from the log message at the time) that you had done > this, and I'm not sure what the purpose of these changes are. You > appear to have hardcoded the location of site-package on the user's > system, for example. This is just asking for trouble... > > I'm trying to track down the problems with the files included in the > distribution (when I create it on Windows). Currently, even the .svn > directories in the data dir are being included. This encourages me to > go back to using manifest.py, rather than MANIFEST.in... This issue is resolved now. I just needed to clean out the temporary directories from the build, and there are no problems. Maybe it's all okay now...I'll try and see can I make another release.... > I'd like to get out a beta release as soon as possible... > > Noel > |
From: Karol L. <kar...@kn...> - 2007-09-21 23:34:31
|
On Friday 21 September 2007 07:31, Noel O'Boyle wrote: > On 21/09/2007, Noel O'Boyle <bao...@gm...> wrote: > > Karol, > > > > I'm getting bogged down in the changes you made to setup.py in r643. I > > didn't realise (from the log message at the time) that you had done > > this, and I'm not sure what the purpose of these changes are. The purpose was to simplify creating new source distributions, by not having to run manifest.py every time. According to the Pythons docs, MANIFEST.in s supposed to be platform-independent. > > You > > appear to have hardcoded the location of site-package on the user's > > system, for example. This is just asking for trouble... True. I generalized this in r682 (in the spirit of NumPy, if I remember correctly), although I'm not certain that it is now entirely OK. > > I'm trying to track down the problems with the files included in the > > distribution (when I create it on Windows). Currently, even the .svn > > directories in the data dir are being included. This encourages me to > > go back to using manifest.py, rather than MANIFEST.in... > > This issue is resolved now. I just needed to clean out the temporary > directories from the build, and there are no problems. Maybe it's all > okay now...I'll try and see can I make another release.... Please keep us informed on the list on how things are behaving on Windows. I test cclib on a daily basis only under Linux, so some things are bound to escape my attention. This is a marginal issue in terms of functonality, so it doesn't really matter which revision goes into 0.8b, as long as it works. > > I'd like to get out a beta release as soon as possible... I've been travelling alot in the past 2-3 weeks and been quite busy at work. In the nearest week(s) I will have the time to help out with any problems with the release. Cheers, Karol -- written by Karol Langner Sat Sep 22 01:10:51 EDT 2007 |
From: Noel O'B. <bao...@gm...> - 2007-09-22 12:12:33
|
On 22/09/2007, Karol Langner <kar...@kn...> wrote: > On Friday 21 September 2007 07:31, Noel O'Boyle wrote: > > On 21/09/2007, Noel O'Boyle <bao...@gm...> wrote: > > > Karol, > > > > > > I'm getting bogged down in the changes you made to setup.py in r643. I > > > didn't realise (from the log message at the time) that you had done > > > this, and I'm not sure what the purpose of these changes are. > The purpose was to simplify creating new source distributions, by not having > to run manifest.py every time. According to the Pythons docs, MANIFEST.in s > supposed to be platform-independent. I think the MANIFEST.in is probably fine (although I'm not sure :-/). The problem is that there were several changes around that time and I couldn't figure out which was causing the specific problem. For example, when I removed all references to the data directory from MANIFEST.in, it still copied the data directory into the installation (and I tried deleting all temporary directories and so on). Once we've done the release, I'd like to spend a little time on this going through step by step, and discussing the results with you guys. It's not very interesting, of course. > > > You > > > appear to have hardcoded the location of site-package on the user's > > > system, for example. This is just asking for trouble... > True. I generalized this in r682 (in the spirit of NumPy, if I remember > correctly), although I'm not certain that it is now entirely OK. > > > > I'm trying to track down the problems with the files included in the > > > distribution (when I create it on Windows). Currently, even the .svn > > > directories in the data dir are being included. This encourages me to > > > go back to using manifest.py, rather than MANIFEST.in... > > > > This issue is resolved now. I just needed to clean out the temporary > > directories from the build, and there are no problems. Maybe it's all > > okay now...I'll try and see can I make another release.... > Please keep us informed on the list on how things are behaving on Windows. I > test cclib on a daily basis only under Linux, so some things are bound to > escape my attention. This is a marginal issue in terms of functonality, so it > doesn't really matter which revision goes into 0.8b, as long as it works. It was only when I concentrated on making a distribution that I realised that there were problems. The "setup.py install" has been working fine. > > > I'd like to get out a beta release as soon as possible... > I've been travelling alot in the past 2-3 weeks and been quite busy at work. > In the nearest week(s) I will have the time to help out with any problems > with the release. > > Cheers, > Karol > > -- > written by Karol Langner > Sat Sep 22 01:10:51 EDT 2007 > |