From: Nikodemus S. <nik...@ra...> - 2009-05-05 07:16:56
|
2009/5/4 Robert Goldman <rpg...@si...>: > As I understand things, we should, if we are working on a particular > improvement, move ourselves onto a branch, make our changes, and then > offer up the changes for some flavor of review, right? > > Can someone explain to me how the final step is done? I have only done > this using org, where my changes were small enough that they could be > eyeballed in patch files. Since we have not discussed it, I assume sending patches to the mailing list remains the preferred format. > But I have been working to get Marco's CLEAN-OP incorporated into ASDF, > and this involves adding files (notably in order to make tests). This > puts me, I think, beyond the realm of easily reviewed patches. Not really: with git those patches are best produced using "git format-patch -<small integer", which deals with new files just fine. > In this case does one provide a branch in the common-lisp.net repo? Should one > create one's own public repository? To the first, I would say no. I would suggest that we don't add feature branches to the main repository. Adding an "unstable" branch might be worth considering, though -- and put new features and API changes there initially. To the second, I would say that it's not really necessary. Not unless you feel that your work is being ignored, or unless you know that there are people who want to pull from yourself, or because you figure you want a backup for your local tree... Cheers, -- Nikodemus |