Re: [cclan-list] Circularity detection fix exposed a bug

[Gary K. <gw...@me...>]

Hi Richard,

I've been meaning to post about this for the last two days but hadn't  
found the time to look for a fix yet. I'm glad you beat me to it!

On Sep 9, 2008, at 10:48 AM, Richard M Kreuter wrote:

> After the circularity detection patch applied in 1.125, test3 fails  
> with
> a spurious CIRCULAR-DEPENDENCY error.  I think the trouble is that
> TRAVERSE fails to unvisit an operation/component pair at least for
> feature-dependencies, and maybe elsewhere.  The patch below does the
> un-visiting in an UNWIND-PROTECT cleanup, so should ensure that ASDF
> always unvisit as desired.  All the tests pass with this change, but  
> I'm
> not really confident about anything TRAVERSE-related.  Does this look
> like a reasonable thing to do?


I think your fix makes good sense. I'll try it with my systems and  
then if no one else objects, I'll commit it.

I wonder if we're close to the time to rewrite traverse and friends  
with generic functions (since all the lisps we love now handle method  
combinations...).

thanks
--
Gary Warren King, metabang.com
Cell: (413) 559 8738
Fax: (206) 338-4052
gwkkwg on Skype * garethsan on AIM