Re: [ccextractor-users] [GSoC] Test suite - latest test round - Including Ruslan's patch
Brought to you by:
cfsmp3
|
From: Willem V. I. <wil...@gm...> - 2014-06-02 09:11:19
|
-----BEGIN PGP SIGNED MESSAGE----- Hash: SHA1 Hello, These files were indeed working in 0.69 and are broken. Some just a little bit... I'll give a brief summary of them: Regression/Correct/No XDS/CBLT.mpg With this one there's one line different. Instead of "TO ALWAYS BE", the current github makes "EWAYS", which looks like ".....WAYS..E" and then mangled. I think it is linked to the Victoria justice fix. Regression/Correct/With XDS/images.mpg This was broken in 0.69 already (last working in 0.66), but is a little worse since the Victoria Justice patch. Ruslan commented then that this was a tricky one (mail from 22 May) Regression/Minor issues/163ce77200976977847a5d66a537871b.20110901205100.mpg This one has the first line (a POP) that disappeared. 0.69 still shows it. One I didn't mention in the mail yesterday is the file in the ProtectedWTV folder. protected.wtv can be extracted on windows with the current 0.69 release, but on linux (both 0.69 and the latest github built) result in a "segfault" error, generating no output. Sincerely, Willem On 2/06/2014 10:35, Carlos Fernandez wrote: > OK so all these files used to work in 0.69 but now they don't, > even with Ruslan's patch? > > I've accept all pending pull requests, including Ruslan's. But > until the files that used to work work again we can't release... > Ruslan, can you investigate where we broke this? :-) > > I'm already in the US, but of course I'm totally jetlagged (3:34 > AM here) so I'm going to be working on European time for a few > days. Plus of course nothing to do for the next 4 hours. > > > On Sun, Jun 1, 2014 at 7:15 AM, Willem van iseghem > <wil...@gm...> wrote: >> Hello all, >> >> I've ran the latest version of CCExtractor from Github, and then >> the latest with Ruslan's patch. >> >> I'll give an overview of the broken files: >> >> Current github repo (compared to 0.69, and verified to be worse >> than 0.69): >> >> Regression/Correct/No XDS/CBLT.mpg Regression/Correct/No >> XDS/glenn_beck_20110425_1657.ts Regression/Correct/With >> XDS/CCSample1.mpg Regression/Correct/With XDS/images.mpg >> Regression/Correct/With >> XDS/The.Colbert.Report.2011-09-12.1080i.HDTV.MPEG-2-CtrlHD.ts >> Regression/Correct/With >> XDS/The.Daily.Show.with.Jon.Stewart.2011-09-08.1080i.HDTV.MPEG-2-CtrlHD-xds-solo-content-advisory.ts >> >> Regression/Correct/With XDS/WLS.mpg >> Regression/Minor >> issues/163ce77200976977847a5d66a537871b.20110901205100.mpg >> >> Ruslan's victoria_justice branch (compared to 0.69, verified to >> be worse than 0.69): >> >> Regression/Correct/No XDS/CBLT.mpg Regression/Correct/With >> XDS/images.mpg Regression/Minor >> issues/163ce77200976977847a5d66a537871b.20110901205100.mpg >> >> To be 100% sure, I cloned the latest github to my own repository, >> applied Ruslan's patch, built it and ran the tests again. The >> results were the same, so I think Ruslan did a very good job on >> the patch :) >> >> I'm still working on threading the test suite, it seems to be >> faster than no threading, but I'm not sure if it's (long term) >> good for your HDD though :p >> >> Once I finished it I'll leave the user the choice between >> threading and non-threading. >> >> Sincerely, Willem >> >> >> >> ------------------------------------------------------------------------------ >> >> Time is money. Stop wasting it! Get your web API in 5 minutes. >> www.restlet.com/download http://p.sf.net/sfu/restlet >> _______________________________________________ ccextractor-users >> mailing list cce...@li... >> https://lists.sourceforge.net/lists/listinfo/ccextractor-users >> > -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.10 (MingW32) Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQEcBAEBAgAGBQJTjD+tAAoJEER4GtAYK/sNDl0H/jn/dcOCGJOBVT36h8/rokDM lKgpNyDxzDor17ANuimSJvOBZlQHbMFEqlTpBdTPNZ19nAwA4Ihh3hAOnzlD2dwd KiYIktPmg2YMSfVDmm9xJt3EQ/k1Iem5gm9r1WpwHUXkFjtPM/YZdmNxEs8W0Bag vpC1ZoijygAixj8YLQUcalvOjs+tC6H1FKdIpkwGHsXyxMIk+9jfxQ8lbn9Kk5/e w1Pa6G/atxd5mfAjhwrusBqk7Q43L4TMy8M4DpcsV9h7BcWEGrxpIZeH5Kcc3CoI xOe+F0pIayUTrhzAl8BZ5Mm8rbdvvPyLb53cJO/HlyIOMGavq0eWCuMUDIC4Kic= =4euw -----END PGP SIGNATURE----- |