Re: [ccextractor-users] [GSoC] Regression error list

[Carlos F. <cf...@gm...>]

On Thu, May 22, 2014 at 1:40 PM, Ruslan Kuchumov <kuc...@gm...> wrote:
>
> What is the purpose of clearing the caption buffer after new PAT in the

If PAT has changed then the stream you are reading now has different
stuff (programs were added or removed). Probably I was too aggressive.

> first place?  I think we should clear it only when caption type changes
> (from 608 to 708 or something).

No, that's legal, and in fact it's normal to have both 608 and 708
captions in the same program.

As for ccx_options.ts_cappid and cap types,
> I think they are valid until new PMT arrives. I tried and it worked. I'll
> create pull request after testing.

We'd need to do something more clever here. If the PAT changes but the
PMT we were using is still present then don't clear the buffer or
reset the PID variables. If our selected PMT disappears then we need
to reset everything - the program we were "watching" is gone.

Also, when the PMT changes if our selected stream disappears then we
also have to reset everything. I guess it's possible that a PMT
changes, for example because a new program starts and it has an extra
audio track or something like that.