cc-mode-help

[PATCH] Java assert keyword

[Arsen A. <ar...@aa...>]

Hi Alan!

I've, regrettably, been writing Java lately and I noticed CC-mode
doesn't recognize asserts.  So I added it, hopefully correctly.

I haven't used Mercurial before, so forgive me if I've done something
wrong, but I've pushed my patch on Sourcehut, visible here:
https://hg.sr.ht/~arsen/cc-mode/rev/15bcae1c6ae0f68c75791f9239879af71c4f237c

... and fetchable via: https://hg.sr.ht/~arsen/cc-mode

PS: It is somewhat unclear where to send patches to CC-mode, so I've
sent them to you and CC'd cc-mode-help.  Hopefully that is right.

Have a lovely day!
-- 
Arsen Arsenović

Re: [PATCH] Java assert keyword

[Arsen A. <ar...@aa...>]

Arsen Arsenović <ar...@aa...> writes:

> Hi Alan!
>
> I've, regrettably, been writing Java lately and I noticed CC-mode
> doesn't recognize asserts.  So I added it, hopefully correctly.

I just noticed the same about var and, similarly:
https://hg.sr.ht/~arsen/cc-mode/rev/ce95a9f9caa050602c107f61dbe933e31338674e

BTW, C has recently gained auto type deduction similar to C++
-- 
Arsen Arsenović

Re: [PATCH] Java assert keyword

[Arsen A. <ar...@aa...>]

Hi Alan,

Arsen Arsenović via CC-Mode-help <cc-...@li...> writes:

> Arsen Arsenović <ar...@aa...> writes:
>
>> Hi Alan!
>>
>> I've, regrettably, been writing Java lately and I noticed CC-mode
>> doesn't recognize asserts.  So I added it, hopefully correctly.
>
> I just noticed the same about var and, similarly:
> https://hg.sr.ht/~arsen/cc-mode/rev/ce95a9f9caa050602c107f61dbe933e31338674e
>
> BTW, C has recently gained auto type deduction similar to C++

A gentle ping on these two patches, if I may.

Thanks in advance!
-- 
Arsen Arsenović

Re: [PATCH] Java assert keyword

[Alan M. <ac...@mu...>]

Hello, Arsen.

On Sat, Oct 26, 2024 at 16:17:24 +0200, Arsen Arsenović wrote:
> Hi Alan,

> Arsen Arsenović via CC-Mode-help <cc-...@li...> writes:

> > Arsen Arsenović <ar...@aa...> writes:

> >> Hi Alan!

> >> I've, regrettably, been writing Java lately and I noticed CC-mode
> >> doesn't recognize asserts.  So I added it, hopefully correctly.

> > I just noticed the same about var and, similarly:
> > https://hg.sr.ht/~arsen/cc-mode/rev/ce95a9f9caa050602c107f61dbe933e31338674e

> > BTW, C has recently gained auto type deduction similar to C++

> A gentle ping on these two patches, if I may.

Big apologies.  When I got your posts, I was tangled up with lots of
small bugs, one after the other.  I was going to solve these first before
answering your posts, then completely forgot about them.

I'll give you a proper answer later on today/tomorrow.  (We get an extra
hour's sleep tonight in Germany.  Maybe you do too.)

> Thanks in advance!
> -- 
> Arsen Arsenović

-- 
Alan Mackenzie (Nuremberg, Germany).

Re: [PATCH] Java assert keyword

[Arsen A. <ar...@aa...>]

Alan Mackenzie <ac...@mu...> writes:

> Big apologies.  When I got your posts, I was tangled up with lots of
> small bugs, one after the other.  I was going to solve these first before
> answering your posts, then completely forgot about them.

No worries - such things happen.

> I'll give you a proper answer later on today/tomorrow.  (We get an extra
> hour's sleep tonight in Germany.  Maybe you do too.)

Indeed we did, though I'd not have noticed had you not mentioned it!
-- 
Arsen Arsenović

Re: [PATCH] Java assert keyword

[Arsen A. <ar...@aa...>]

Hi Alan,

Arsen Arsenović <ar...@aa...> writes:

> Arsen Arsenović via CC-Mode-help <cc-...@li...> writes:
>
>> Arsen Arsenović <ar...@aa...> writes:
>>
>>> Hi Alan!
>>>
>>> I've, regrettably, been writing Java lately and I noticed CC-mode
>>> doesn't recognize asserts.  So I added it, hopefully correctly.
>>
>> I just noticed the same about var and, similarly:
>> https://hg.sr.ht/~arsen/cc-mode/rev/ce95a9f9caa050602c107f61dbe933e31338674e

A ping again - the copyright assignment went through.
-- 
Arsen Arsenović

Re: [PATCH] Java assert keyword

[Alan M. <ac...@mu...>]

Hello, Arsen.

On Sun, Dec 22, 2024 at 15:29:47 +0100, Arsen Arsenović wrote:
> Hi Alan,

> Arsen Arsenović <ar...@aa...> writes:

> > Arsen Arsenović via CC-Mode-help <cc-...@li...> writes:

> >> Arsen Arsenović <ar...@aa...> writes:

> >>> Hi Alan!

> >>> I've, regrettably, been writing Java lately and I noticed CC-mode
> >>> doesn't recognize asserts.  So I added it, hopefully correctly.

> >> I just noticed the same about var and, similarly:
> >> https://hg.sr.ht/~arsen/cc-mode/rev/ce95a9f9caa050602c107f61dbe933e31338674e

> A ping again - the copyright assignment went through.

Great news, thanks!

I've committed your patch (trivially altered to keep things in
alphabetical order), and committed it under your name in stand alone CC
Mode, XEmacs, and the Emacs master branch.

Have a great Christmas!

> -- 
> Arsen Arsenović

-- 
Alan Mackenzie (Nuremberg, Germany).

Re: [PATCH] Java assert keyword

[Arsen A. <ar...@aa...>]

Alan Mackenzie <ac...@mu...> writes:

> Great news, thanks!
>
> I've committed your patch (trivially altered to keep things in
> alphabetical order), and committed it under your name in stand alone CC
> Mode, XEmacs, and the Emacs master branch.

Thanks!  Just rebuilt Emacs, so I got it now.  The keyword is nice and
fontified in my files :)

> Have a great Christmas!

Likewise!
-- 
Arsen Arsenović

Re: [PATCH] Java assert keyword

[Arsen A. <ar...@aa...>]

Hi Alan,

Arsen Arsenović via CC-Mode-help <cc-...@li...> writes:

> Arsen Arsenović <ar...@aa...> writes:
>
>> Hi Alan!
>>
>> I've, regrettably, been writing Java lately and I noticed CC-mode
>> doesn't recognize asserts.  So I added it, hopefully correctly.
>
> I just noticed the same about var and, similarly:
> https://hg.sr.ht/~arsen/cc-mode/rev/ce95a9f9caa050602c107f61dbe933e31338674e
>
> BTW, C has recently gained auto type deduction similar to C++

Seems that we forgot about this one!  Whoops.

Could I ask for this one being applied too?

Thanks in advance, and sorry for bothering.

Have a lovely day!
-- 
Arsen Arsenović

Re: [PATCH] Java assert keyword

[Alan M. <ac...@mu...>]

Hello, Arsen.

On Sun, Dec 22, 2024 at 23:55:54 +0100, Arsen Arsenović wrote:
> Hi Alan,

> Arsen Arsenović via CC-Mode-help <cc-...@li...> writes:

> > Arsen Arsenović <ar...@aa...> writes:

> >> Hi Alan!

> >> I've, regrettably, been writing Java lately and I noticed CC-mode
> >> doesn't recognize asserts.  So I added it, hopefully correctly.

> > I just noticed the same about var and, similarly:
> > https://hg.sr.ht/~arsen/cc-mode/rev/ce95a9f9caa050602c107f61dbe933e31338674e

> > BTW, C has recently gained auto type deduction similar to C++

Yes.  What is the world coming to?  ;-)

> Seems that we forgot about this one!  Whoops.

> Could I ask for this one being applied too?

Certainly!  There are actually a few new things in C23 I need to attend
to.  There's numbers like 1'000'000, for example.  That's already been
implemented for C++ Mode, so shouldn't be much trouble, but I need to
get down to this and do it systematically.  So give me just a little
time here, please.

> Thanks in advance, and sorry for bothering.

No bother at all!

> Have a lovely day!

And yourself, too!

> -- 
> Arsen Arsenović

-- 
Alan Mackenzie (Nuremberg, Germany).

Re: [PATCH] Java assert keyword

[Arsen A. <ar...@aa...>]

Hi Alan,

Alan Mackenzie <ac...@mu...> writes:

>> > I just noticed the same about var and, similarly:
>> > https://hg.sr.ht/~arsen/cc-mode/rev/ce95a9f9caa050602c107f61dbe933e31338674e
>
>> > BTW, C has recently gained auto type deduction similar to C++
>
> Yes.  What is the world coming to?  ;-)
>
>> Seems that we forgot about this one!  Whoops.
>
>> Could I ask for this one being applied too?
>
> Certainly!  There are actually a few new things in C23 I need to attend
> to.

I was referring to the patch, sorry for not being clear:

  https://hg.sr.ht/~arsen/cc-mode/rev/ce95a9f9caa050602c107f61dbe933e31338674e

... it adds the relatively new 'var' keyword to the Java support.

> There's numbers like 1'000'000, for example.  That's already been
> implemented for C++ Mode, so shouldn't be much trouble, but I need to
> get down to this and do it systematically.  So give me just a little
> time here, please.

No worries!  I didn't mean to hurry you along, sorry!
-- 
Arsen Arsenović

Re: C23 support in CC Mode.

[Alan M. <ac...@mu...>]

Hello, Arsen.

As half-promised, I've committed a large CC Mode patch which is intended
to cover C23.  It is now in the Emacs master branch at savannah.

On Mon, Dec 23, 2024 at 11:19:37 +0100, Arsen Arsenović wrote:
> Hi Alan,

> Alan Mackenzie <ac...@mu...> writes:

[ .... ]

> >> > BTW, C has recently gained auto type deduction similar to C++

> > Yes.  What is the world coming to?  ;-)

> >> Seems that we forgot about this one!  Whoops.

> >> Could I ask for this one being applied too?

> > Certainly!  There are actually a few new things in C23 I need to attend
> > to.

[ .... ]

> > There's numbers like 1'000'000, for example.  That's already been
> > implemented for C++ Mode, so shouldn't be much trouble, but I need to
> > get down to this and do it systematically.  So give me just a little
> > time here, please.

> No worries!  I didn't mean to hurry you along, sorry!

If you could find time to download the latest master and give the C23
features a run through, that would be great.

Thanks!

> -- 
> Arsen Arsenović

-- 
Alan Mackenzie (Nuremberg, Germany).

Re: [PATCH] Java assert keyword

[Arsen A. <ar...@aa...>]

Hi Alan,

Happy new year!

... and sorry to bother you so early in 2025!

Arsen Arsenović <cc-...@li...> writes:

> I was referring to the patch, sorry for not being clear:
>
>   https://hg.sr.ht/~arsen/cc-mode/rev/ce95a9f9caa050602c107f61dbe933e31338674e
>
> ... it adds the relatively new 'var' keyword to the Java support.

Gentle ping on this:
https://hg.sr.ht/~arsen/cc-mode/rev/ce95a9f9caa050602c107f61dbe933e31338674e

It should be another easy patch to merge.

Thanks in advance.
-- 
Arsen Arsenović

Re: [PATCH] Java assert keyword

[Alan M. <ac...@mu...>]

Hello, Arsen.

Happy new year to you, too!

On Thu, Jan 02, 2025 at 21:09:26 +0100, Arsen Arsenović wrote:
> Hi Alan,

> Happy new year!

> ... and sorry to bother you so early in 2025!

> Arsen Arsenović <cc-...@li...> writes:

> > I was referring to the patch, sorry for not being clear:

> >   https://hg.sr.ht/~arsen/cc-mode/rev/ce95a9f9caa050602c107f61dbe933e31338674e

> > ... it adds the relatively new 'var' keyword to the Java support.

> Gentle ping on this:
> https://hg.sr.ht/~arsen/cc-mode/rev/ce95a9f9caa050602c107f61dbe933e31338674e

> It should be another easy patch to merge.

I'll get it seen to, soon.  I'll try to get the commit message correct
this time, too.  ;-)

> Thanks in advance.
> -- 
> Arsen Arsenović

-- 
Alan Mackenzie (Nuremberg, Germany).

Java var and final keywords [was: Re: [PATCH] Java assert keyword]

[Alan M. <ac...@mu...>]

Hello, Arsen.

On Thu, Jan 02, 2025 at 21:09:26 +0100, Arsen Arsenović wrote:
> Hi Alan,

> Happy new year!

And a HNY to yourself, too!

> ... and sorry to bother you so early in 2025!

No bother at all!

> Arsen Arsenović <cc-...@li...> writes:

> > I was referring to the patch, sorry for not being clear:

> >   https://hg.sr.ht/~arsen/cc-mode/rev/ce95a9f9caa050602c107f61dbe933e31338674e

> > ... it adds the relatively new 'var' keyword to the Java support.

> Gentle ping on this:
> https://hg.sr.ht/~arsen/cc-mode/rev/ce95a9f9caa050602c107f61dbe933e31338674e

> It should be another easy patch to merge.

Indeed it was, thanks!  I've committed it to all the usual places, and I
think I've spelt your name correctly this time.

> Thanks in advance.

Thank you for the patch.

> -- 
> Arsen Arsenović

-- 
Alan Mackenzie (Nuremberg, Germany).

Re: Java var and final keywords [was: Re: [PATCH] Java assert keyword]

[Arsen A. <ar...@aa...>]

Hi Alan,

Alan Mackenzie <ac...@mu...> writes:

> Hello, Arsen.
>
> On Thu, Jan 02, 2025 at 21:09:26 +0100, Arsen Arsenović wrote:
>> Hi Alan,
>
>> Happy new year!
>
> And a HNY to yourself, too!
>
>> ... and sorry to bother you so early in 2025!
>
> No bother at all!
>
>> Arsen Arsenović <cc-...@li...> writes:
>
>> > I was referring to the patch, sorry for not being clear:
>
>> >   https://hg.sr.ht/~arsen/cc-mode/rev/ce95a9f9caa050602c107f61dbe933e31338674e
>
>> > ... it adds the relatively new 'var' keyword to the Java support.
>
>> Gentle ping on this:
>> https://hg.sr.ht/~arsen/cc-mode/rev/ce95a9f9caa050602c107f61dbe933e31338674e
>
>> It should be another easy patch to merge.
>
> Indeed it was, thanks!  I've committed it to all the usual places, and I
> think I've spelt your name correctly this time.

Thanks!  I just rebuilt Emacs and got it.

And yes, the name is fine this time :-)

Have a lovely day!
-- 
Arsen Arsenović

Re: [PATCH] Java assert keyword

[Alan M. <ac...@mu...>]

Hello, Arsen.

At last!  (Apologies again.)

On Sat, Oct 05, 2024 at 15:42:53 +0200, Arsen Arsenović wrote:
> Hi Alan!

> I've, regrettably, been writing Java lately and I noticed CC-mode
> doesn't recognize asserts.  So I added it, hopefully correctly.

CC Mode has fallen quite some way behind on Java.  I've mainly been
trying to keep up to date with C++ (C is less of a problem, and the
other languages are mostly fairly static).  I underestimated the amount
of effort CC Mode would need when I took it on (around 20 years ago).

> I haven't used Mercurial before, so forgive me if I've done something
> wrong, but I've pushed my patch on Sourcehut, visible here:
> https://hg.sr.ht/~arsen/cc-mode/rev/15bcae1c6ae0f68c75791f9239879af71c4f237c

Mercurial is not such a big deal.  It's (much) easier to learn to use
than git.  I doubt you've done anything wrong with the patch.  :-)

> ... and fetchable via: https://hg.sr.ht/~arsen/cc-mode

> PS: It is somewhat unclear where to send patches to CC-mode, so I've
> sent them to you and CC'd cc-mode-help.  Hopefully that is right.

The place to send patches for CC Mode is bug...@gn....

But first things first - have you signed copyright assignment papers for
Emacs?  That bit of bureaucracy is (unfortunately) a prerequisite for
contributing to Emacs (or any other part of the GNU project).  If not,
could I ask you to do that, please?  I've forgotten the exact procedure,
but I can ask Eli Zaretskii (chief Emacs maintainer), who knows it well.

If/when so, I'll have a look at your patch, and (almost certainly)
incorporate it.

Thanks for taking the trouble to get into CC Mode.  The code is not
always as simple and straightforward as I would like it to be, and I've
made quite a few mistakes over the years.

Would you consider doubling the size of the CC Mode team by joining it,
mainly to concentrate on Java?  Before saying yes, please bear in mind
that CC Mode is being superseded by the Tree Sitter modes (like
c-ts-mode and c++-ts-mode) and its future as a prime set of Emacs mode
is somewhat in doubt.  But I suspect there will always be a hard core of
CC Mode users who just prefer it.

> Have a lovely day!
> -- 
> Arsen Arsenović

-- 
Alan Mackenzie (Nuremberg, Germany).

Re: [PATCH] Java assert keyword

[Arsen A. <ar...@aa...>]

Hi Alan and Eli,

Eli, I've CC-ed you regarding paperwork for contributing to Emacs
(namely CC mode, but I'd prefer to sign off on as much as possible so
that I don't have to print even more agreements ;-) ).

Relevant patches are below.

Alan Mackenzie <ac...@mu...> writes:

> Hello, Arsen.
>
> At last!  (Apologies again.)
>
> On Sat, Oct 05, 2024 at 15:42:53 +0200, Arsen Arsenović wrote:
>> Hi Alan!
>
>> I've, regrettably, been writing Java lately and I noticed CC-mode
>> doesn't recognize asserts.  So I added it, hopefully correctly.
>
> CC Mode has fallen quite some way behind on Java.  I've mainly been
> trying to keep up to date with C++ (C is less of a problem, and the
> other languages are mostly fairly static).  I underestimated the amount
> of effort CC Mode would need when I took it on (around 20 years ago).

Heh, underestimation is frequent in software.  I've done that many
times.

>> I haven't used Mercurial before, so forgive me if I've done something
>> wrong, but I've pushed my patch on Sourcehut, visible here:
>> https://hg.sr.ht/~arsen/cc-mode/rev/15bcae1c6ae0f68c75791f9239879af71c4f237c
>
> Mercurial is not such a big deal.  It's (much) easier to learn to use
> than git.  I doubt you've done anything wrong with the patch.  :-)

Sure, but I know git inside and out, and I don't even know Mercurial
out!  ;)

>> ... and fetchable via: https://hg.sr.ht/~arsen/cc-mode
>
>> PS: It is somewhat unclear where to send patches to CC-mode, so I've
>> sent them to you and CC'd cc-mode-help.  Hopefully that is right.
>
> The place to send patches for CC Mode is bug...@gn....

Ah, alright - I was worried that redirects to Debbugs automatically, so
I figured here is better.

> But first things first - have you signed copyright assignment papers
> for Emacs?

I haven't had the need.  I figured these patches were below the
significance threshold so I just sent them without bothering anyone.

> That bit of bureaucracy is (unfortunately) a prerequisite for
> contributing to Emacs (or any other part of the GNU project).

Not any other - some of the toolchain projects happily accept patches
without it for the most part.  I've still assigned copyright for the
stuff I work on, but it's not a requirement.

> If not, could I ask you to do that, please?  I've forgotten the exact
> procedure, but I can ask Eli Zaretskii (chief Emacs maintainer), who
> knows it well.

I have not.

Eli, to save you some time digging, here are the patches in question:
https://hg.sr.ht/~arsen/cc-mode/rev/15bcae1c6ae0f68c75791f9239879af71c4f237c
https://hg.sr.ht/~arsen/cc-mode/rev/ce95a9f9caa050602c107f61dbe933e31338674e

Do these need copyright assignment?  How should I go about it?  TIA

> If/when so, I'll have a look at your patch, and (almost certainly)
> incorporate it.

Thanks :-)

> Thanks for taking the trouble to get into CC Mode.  The code is not
> always as simple and straightforward as I would like it to be, and I've
> made quite a few mistakes over the years.

As have we all!

> Would you consider doubling the size of the CC Mode team by joining it,
> mainly to concentrate on Java?

Note that I mainly write C++ by trade - software I work on are written
in it, and I prefer writing it.

My contact with Java nowadays is mostly academic (as in, related to
university work, mainly because it's a lingua franca among students),
but I've been writing it for a long time and know too much about it..

So, I'm afraid I can't guarantee that I'll be up-to-date with new
developments in Java.

That said - I'd love to help with CC-mode, however much I can in the
small amount of time I have free, with the little Elisp knowledge I
have.

I cannot promise I'll be of too much help, though; I am quite busy, and
not an expert in Emacs-y code by any means.

If I am to continue fixing Java-related hiccups, though, I'd need to
figure out records next, I think.  I've also noticed lack of support for
multiline strings.  Is there documentation on how the CC-mode parser
works?  If not, I'll try digging a little next weekend.

> Before saying yes, please bear in mind that CC Mode is being
> superseded by the Tree Sitter modes (like c-ts-mode and c++-ts-mode)
> and its future as a prime set of Emacs mode is somewhat in doubt.

This surprises me.

To be clear, I'm not surprised by tree-sitter superseding a _parser_,
but a whole mode is not a just a parser, nor just a highlighting engine.

I primarily don't use the -ts- mode (as someone who is a fan of
Tree-sitter) because their implementations of other parts of what
constitutes a mode are not as good (the indentation engines are worse,
handling of comments is worse, probably some other bits).

I expected that, eventually, the "old-style" modes would start using
tree-sitter information to do indentation.

Have a lovely day!
-- 
Arsen Arsenović

Re: [PATCH] Java assert keyword

[Eli Z. <el...@gn...>]

> From: Arsen Arsenović <ar...@aa...>
> Cc: CC-Mode-help <cc-...@li...>
> Date: Sun, 27 Oct 2024 18:41:55 +0100
> 
> > If not, could I ask you to do that, please?  I've forgotten the exact
> > procedure, but I can ask Eli Zaretskii (chief Emacs maintainer), who
> > knows it well.
> 
> I have not.
> 
> Eli, to save you some time digging, here are the patches in question:
> https://hg.sr.ht/~arsen/cc-mode/rev/15bcae1c6ae0f68c75791f9239879af71c4f237c
> https://hg.sr.ht/~arsen/cc-mode/rev/ce95a9f9caa050602c107f61dbe933e31338674e
> 
> Do these need copyright assignment?  How should I go about it?  TIA

They are borderline.  I'd prefer that you sign the copyright
assignment, definitely if you intend to contribute to Emacs in the
future.

> > Before saying yes, please bear in mind that CC Mode is being
> > superseded by the Tree Sitter modes (like c-ts-mode and c++-ts-mode)
> > and its future as a prime set of Emacs mode is somewhat in doubt.
> 
> This surprises me.
> 
> To be clear, I'm not surprised by tree-sitter superseding a _parser_,
> but a whole mode is not a just a parser, nor just a highlighting engine.
> 
> I primarily don't use the -ts- mode (as someone who is a fan of
> Tree-sitter) because their implementations of other parts of what
> constitutes a mode are not as good (the indentation engines are worse,
> handling of comments is worse, probably some other bits).
> 
> I expected that, eventually, the "old-style" modes would start using
> tree-sitter information to do indentation.

>From my POV, the TS mode do not supersede the "traditional" modes for
the same languages, they are alternative implementations.  I envision
both to coexist in Emacs for many years to come, and in that time each
mode learning from its sibling and improving.  The main advantage of a
TS based mode is that we (the Emacs developers) don't need to have
experts for the language parsing and don't need to play catch-up will
all the latest developments of the language.  But it also has
disadvantages, and generally suffers from being still very new and
lacking some important features.

Re: [PATCH] Java assert keyword

[Arsen A. <ar...@aa...>]

Eli Zaretskii <el...@gn...> writes:

>> From: Arsen Arsenović <ar...@aa...>
>> Cc: CC-Mode-help <cc-...@li...>
>> Date: Sun, 27 Oct 2024 18:41:55 +0100
>> 
>> > If not, could I ask you to do that, please?  I've forgotten the exact
>> > procedure, but I can ask Eli Zaretskii (chief Emacs maintainer), who
>> > knows it well.
>> 
>> I have not.
>> 
>> Eli, to save you some time digging, here are the patches in question:
>> https://hg.sr.ht/~arsen/cc-mode/rev/15bcae1c6ae0f68c75791f9239879af71c4f237c
>> https://hg.sr.ht/~arsen/cc-mode/rev/ce95a9f9caa050602c107f61dbe933e31338674e
>> 
>> Do these need copyright assignment?  How should I go about it?  TIA
>
> They are borderline.  I'd prefer that you sign the copyright
> assignment, definitely if you intend to contribute to Emacs in the
> future.

Works for me.  Do send the form.

Thanks.
-- 
Arsen Arsenović

Re: [PATCH] Java assert keyword

[Eli Z. <el...@gn...>]

> From: Arsen Arsenović <ar...@aa...>
> Cc: ac...@mu...,  cc-...@li...
> Date: Sun, 27 Oct 2024 20:43:18 +0100
> 
> >> Eli, to save you some time digging, here are the patches in question:
> >> https://hg.sr.ht/~arsen/cc-mode/rev/15bcae1c6ae0f68c75791f9239879af71c4f237c
> >> https://hg.sr.ht/~arsen/cc-mode/rev/ce95a9f9caa050602c107f61dbe933e31338674e
> >> 
> >> Do these need copyright assignment?  How should I go about it?  TIA
> >
> > They are borderline.  I'd prefer that you sign the copyright
> > assignment, definitely if you intend to contribute to Emacs in the
> > future.
> 
> Works for me.  Do send the form.

Thanks, form sent off-list.

Re: [PATCH] Java assert keyword

[Arsen A. <ar...@aa...>]

Eli Zaretskii <el...@gn...> writes:

> Thanks, form sent off-list.

Seems to be finally done, at long last.  \o/
-- 
Arsen Arsenović

Re: [PATCH] Java assert keyword

[Eli Z. <el...@gn...>]

> From: Arsen Arsenović <ar...@aa...>
> Cc: ac...@mu...,  cc-...@li...
> Date: Sat, 14 Dec 2024 13:23:41 +0100
> 
> Eli Zaretskii <el...@gn...> writes:
> 
> > Thanks, form sent off-list.
> 
> Seems to be finally done, at long last.  \o/

Yes, thanks.