When central water heating is specified, the count is incorrectly using # of WH x dwelling units. Attached is how I believe it can be corrected using data reported in the CF1R XML (.docx). While I was in there, I made some other clean-up recommendations which should be applied to any applicable CF1R templates. Also included are a marked up CF1R, RIBD19, and XML files.
There are several items that can be handled in the rendering code, however , there are a number of items that require schema and ruleset mods. I have identified these below and in the attachment to this ticket.
I'm not sure if this list indicates an approved list of changes or they are for consideration. In either case here's what it would take and some things to consider:
A17 limit to 2 decimal places: Assigning decimal type in teh schema always default to 2 decimal places, so I must have been given a spec to modify the data type to allow 3 decimal places. Just want to make sure all parties agree it should be changed back to 2 decimal places. This is used in the CF3R-CXR20 also.
M08a and 4. M09a CECDefaultPerformance split display terms: This property FenestrationCertificationMethod is used in all prescriptive CF1R’s also so change needs to leave current values and display terms as they are. Given that, I can add 2 new enums to FenestrationCertificationMethod to use instead of the existing single value. For item 3 they would have display terms Table110-6A and Table110-6B and for 4. they would have display terms NA6-1 and NA6-2. This would require a change to the rules to output the new enum values and probably addition rule logic to select the correct enum.
These are changes requested by CEC for 2.0. The original issue is from Dee Anne and being that I was assigned reviewed and parsed the issues between Diane and Rob (and myself) based on my assessment.
Last edit: Robert Scott 2020-01-14
Rev1629: A17 limit to 2 decimal places in CF1RPRF XML output
These all look correct in the report and can be verified.
Diff:
When central, the water heating reporting is still off. F07 should be sum of S03 if central (systems = 1 or 2 for attached files). Key to central is when S04 has n/a or S04a has a value. The wh count from S07 is not updating in my XML. T04 should be S07 + S07s for central. The reported value for T04 should not be multiplied by dwelling units when central. I've included a word document, 2 marked up CF1Rs, and input files. Take your time - this took me almost a whole day. This is a new file converted from a user's file.
Working on fixes for F07 & T04, but need further explanation of change to S07.
Last Word doc indicates that S07 should be 3 (not 4) for DHW Sys 1 and that it should be 1 (not 4) for DHW System 2 - but the Count of heaters in each of these systems is 4, not 1 & 3.
Need an explanation of why DHW Sys 1 should report S07=3 and DHW System 2 S07=1.
CF1R XML fixes for central DHW system and heater counts (F07_ResidentialWaterHeatingSystemCount & T04_WaterHeaterCount) checked into SVN @ r1818. Fix essentially prevents the counts indicated from being multiplied by the number of dwellings served (for central systems).
Marked ticket as Fixed since uncertain of what changes might be needed to S07 - the last Word doc indicates that S07 should be 3 (not 4) for DHW Sys 1 and that it should be 1 (not 4) for DHW System 2 - but the Count of heaters in each of these systems is 4, not 1 & 3.
You accomplished what I was seeking, so I'm verifying it. I tried to create two options for how the central systems might be modeled in hopes of catching every mess that might be created (1 system with 4 tanks, and another version had 2 systems - one with 1 tank and one with 3). Someone will likely break it, but it is doing the right thing.