Wall Exceptions missing from EAA and AA; 2. Overhangs column 17 messed up on EAA; R-2.1 shows up in Supply duct R-value next to R-6 Return (I couldn't replicate this); 4. Fenestration SHGC Source (new construction) needs to be 1 space bigger; 5. Notes (should be just before signatures) missing from all CF1E templates. (descriptions, example files all attached).
I have made comments in the Word doc to address. There are several easily fixed report formatting issues and also some rules fixes required that I have noted. Also, there is a request for clarification for one item.
Even I was not sure what I meant. I am saying "although I like column 11, the same information appears in the HERS verified existing conditions section near the end. I don’t want to step on anyone’s toes, so keep it or replace it with the Exception."
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
THIS IS THE FIRST ISSUE
The Slab table is showing up because the xml includes an empty TableSlabFloor element so the template is responding and shows the table but no data.
<Section_P><TableSlabFloor/></Section_P>
Normally, if a section does not apply then the xml simply does not include data for that section. However, when looking at the 1StoryExample3Crawl example to check the behavior with crawlspace floors, this problem does not occur due to the existence of a garage slab reported in the Slab Table. Removing the garage floor results in the same problem occuring.
**
This should probably be addressed in the rules, however, the issue has now been resolved in the template (and posted) by checking for a count of data rows in TableSlabFloor greater than 0**.
THIS IS THE SECOND ISSUE
There needs to be clarification for how to handle the condition for Verified Duct Design. This is the xml provided that shows this problem:
We should understand the rules when Verified Duct Design is selected. The R values shown could be displayed but it looks like those may be calculated values based on other data that is not shown. @scriswellwsf - Can you provide any clarification on this?
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Added rules to output J09a_WallException for AA and EAA projects.
Added rules to output Aa04Supply, Aa04bSupply, Aa05Return, and Aa05bReturn NotApplicableMessage elements when DuctRValue elements are UNDEFINED. We still need to understand the desired rules when Verified Duct Design is selected.
Modified rule to avoid empty Slab Floor table.
Still working on output of new XSD element for Project:Notes
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Since the table below Section Aa has the correct duct R-value (and effective R-value is probably meaningless), I would like Aa04 and Aa05 wording changed to "See duct design". Also change wording for <bb07_ductsdeeplyburiedcompliancecredittaken>true</bb07_ductsdeeplyburiedcompliancecredittaken>
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Dee Anne, I have questions on your last comment:
It wasn't clear to me what '... Aa04 and Aa05 wording changed to "See duct design" ...' refers to as Aa04 and Aa05 are mostly R-values or numeric values except for one, RvalueVerifiedDuctSystem which has the display term of "Verified Duct System Design". Is this the text that you want changed to "See duct design"? If that is the case, this property and this particular value are used in the CF2R-Mch01's as well and so the change in text will affect them and I want to check that "See duct design" works for these reports as well. If this change is unique to the CF1R-PRF, I can change the text locally for the CF1R-PRF but this means maintaining different display terms for the same value. And If this is not the text you were referring to, please set me straight.
Similar question on changing wording for bb07_ductsdeeplyburiedcompliancecredittaken true value to "Installation in accordance with RA3.1.4.1.6" I assume there is no problem with shortening the display term for the true value, but again this will also affect other reports, the CF2R/3R-MCH-29 which includes the DuctsDeeplyBuriedComplianceCreditTaken property. So if the text is unique to the CF1R-PRF, I can change the text locally for the CF1R-PRF.
Last edit: Diane Pepetone 2020-01-26
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
That was what I wanted. But my issue was just with how much space it uses, so it is not worth it for all of this after effect.
Same issue.
You have to realize the biggest complaint I heard was how long the CF1R got, so when I see something that is needlessly wordy, I'm going to want to hack at it. So Do what you want. I left the important parts.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
Per response from Mikey, I changed the text for Aa04 and Aa05 locally in teh CF1RPRF to display "See duct design" and modify the base definition of DuctsDeeplyBuriedComplianceCreditTaken to display "Installation in accordance with RA3.1.4.1.6". Schemas with the changes were posted last week, which finishes the changes I needed to make to the schemas.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
The last schema change for Aa04 and Aa05 redefined display terms locally in the CF1RPRF <xsd:appinfo source="displayterm">
<dtyp:displayterm value="RvalueVerifiedDuctSystem">See duct design</dtyp:displayterm></xsd:appinfo>
which will require a change in the XSLT, so assigning to Robert
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I am going to call this one a huge success. Thank you all (Robert, Rob, Diane) for your attention to detail. This was torture. The one little thing "New construction" Section M Table Glazing has the "e" in source on a separate row, but it will have to wait for some other ticket upon which to hitch-hike.
If you would like to refer to this comment somewhere else in this project, copy and paste the following link:
I have made comments in the Word doc to address. There are several easily fixed report formatting issues and also some rules fixes required that I have noted. Also, there is a request for clarification for one item.
Diff:
Even I was not sure what I meant. I am saying "although I like column 11, the same information appears in the HERS verified existing conditions section near the end. I don’t want to step on anyone’s toes, so keep it or replace it with the Exception."
2 more edits to the CF1R:
Slab Table shows up when there is no slab.
Buried ducts Supply and Return R-values are getting words instead of R-values
THIS IS THE FIRST ISSUE
The Slab table is showing up because the xml includes an empty TableSlabFloor element so the template is responding and shows the table but no data.
Normally, if a section does not apply then the xml simply does not include data for that section. However, when looking at the 1StoryExample3Crawl example to check the behavior with crawlspace floors, this problem does not occur due to the existence of a garage slab reported in the Slab Table. Removing the garage floor results in the same problem occuring.
**
This should probably be addressed in the rules, however, the issue has now been resolved in the template (and posted) by checking for a count of data rows in TableSlabFloor greater than 0**.
THIS IS THE SECOND ISSUE
There needs to be clarification for how to handle the condition for Verified Duct Design. This is the xml provided that shows this problem:
The text is derived from a lookup based on the values in Aa04 and Aa05.
The template is designed to read the values from Aa04 and Aa05. This is an xml from a run without VerifiedDuctDesign:
I will be checking in a rules mod to remove the empty Slab Floor table, when I check in other updates related to this ticket.
But, we do still need clarification for how to handle the condition for Verified Duct Design.
We should understand the rules when Verified Duct Design is selected. The R values shown could be displayed but it looks like those may be calculated values based on other data that is not shown. @scriswellwsf - Can you provide any clarification on this?
Rev1629 :
Rev1630: Added output of Project Notes to CF1RPRF XML
We still need guidance on understanding the desired rules when Verified Duct Design is selected.
Since the table below Section Aa has the correct duct R-value (and effective R-value is probably meaningless), I would like Aa04 and Aa05 wording changed to "See duct design". Also change wording for <bb07_ductsdeeplyburiedcompliancecredittaken>true</bb07_ductsdeeplyburiedcompliancecredittaken>
Changing ownership to Diane since this last request involves XSD display terms rather than rule mods.
Dee Anne, I have questions on your last comment:
It wasn't clear to me what '... Aa04 and Aa05 wording changed to "See duct design" ...' refers to as Aa04 and Aa05 are mostly R-values or numeric values except for one, RvalueVerifiedDuctSystem which has the display term of "Verified Duct System Design". Is this the text that you want changed to "See duct design"? If that is the case, this property and this particular value are used in the CF2R-Mch01's as well and so the change in text will affect them and I want to check that "See duct design" works for these reports as well. If this change is unique to the CF1R-PRF, I can change the text locally for the CF1R-PRF but this means maintaining different display terms for the same value. And If this is not the text you were referring to, please set me straight.
Similar question on changing wording for bb07_ductsdeeplyburiedcompliancecredittaken true value to "Installation in accordance with RA3.1.4.1.6" I assume there is no problem with shortening the display term for the true value, but again this will also affect other reports, the CF2R/3R-MCH-29 which includes the DuctsDeeplyBuriedComplianceCreditTaken property. So if the text is unique to the CF1R-PRF, I can change the text locally for the CF1R-PRF.
Last edit: Diane Pepetone 2020-01-26
You have to realize the biggest complaint I heard was how long the CF1R got, so when I see something that is needlessly wordy, I'm going to want to hack at it. So Do what you want. I left the important parts.
Per response from Mikey, I changed the text for Aa04 and Aa05 locally in teh CF1RPRF to display "See duct design" and modify the base definition of DuctsDeeplyBuriedComplianceCreditTaken to display "Installation in accordance with RA3.1.4.1.6". Schemas with the changes were posted last week, which finishes the changes I needed to make to the schemas.
The last schema change for Aa04 and Aa05 redefined display terms locally in the CF1RPRF <xsd:appinfo source="displayterm">
<dtyp:displayterm value="RvalueVerifiedDuctSystem">See duct design</dtyp:displayterm></xsd:appinfo>
which will require a change in the XSLT, so assigning to Robert
Modified tempate to read from both CF1RPRF and Base schema for displayterms for Distribution Systems "Duct Ins. R-value" data values.
I am going to call this one a huge success. Thank you all (Robert, Rob, Diane) for your attention to detail. This was torture. The one little thing "New construction" Section M Table Glazing has the "e" in source on a separate row, but it will have to wait for some other ticket upon which to hitch-hike.