Menu

#2 CSS4J strips HTML entities

1.0
not-a-bug
None
Bug
css4j-dom4j
2018-11-09
2018-10-08
No

Using CSS4J 0.41.3 (but the milestone field in SF has 0.32.1 as the latest version ;)).

See https://groups.google.com/forum/?utm_medium=email&utm_source=footer#!msg/css4j/HlnlB2c8G4I/tkOiNgDpAgAJ

In short, when using the following HTML entities are stripped:

SAXReader reader = new SAXReader(XHTMLDocumentFactory.getInstance());

This is not the case with:

SAXReader reader = new SAXReader();

Thanks
-Vincent

Discussion

  • Carlos Amengual

    Carlos Amengual - 2018-10-08
    • assigned_to: Carlos Amengual
    • Component: css4j-core --> css4j-dom4j
    • Milestone: 0.32.1 --> 1.0
     
  • Carlos Amengual

    Carlos Amengual - 2018-10-08

    The 'milestone' is intended to be the next big release for which the issue is being focused. Changed it to 1.0 although I'm probably going to remove the Milestone field completely.

     
    • Vincent Massol

      Vincent Massol - 2018-10-08

      Hmm... I don't understand why the user would need to specify and know in which version an issue would be fixed :) However what's important is to report in which version of CSS4J the problem occurred. That's not possible?

       
      • Carlos Amengual

        Carlos Amengual - 2018-10-09

        I don't understand why the user would need to specify and know in which version an issue would be fixed

        This was part of the initial template that created the ticket system and I did not change it. Doing that makes sense for the developer that owns the issue, but not for the reporter.

        Also, the reported version should be always the same: only the very latest milestone is being supported. Once 1.0.0 is out, there will be possibly more releases to support (1.0.0 and 1.1.0 for example), but meanwhile the affected version must be the latest.

         
    • Carlos Amengual

      Carlos Amengual - 2018-10-16

      Attempted to remove the 'Milestone' field but couldn't...

      Finally added a 'Latest Milestone' meta-milestone, hope that works out. With the frequent milestone release schedule that the project has had during the last year or so, adding every and each milestone release would not work out.

       
  • Carlos Amengual

    Carlos Amengual - 2018-10-09

    As mentioned in the css4j group, I found that it is a dom4j problem. Upstream isssue that you opened:

    https://github.com/dom4j/dom4j/issues/51

     
  • Carlos Amengual

    Carlos Amengual - 2018-10-16
    • status: open --> pending
     
  • Carlos Amengual

    Carlos Amengual - 2018-11-09

    As this is not a css4j issue [the bug description is wrong, as the problem happens in dom4j 2.1.1 regardless of using SAXReader reader = new SAXReader() with dom4j's default factory or css4j's factory] and upstream is looking at it, I'm closing this issue. Let's track this at upstream instead.

     
  • Carlos Amengual

    Carlos Amengual - 2018-11-09
    • status: pending --> not-a-bug
     

Log in to post a comment.