From: Capstone E. <cap...@gm...> - 2014-09-20 15:51:21
|
On Sat, Sep 20, 2014 at 8:39 PM, Yegor Derevenets < yeg...@gm...> wrote: > On Sat, Sep 20, 2014 at 09:34:50AM +0800, Nguyen Anh Quynh wrote: > > i dont really get this: all you need to include is capstone.h (which > > internally includes arm.h, x86.h and everything else), so how can you get > > name conflict here? > > Ah. I missed the fact that capstone.h includes arm.h. Then, except the > fact that the internal header arm.h is globally available as <arm.h>, I > have no complaints. :) > > but that arm.h is never supposed to be used by anything except capstone.h, so we have no problem with that "global" arm.h file. > > if you can fix all those "comparison of integers of different signs: > 'int' > > and 'unsigned long'" bugs and send in Pull-request, then great! > > Roger. But I will probably make Capstone compile under MSVC 2010 first. > > feel free to copy & use msinttypes from https://code.google.com/p/msinttypes/. look forward to your PR :-) at the same time, you might want to checkout msvc support already available in msvc/. this should handle the issue of inttypes.h automatically for VC 2010. see COMPILE_MSVC.TXT for more info. thanks. Q |