Re: [Capstone-users] Feature requests

[Nguyen A. Q. <aq...@gm...>]

On Sat, Sep 20, 2014 at 1:17 AM, Yegor Derevenets <
yeg...@gm...> wrote:

> On Sat, Sep 20, 2014 at 12:22:24AM +0800, Nguyen Anh Quynh wrote:
> > i think the current setup is standard method. projects using Capstone
> must
> > set the including paths properly with -I, which is trivial.
>
> Which directory you mean one should write after -I? Writing
> -Icapstone/include is somewhat ugly, because it makes headers with
> relatively widespread names like arm.h become available as <arm.h>. If
> every library would require doing so, there would be name clashes and
> surprises.
>


i dont really get this: all you need to include is capstone.h (which
internally includes arm.h, x86.h and everything else), so how can you get
name conflict here?




>
> > > 3. MSVC 2010 is famous for not providing <inttypes.h>. Is there a
> > > workaround planned to make Capstone compilable by MSVC 2010?
> > hmm, perhaps we should use msinttypes when MSVC version < vs2010?
> > something like:
> >
> > #if defined(_MSC_VER) && _MSC_VER < 1700
> > #include "msvc/inttypes.h"
> > #endif
>
> Makes sense. I would write a special header file that includes either
> one or the other inttypes.h, depending on _MSC_VER.
>
> > > 4. Any plans about fixing warnings produced by GCC/Clang with -Wall?
> > > There are tons of complaints about unused function arguments.
> > can you post all the warnings here?
>
> Sorry, I really meant -Wextra. A build log is attached.
>

if you can fix all those "comparison of integers of different signs: 'int'
and 'unsigned long'" bugs and send in Pull-request, then great!

on the "warning: unused parameter" issue: this is not critical, we can
focus on that later.

thanks.
Q