From: Nguyen A. Q. <aq...@gm...> - 2014-09-19 16:22:52
|
On Fri, Sep 19, 2014 at 6:14 PM, Yegor Derevenets < yeg...@gm...> wrote: > Hi, > > I am using Capstone (namely, its 'next' branch) inside a project using > CMake as a build system. Here is a list of improvements that would be > great to have. > > 1. Add some prefix to all the CMake configuration options, e.g.: > BUILD_STATIC -> CAPSTONE_BUILD_STATIC. Otherwise, Capstone pollutes the > CMake cache with names that do not show any relation to the library. > this is really trivial. do you mind fixing this and sending a pull-request on Github for this? > > 2. Header files currently located in 'include' should be moved to > something like 'include/capstone'. Otherwise, when one uses system-wide > Capstone installation, one has to write #include <capstone/capstone.h>, > and when one uses Capstone as a subproject, one has to write #include > <include/capstone.h> or <capstone.h> (depending on what one gave to > include_directories()). > > i think the current setup is standard method. projects using Capstone must set the including paths properly with -I, which is trivial. > 3. MSVC 2010 is famous for not providing <inttypes.h>. Is there a > workaround planned to make Capstone compilable by MSVC 2010? > > hmm, perhaps we should use msinttypes when MSVC version < vs2010? something like: #if defined(_MSC_VER) && _MSC_VER < 1700 #include "msvc/inttypes.h" #endif 4. Any plans about fixing warnings produced by GCC/Clang with -Wall? > There are tons of complaints about unused function arguments. > > can you post all the warnings here? btw, this issue is trivial to handle. would be great if you just go ahead fixing them and send in the pull-request, i will merge it. thanks. Q > > ------------------------------------------------------------------------------ > Slashdot TV. Video for Nerds. Stuff that Matters. > > http://pubads.g.doubleclick.net/gampad/clk?id=160591471&iu=/4140/ostg.clktrk > _______________________________________________ > Capstone-users mailing list > Cap...@li... > https://lists.sourceforge.net/lists/listinfo/capstone-users > |