#1 Chase a bashism in Makefile.in.

closed
nobody
None
5
2006-07-28
2006-07-27
No

Unless you run a fake shell,

if [ opt == opt ]; then ...

causes an error, and some files are not installed.

The following patch fixes the error:

--- ./Makefile.in.orig Mon Mar 13 13:17:35 2006
+++ ./Makefile.in Thu Jul 27 14:49:46 2006
@@ -367,7 +367,7 @@
install-without-ocamlfind:
mkdir -p $(OCAMLLIB)
cp -f $(INT) $(OCAMLLIB)
- if [ $(OCAMLBEST) == opt ]; then cp -f
public/*.cmx $(OCAMLLIB); fi
+ if [ "$(OCAMLBEST)" = "opt" ]; then cp -f
public/*.cmx $(OCAMLLIB); fi
if [ -f camomile.cmi ]; then cp -f camomile.cmi
$(OCAMLLIB); fi
if [ -f camomile.cma ]; then cp -f camomile.cma
$(OCAMLLIB); fi
if [ -f camomile.cmxa ]; then cp -f
camomile.cmxa $(OCAMLLIB); fi
@@ -378,7 +378,7 @@

install-with-ocamlfind:
files= &&\ - if [ $(OCAMLBEST) == opt ]; then
files=public/*.cmx; fi && \ + if [ "$(OCAMLBEST)" = "opt" ]; then
files=public/*.cmx; fi && \ if [ -f camomile.cma ]; then files="camomile.*
$$files"; fi&& \ if [ -f libcamomile.a ]; then
files="libcamomile.a $$files"; fi && \ if [ -f dllcamomile.so ]; then
files="dllcamomile.so $$files"; fi && \

Regards,
--
Th. Thomas.

Discussion

  • Yamagata Yoriyuki

    Logged In: YES
    user_id=373972

    Thank you for your pathc. However, this problem is already
    solved in Camomile-0.6.6. The fix is exactly same as you
    proposed.

     
  • Yamagata Yoriyuki

    • status: open --> closed
     

Log in to post a comment.