You can subscribe to this list here.
2010 |
Jan
|
Feb
|
Mar
|
Apr
|
May
(33) |
Jun
(14) |
Jul
(1) |
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
---|---|---|---|---|---|---|---|---|---|---|---|---|
2011 |
Jan
|
Feb
|
Mar
|
Apr
|
May
(19) |
Jun
(13) |
Jul
|
Aug
(1) |
Sep
(9) |
Oct
(8) |
Nov
|
Dec
|
2012 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
(14) |
Jul
|
Aug
|
Sep
(7) |
Oct
(7) |
Nov
|
Dec
|
2014 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
(3) |
Nov
|
Dec
|
2015 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
(1) |
Dec
|
2016 |
Jan
|
Feb
|
Mar
|
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
(15) |
2017 |
Jan
(11) |
Feb
|
Mar
(4) |
Apr
|
May
|
Jun
|
Jul
|
Aug
|
Sep
|
Oct
|
Nov
|
Dec
|
From: <rb...@us...> - 2010-06-05 09:34:56
|
Revision: 107 http://callflow.svn.sourceforge.net/callflow/?rev=107&view=rev Author: rbos Date: 2010-06-05 09:34:50 +0000 (Sat, 05 Jun 2010) Log Message: ----------- Have the 'list nodes' functionality use the cache callflow.short in case the cache exist Modified Paths: -------------- callflow Modified: callflow =================================================================== --- callflow 2010-05-27 20:18:33 UTC (rev 106) +++ callflow 2010-06-05 09:34:50 UTC (rev 107) @@ -73,6 +73,45 @@ COLORS="black" } +function make_long_and_short_caches() { + + tshark -r $inputfile $FARG "$FVAL" -V > $DESTDIR/callflow.long + + tshark -r $inputfile $FARG "$FVAL" -t a \ + -o 'column.format: "No.", "%m", "Time", "%t", "Src", "%s", "Port", "%S", "Ignored", "%m", "Dest", "%d", "Port", "%D", "Protocol", "%p", "Info", "%i"' | + sed 's/^[[:blank:]]*//;s/\([0-9]\{3\}\)000 /\1 /' | awk '{ + # The match and the substr are working together to get the string starting + # at field 9 till the end of the line. This provides the frame summary line. + # But the frame summary may contain characters that influence the match, + # such as the "(" and ")" characters. Therefor look for the end of the + # protocol field (8) as the protocol field contains most likely regular + # ascii characters. + + # The A[0, "start"] gives the start position of the $8 + match($0, $8, A) + SUMMARY_START = A[0, "start"] + length($8) + 1 + SUMMARY = substr($0, SUMMARY_START) + printf("%s|%s|%s|%s||%s|%s|%s|%s\n", $1, $2, $3, $4, $6, $7, $8, SUMMARY) + + }' > $TMPDIR/${PRGNAME}-tshark-1.$$ + + tshark -r $inputfile $FARG "$FVAL" -t a \ + -o 'column.format: "No.", "%m", "Cseq", "%Cus:sip.CSeq"' | + sed 's/^[[:blank:]]*//;s/ /|/' > $TMPDIR/${PRGNAME}-tshark-2.$$ + + ( # echo "time|no|trace|src|srcport|dir|dst|dstport|prot|summary|remark" + join -t "|" --nocheck-order $TMPDIR/${PRGNAME}-tshark-1.$$ $TMPDIR/${PRGNAME}-tshark-2.$$ | awk -F "|" '{ + printf("%s||%s|", $2, $1) + for ( N = 3; N < NF; N++) { + printf("%s|", $N) + } + printf("%s\n", $N) + }' + ) > $DESTDIR/callflow.short + + rm $TMPDIR/${PRGNAME}-tshark-1.$$ $TMPDIR/${PRGNAME}-tshark-2.$$ +} + function usage() { ( echo "$SHORTHELP" @@ -224,8 +263,6 @@ shift done -echo - inputfile=$1 ################################## @@ -277,25 +314,28 @@ TITLE="$inputfile" fi +# DESTDIR +DESTDIR=`ls $inputfile | sed -r "s/(.+)\.(.+)/\1/"`; +mkdir -p $DESTDIR + ################################## # order file ################################## # Build the order file and exit if [[ $ORDER = 1 ]]; then - tshark -r $inputfile $FARG "$FVAL" \ - -o 'column.format: "Src", "%s", "Port", "%S", "Dest", "%d", "Port", "%D"' | - awk '{ printf("%s:%s\n%s:%s\n", $1, $2, $3, $4); }' | sort --unique - exit 0; + [[ ! -f $DESTDIR/callflow.short ]] && make_long_and_short_caches + + awk -F"|" '{ + if ($0 !~ "#" ) { printf ("%s:%s\n%s:%s\n", $4, $5, $7, $8) } + }' $DESTDIR/callflow.short | sort --unique + + exit 0 fi ################################## # Build short and long files ################################## -# DESTDIR -DESTDIR=`ls $inputfile | sed -r "s/(.+)\.(.+)/\1/"`; -mkdir -p $DESTDIR - # Copy the input file into destdir TRACEFILE=$(basename $inputfile) cp $inputfile $DESTDIR/$TRACEFILE @@ -303,42 +343,8 @@ # if we do want to build new short and long file if [ $keepSL = 0 ]; then - tshark -r $inputfile $FARG "$FVAL" -V > $DESTDIR/callflow.long + make_long_and_short_caches - tshark -r $inputfile $FARG "$FVAL" -t a \ - -o 'column.format: "No.", "%m", "Time", "%t", "Src", "%s", "Port", "%S", "Ignored", "%m", "Dest", "%d", "Port", "%D", "Protocol", "%p", "Info", "%i"' | - sed 's/^[[:blank:]]*//;s/\([0-9]\{3\}\)000 /\1 /' | awk '{ - # The match and the substr are working together to get the string starting - # at field 9 till the end of the line. This provides the frame summary line. - # But the frame summary may contain characters that influence the match, - # such as the "(" and ")" characters. Therefor look for the end of the - # protocol field (8) as the protocol field contains most likely regular - # ascii characters. - - # The A[0, "start"] gives the start position of the $8 - match($0, $8, A) - SUMMARY_START = A[0, "start"] + length($8) + 1 - SUMMARY = substr($0, SUMMARY_START) - printf("%s|%s|%s|%s||%s|%s|%s|%s\n", $1, $2, $3, $4, $6, $7, $8, SUMMARY) - - }' > $TMPDIR/${PRGNAME}-tshark-1.$PPID - - tshark -r $inputfile $FARG "$FVAL" -t a \ - -o 'column.format: "No.", "%m", "Cseq", "%Cus:sip.CSeq"' | - sed 's/^[[:blank:]]*//;s/ /|/' > $TMPDIR/${PRGNAME}-tshark-2.$PPID - - ( # echo "time|no|trace|src|srcport|dir|dst|dstport|prot|summary|remark" - join -t "|" --nocheck-order $TMPDIR/${PRGNAME}-tshark-1.$PPID $TMPDIR/${PRGNAME}-tshark-2.$PPID | awk -F "|" '{ - printf("%s||%s|", $2, $1) - for ( N = 3; N < NF; N++) { - printf("%s|", $N) - } - printf("%s\n", $N) - }' - ) > $DESTDIR/callflow.short - - rm $TMPDIR/${PRGNAME}-tshark-1.$PPID $TMPDIR/${PRGNAME}-tshark-2.$PPID - else # We want to keep SL files # disable duplicate frame remove This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: Richard B. <ml...@ra...> - 2010-05-27 20:20:38
|
Op donderdag 27 mei 2010 10:46:26 schreef Richard Bos: > On Thu, May 27, 2010 at 09:08:22AM +0200, Arnaud MORIN wrote: > > Yep, why not! > > OK, I'll change it soon. I just committed the change to svn. > Question related to this function: > Why is the callflow.short not used to retrieve the hosts in the > trace? Once tshark is run to make the callflow.short file, it > is very easy to retrieve the files from that it. Do you know > why that is not done, is there a special reason? -- Richard |
From: <rb...@us...> - 2010-05-27 20:18:40
|
Revision: 106 http://callflow.svn.sourceforge.net/callflow/?rev=106&view=rev Author: rbos Date: 2010-05-27 20:18:33 +0000 (Thu, 27 May 2010) Log Message: ----------- Reflect changes arguments changes --list-nodes and --width-between-nodes in manpage Modified Paths: -------------- callflow man/callflow.1 Modified: callflow =================================================================== --- callflow 2010-05-27 20:12:31 UTC (rev 105) +++ callflow 2010-05-27 20:18:33 UTC (rev 106) @@ -111,7 +111,7 @@ Do not show the time. --list-nodes, -o - Lists the unique nodes in the trace file + List the unique nodes in the trace file (Don't forget to redirect output in another file. Example of use: $PRGNAME --list-nodes capture.cap > order) Modified: man/callflow.1 =================================================================== --- man/callflow.1 2010-05-27 20:12:31 UTC (rev 105) +++ man/callflow.1 2010-05-27 20:18:33 UTC (rev 106) @@ -64,6 +64,14 @@ .TP .PD 0 +.B -o +.TP +.PD +.B --list-nodes +List the unique nodes in the trace file (don't forget to redirect output in another file. Example of use: callflow -o capture.cap > order). + +.TP +.PD 0 .B --no-loops Prevent flows from and to the same equipment to be represented. @@ -78,17 +86,8 @@ .B --no-time Do not show the time. - .TP .PD 0 -.B -o -.TP -.PD -.B --order-file -Create an order file with the nodes in the trace file (Don't forget to redirect output in another file. Example of use: callflow -o capture.cap > order) - -.TP -.PD 0 .B -d .TP .PD @@ -122,8 +121,8 @@ .TP .PD 0 -.BI --width-between-hosts " width" -Distance between the hosts in final picture. The distance may vary between 100 and 250. Default = 200. +.BI --width-between-nodes " width" +Distance between the nodes in final picture. The distance may vary between 100 and 250. Default = 200. .SS Filtering the diagram @@ -134,7 +133,7 @@ If you know what nodes in your network are logically connected, you can have the diagram ordered in a meaningful way. Just create a file called order in your current directory or in the setup directory with the order of your network nodes, one per line. You must use the exact name or IP address that appears in your capture file in the form: <host/ip>:<port>, or use a regular expression that resolves to that name. Using a regular expression can be useful to collapse several nodes in to one logical node. You can generate an order file with: - callflow -o capture-file.cap > order + callflow --list-nodes capture-file.cap > order The format of the order file is as follows: <node-regex-pattern> [optional-label] @@ -261,11 +260,8 @@ .SH Example -.SS Create a filter file: - $ echo "sip" > filter - .SS Create an order file: - $ callflow -o mycapture.cap > order + $ callflow --list-nodes mycapture.cap > order (edit order file as needed) .SS Generate initial diagram: This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <rb...@us...> - 2010-05-27 20:12:37
|
Revision: 105 http://callflow.svn.sourceforge.net/callflow/?rev=105&view=rev Author: rbos Date: 2010-05-27 20:12:31 +0000 (Thu, 27 May 2010) Log Message: ----------- Misc changes: - renamed the variable 'order' to ORDER - renamed argument --order-file to --list-nodes - renamed argument --width-between-hosts to --width-between-nodes - renamed variable WIDTH_BETWEEN_HOSTS to WIDTH_BETWEEN_NODES Modified Paths: -------------- callflow Modified: callflow =================================================================== --- callflow 2010-05-26 18:35:12 UTC (rev 104) +++ callflow 2010-05-27 20:12:31 UTC (rev 105) @@ -6,7 +6,6 @@ ### ### Output: $DESTDIR/callflow.svg, $DESTDIR/callflow.png, $DESTDIR/index.html, $DESTDIR/frames/frame*.html ### -### Files: order, filter, session, $CONFDIR/order, $CONFDIR/filter, $CONFDIR/session ### ################################## @@ -15,7 +14,7 @@ CONFDIR="/etc/callflow"; keepSL=0 # do not keep cap.short and cap.long files removeDF=0 # do not remove duplicate frames -order=0 # do not build order file +ORDER=0 # do not build order file localLoop=1 # take into account flows from and to the same element (rounded flows) WITH_SESSION=yes readonly VersionSVN="$Id$"; #DO NOT EDIT THIS LINE BY HAND, DATE IS AUTOMATICALLY ADDED BY SUBVERSION @@ -27,7 +26,7 @@ ################################## # Check configuration files : -# callflow.conf, session, order, colors +# callflow.conf, order, colors ################################## for CONF in $CONFDIR/callflow.conf $HOME/.callflow/callflow.conf callflow.conf; do [[ -f $CONF ]] && . $CONF @@ -74,17 +73,16 @@ COLORS="black" } -function usage() -{ +function usage() { + ( echo "$SHORTHELP" echo "See $PRGNAME --help for extended help." ) >&2 exit 0 } -function help () -################ -{ +function help () { + cat << EOF >&1 Usage: $PRGNAME [options] <trace file> @@ -112,10 +110,10 @@ --no-time Do not show the time. - --order-file, -o - Create an order file with the nodes in the trace file + --list-nodes, -o + Lists the unique nodes in the trace file (Don't forget to redirect output in another file. - Example of use: callflow -o capture.cap > order) + Example of use: $PRGNAME --list-nodes capture.cap > order) --remove-duplicate-frames, -d Remove duplicate frames while computing. @@ -141,8 +139,8 @@ Note 1: if -c and -d are used, only -c is executed. Note 2: this option sould not be selected on the first run. - --width-between-hosts <width> - Distance between adjacent hosts in final picture. The width may + --width-between-nodes <width> + Distance between adjacent nodes in final picture. The width may vary between 100 and 250. Default = 200. EOF @@ -152,8 +150,8 @@ # Command line argument parsing, the allowed arguments are # alphabetically listed, keep it this way please. -LOPT="capture-filter:,help,order-file:,no-loops,no-session-token,no-time,remove-duplicate-frames" -LOPT="$LOPT,session-token:,title:,width-between-hosts:,use-cache,version" +LOPT="capture-filter:,help,list-nodes,no-loops,no-session-token,no-time,remove-duplicate-frames" +LOPT="$LOPT,session-token:,title:,width-between-nodes:,use-cache,version" # Note that we use `"$@"' to let each command-line parameter expand to a # separate word. The quotes around `$@' are essential! @@ -178,6 +176,9 @@ OPT_FILTER=$2; shift #echo " * Will use the following filter: $OPT_FILTER" ;; + --list-nodes|-o) + ORDER=1 + ;; --no-loops) # We want to disable auto flows (From and To the same equipment) noLocalLoop=1; @@ -190,11 +191,6 @@ OPT_SHOW_TIME=no #echo " * Time will not be shown" ;; - --order-file|-o) - # Inputfile is a cap-file - # make it an order file - order=1 - ;; --remove-duplicate-frames|-d) # Remove duplicate frames removeDF=1 @@ -217,9 +213,9 @@ keepSL=1 #echo " * Short and Long files will be used" ;; - --width-between-hosts) - OPT_WIDTH_BETWEEN_HOSTS=$2; shift - #echo " * Width between hosts to use: $OPT_WIDTH_BETWEEN_HOSTS" + --width-between-nodes) + OPT_WIDTH_BETWEEN_NODES=$2; shift + #echo " * Width between nodes to use: $OPT_WIDTH_BETWEEN_NODES" ;; --version|-v) echo "$PRGNAME version: $PRGVRSN"; exit;; --) shift; break;; @@ -236,7 +232,7 @@ # Check input file ################################## if [ ! -f "$inputfile" ]; then - echo "$PRGNAME: error: Input file does not exists!" + echo "$PRGNAME: error: Input file ($inputfile) does not exists!" exit 1; fi @@ -253,20 +249,20 @@ fi fi -if [[ -z "$OPT_WIDTH_BETWEEN_HOSTS" ]]; then - WIDTH_BETWEEN_HOSTS=200 +if [[ -z "$OPT_WIDTH_BETWEEN_NODES" ]]; then + WIDTH_BETWEEN_NODES=200 else - if [[ $OPT_WIDTH_BETWEEN_HOSTS -gt 250 ]]; then - echo "$PRGNAME: error: width between hosts too big" >&2 + if [[ $OPT_WIDTH_BETWEEN_NODES -gt 250 ]]; then + echo "$PRGNAME: error: width between nodes too big" >&2 exit 1 fi - if [[ $OPT_WIDTH_BETWEEN_HOSTS -lt 100 ]]; then - echo "$PRGNAME: error: width between hosts too small" >&2 + if [[ $OPT_WIDTH_BETWEEN_NODES -lt 100 ]]; then + echo "$PRGNAME: error: width between nodes too small" >&2 exit 1 fi - WIDTH_BETWEEN_HOSTS=$OPT_WIDTH_BETWEEN_HOSTS + WIDTH_BETWEEN_NODES=$OPT_WIDTH_BETWEEN_NODES fi if [[ -z "$OPT_SHOW_TIME" ]]; then @@ -285,7 +281,7 @@ # order file ################################## # Build the order file and exit -if [ $order = 1 ]; then +if [[ $ORDER = 1 ]]; then tshark -r $inputfile $FARG "$FVAL" \ -o 'column.format: "Src", "%s", "Port", "%S", "Dest", "%d", "Port", "%D"' | @@ -436,7 +432,7 @@ # Add graph variables yLineSpace = 24 - xHostSpace = $WIDTH_BETWEEN_HOSTS + xHostSpace = $WIDTH_BETWEEN_NODES rightMargin = 100 topMargin = 50 bottomMargin = 50 This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: Richard B. <ml...@ra...> - 2010-05-27 08:46:34
|
On Thu, May 27, 2010 at 09:08:22AM +0200, Arnaud MORIN wrote: > Yep, why not! OK, I'll change it soon. Question related to this function: Why is the callflow.short not used to retrieve the hosts in the trace? Once tshark is run to make the callflow.short file, it is very easy to retrieve the files from that it. Do you know why that is not done, is there a special reason? > > Hi Arnaud, > > > > Op woensdag 26 mei 2010 09:16:39 schreef Arnaud MORIN: > > > Everything works fine on my side, good job :p > > > > > > I am currently updating the man page > > > > OK, thanks! > > > > I would like to rename the argument --order-file to e.g. --list-hosts, > > because > > that is actually what it does. It lists the hosts that are part in the > > trace. > > Do you agree with this change? > > > > -- > > Richard > > > ------------------------------------------------------------------------------ > > _______________________________________________ > Callflow-svn mailing list > Cal...@li... > https://lists.sourceforge.net/lists/listinfo/callflow-svn |
From: Arnaud M. <arn...@gm...> - 2010-05-27 07:16:23
|
Yep, why not! On Wed, May 26, 2010 at 11:52 PM, Richard Bos <ml...@ra...> wrote: > Hi Arnaud, > > Op woensdag 26 mei 2010 09:16:39 schreef Arnaud MORIN: > > Everything works fine on my side, good job :p > > > > I am currently updating the man page > > OK, thanks! > > I would like to rename the argument --order-file to e.g. --list-hosts, > because > that is actually what it does. It lists the hosts that are part in the > trace. > Do you agree with this change? > > -- > Richard > |
From: <rb...@us...> - 2010-05-26 18:35:18
|
Revision: 104 http://callflow.svn.sourceforge.net/callflow/?rev=104&view=rev Author: rbos Date: 2010-05-26 18:35:12 +0000 (Wed, 26 May 2010) Log Message: ----------- correct yet another typo Modified Paths: -------------- callflow Modified: callflow =================================================================== --- callflow 2010-05-26 18:02:30 UTC (rev 103) +++ callflow 2010-05-26 18:35:12 UTC (rev 104) @@ -96,7 +96,7 @@ --capture-filter <filter>, -f <filter> A filter can be used to show only those frames that match the given filter criteria. This filter is for traces that have been - captured with programs such as wireshark, snoop, tcpdump, thsark + captured with programs such as wireshark, snoop, tcpdump, tshark and the like. $PRGNAME uses tshark's DISPLAY filter functionality to filter the trace. More information about tshark's DISPLAY filter can be obtained from the tshark man page. This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <rb...@us...> - 2010-05-26 18:02:36
|
Revision: 103 http://callflow.svn.sourceforge.net/callflow/?rev=103&view=rev Author: rbos Date: 2010-05-26 18:02:30 +0000 (Wed, 26 May 2010) Log Message: ----------- typo corrected Modified Paths: -------------- conf/callflow.conf Modified: conf/callflow.conf =================================================================== --- conf/callflow.conf 2010-05-26 07:19:41 UTC (rev 102) +++ conf/callflow.conf 2010-05-26 18:02:30 UTC (rev 103) @@ -15,8 +15,8 @@ darkslategrey midnightblue maroon teal goldenrod gray darkolivegreen darkcyan brown peru mediumorchild navy saddlebrown coral" -# FILTER, used to filter flow, default "sip" -# This filter is used as well as a DISPLAY filter in tsharl/wireshark. +# FILTER, used to filter flow, default "sip or diameter" +# This filter is used as well as a DISPLAY filter in tshark/wireshark. FILTER="sip or diameter" # SESSION, used to 'catch' session in trace file This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: <mo...@us...> - 2010-05-26 07:19:47
|
Revision: 102 http://callflow.svn.sourceforge.net/callflow/?rev=102&view=rev Author: moufki Date: 2010-05-26 07:19:41 +0000 (Wed, 26 May 2010) Log Message: ----------- Man page updated corresponding to Richard improvment Modified Paths: -------------- man/callflow.1 Modified: man/callflow.1 =================================================================== --- man/callflow.1 2010-05-25 20:01:29 UTC (rev 101) +++ man/callflow.1 2010-05-26 07:19:41 UTC (rev 102) @@ -59,8 +59,8 @@ .BI -f " filter" .TP .PD -.BI --filter " filter" -You can use a filter which contains a tshark DISPLAY filter (as opposed to a CAPTURE filter). You can learn more about these from the tshark man page. A useful filter for SIP traffic is "sip". The default filter in callflow configuration file is 'sip or diameter'. +.BI --cap-filter " filter" +A filter can be used to show only those frames that match the given filter criteria. This filter is for traces that have been captured with programs such as wireshark, snoop, tcpdump, thsark and the like. Callflow uses tshark's DISPLAY filter functionality to filter the trace. More information about tshark's DISPLAY filter can be obtained from the tshark man page. A useful filter for SIP traffic is "sip". .TP .PD 0 This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: Arnaud M. <arn...@gm...> - 2010-05-26 07:17:05
|
Hi Richard, Everything works fine on my side, good job :p I am currently updating the man page Arnaud. On Tue, May 25, 2010 at 10:01 PM, <rb...@us...> wrote: > Revision: 101 > http://callflow.svn.sourceforge.net/callflow/?rev=101&view=rev > Author: rbos > Date: 2010-05-25 20:01:29 +0000 (Tue, 25 May 2010) > > Log Message: > ----------- > - Change --filter argument into --capture-filter > - Reverse noLocalLoop variable to localLoop variable (easier to understand) > > Modified Paths: > -------------- > callflow > scripts/callflow.awk > > Modified: callflow > =================================================================== > --- callflow 2010-05-19 21:58:06 UTC (rev 100) > +++ callflow 2010-05-25 20:01:29 UTC (rev 101) > @@ -16,7 +16,7 @@ > keepSL=0 # do not keep cap.short and cap.long files > removeDF=0 # do not remove duplicate frames > order=0 # do not build order file > -noLocalLoop=0 # do not take into account flows from and to the same > element (rounded flows) > +localLoop=1 # take into account flows from and to the same element > (rounded flows) > WITH_SESSION=yes > readonly VersionSVN="$Id$"; #DO NOT EDIT THIS LINE BY HAND, DATE IS > AUTOMATICALLY ADDED BY SUBVERSION > readonly PRGVRSN=$(awk '{split($4, A, "-"); print A[1] A[2] A[3] "." $3}' > <<< "$VersionSVN") > @@ -93,11 +93,14 @@ > --help Print this help and exit > --version, -v Print version > > - --filter <filter>, -f <filter> > - You can use a filter which contains a tshark DISPLAY > filter > - (as opposed to a CAPTURE filter). You can learn more > about > - these from the tshark man page. A useful filter for > SIP > - traffic is "sip". > + --capture-filter <filter>, -f <filter> > + A filter can be used to show only those frames that match > the > + given filter criteria. This filter is for traces that > have been > + captured with programs such as wireshark, snoop, tcpdump, > thsark > + and the like. $PRGNAME uses tshark's DISPLAY filter > functionality > + to filter the trace. More information about tshark's > DISPLAY > + filter can be obtained from the tshark man page. > + A useful filter for SIP traffic is "sip". > > --no-loops > Prevent flows from and to the same equipment to be > represented. > @@ -149,7 +152,7 @@ > > # Command line argument parsing, the allowed arguments are > # alphabetically listed, keep it this way please. > > -LOPT="filter:,help,order-file:,no-loops,no-session-token,no-time,remove-duplicate-frames" > > +LOPT="capture-filter:,help,order-file:,no-loops,no-session-token,no-time,remove-duplicate-frames" > LOPT="$LOPT,session-token:,title:,width-between-hosts:,use-cache,version" > > # Note that we use `"$@"' to let each command-line parameter expand to a > @@ -170,7 +173,7 @@ > --help) help; exit ;; > -h) usage; exit;; > > - --filter|-f) > + --capture-filter|-f) > # Overwrite the default filter previously red from > the configuration file > OPT_FILTER=$2; shift > #echo " * Will use the following filter: > $OPT_FILTER" > @@ -445,8 +448,8 @@ > } > numTraces = numHosts > > - # Add noLocalLoop to vars in order to delete self messaging > - noLocalLoop = "$noLocalLoop" > + # Add localLoop to vars in order to delete self messaging > + localLoop = "$localLoop" > > AWK_BEGIN_SECTION > > > Modified: scripts/callflow.awk > =================================================================== > --- scripts/callflow.awk 2010-05-19 21:58:06 UTC (rev 100) > +++ scripts/callflow.awk 2010-05-25 20:01:29 UTC (rev 101) > @@ -179,7 +179,7 @@ > > x1 = x1 * xHostSpace + leftMargin; > x2 = x2 * xHostSpace + leftMargin; > - if ((x1==x2) && (noLocalLoop==1)) { > + if ((x1==x2) && (localLoop == 0)) { > # Do nothing > } else { > # Print the line > > > This was sent by the SourceForge.net collaborative development platform, > the world's largest Open Source development site. > > > ------------------------------------------------------------------------------ > > _______________________________________________ > Callflow-svn mailing list > Cal...@li... > https://lists.sourceforge.net/lists/listinfo/callflow-svn > |
From: <rb...@us...> - 2010-05-25 20:01:35
|
Revision: 101 http://callflow.svn.sourceforge.net/callflow/?rev=101&view=rev Author: rbos Date: 2010-05-25 20:01:29 +0000 (Tue, 25 May 2010) Log Message: ----------- - Change --filter argument into --capture-filter - Reverse noLocalLoop variable to localLoop variable (easier to understand) Modified Paths: -------------- callflow scripts/callflow.awk Modified: callflow =================================================================== --- callflow 2010-05-19 21:58:06 UTC (rev 100) +++ callflow 2010-05-25 20:01:29 UTC (rev 101) @@ -16,7 +16,7 @@ keepSL=0 # do not keep cap.short and cap.long files removeDF=0 # do not remove duplicate frames order=0 # do not build order file -noLocalLoop=0 # do not take into account flows from and to the same element (rounded flows) +localLoop=1 # take into account flows from and to the same element (rounded flows) WITH_SESSION=yes readonly VersionSVN="$Id$"; #DO NOT EDIT THIS LINE BY HAND, DATE IS AUTOMATICALLY ADDED BY SUBVERSION readonly PRGVRSN=$(awk '{split($4, A, "-"); print A[1] A[2] A[3] "." $3}' <<< "$VersionSVN") @@ -93,11 +93,14 @@ --help Print this help and exit --version, -v Print version - --filter <filter>, -f <filter> - You can use a filter which contains a tshark DISPLAY filter - (as opposed to a CAPTURE filter). You can learn more about - these from the tshark man page. A useful filter for SIP - traffic is "sip". + --capture-filter <filter>, -f <filter> + A filter can be used to show only those frames that match the + given filter criteria. This filter is for traces that have been + captured with programs such as wireshark, snoop, tcpdump, thsark + and the like. $PRGNAME uses tshark's DISPLAY filter functionality + to filter the trace. More information about tshark's DISPLAY + filter can be obtained from the tshark man page. + A useful filter for SIP traffic is "sip". --no-loops Prevent flows from and to the same equipment to be represented. @@ -149,7 +152,7 @@ # Command line argument parsing, the allowed arguments are # alphabetically listed, keep it this way please. -LOPT="filter:,help,order-file:,no-loops,no-session-token,no-time,remove-duplicate-frames" +LOPT="capture-filter:,help,order-file:,no-loops,no-session-token,no-time,remove-duplicate-frames" LOPT="$LOPT,session-token:,title:,width-between-hosts:,use-cache,version" # Note that we use `"$@"' to let each command-line parameter expand to a @@ -170,7 +173,7 @@ --help) help; exit ;; -h) usage; exit;; - --filter|-f) + --capture-filter|-f) # Overwrite the default filter previously red from the configuration file OPT_FILTER=$2; shift #echo " * Will use the following filter: $OPT_FILTER" @@ -445,8 +448,8 @@ } numTraces = numHosts - # Add noLocalLoop to vars in order to delete self messaging - noLocalLoop = "$noLocalLoop" + # Add localLoop to vars in order to delete self messaging + localLoop = "$localLoop" AWK_BEGIN_SECTION Modified: scripts/callflow.awk =================================================================== --- scripts/callflow.awk 2010-05-19 21:58:06 UTC (rev 100) +++ scripts/callflow.awk 2010-05-25 20:01:29 UTC (rev 101) @@ -179,7 +179,7 @@ x1 = x1 * xHostSpace + leftMargin; x2 = x2 * xHostSpace + leftMargin; - if ((x1==x2) && (noLocalLoop==1)) { + if ((x1==x2) && (localLoop == 0)) { # Do nothing } else { # Print the line This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: Richard B. <ml...@ra...> - 2010-05-22 09:22:35
|
Op woensdag 19 mei 2010 23:20:00 schreef Richard Bos: > > either tshark, wireshark, tcpdump can save flow in other format, not > > pcap. However, the filter is still the same. So I think pcap is not a > > really good name, but as you explain it, tshark is not a good one too. I > > propose to use cap-filter, it shows that the filter will be apply to a > > capture file taken from application like wireshark, tcpdump. > > OK --cap-filter, capture-filter Here is the patch for argument name change. -- Richard |
From: Richard B. <ml...@ra...> - 2010-05-22 08:57:42
|
Hi Arnaud, Op woensdag 19 mei 2010 23:20:00 schreef Richard Bos: > Op woensdag 19 mei 2010 18:50:19 schreef Arnaud MORIN: > > > I'm not talking about the argument, but the variable itself (inside > > > the code) Like: > > > line 19: noLocalLoop=0 > > > would become > > > localLoop=1 or better localLoop=yes or true > > > > > > The current argument name --no-loop is okay for me. > > > > > > Ok, so I am Ok to rename the variable too ;) > > > > > > Will you do it, or me? > > I don't care. Hmmm, if you do it, it is less work for me ;) If you don't > I'll take care for it :) See attach patch for it. Can you review it? I have no traces with local loops, can you perhaps test it too? -- Richard |
From: <rb...@us...> - 2010-05-19 21:58:12
|
Revision: 100 http://callflow.svn.sourceforge.net/callflow/?rev=100&view=rev Author: rbos Date: 2010-05-19 21:58:06 +0000 (Wed, 19 May 2010) Log Message: ----------- - Added configuration file: /home/richard/.callflow/callflow.conf Updated manpage to reflect this change - Removed * Session token to use message Modified Paths: -------------- callflow man/callflow.1 Modified: callflow =================================================================== --- callflow 2010-05-18 19:52:33 UTC (rev 99) +++ callflow 2010-05-19 21:58:06 UTC (rev 100) @@ -29,7 +29,7 @@ # Check configuration files : # callflow.conf, session, order, colors ################################## -for CONF in $CONFDIR/callflow.conf callflow.conf; do +for CONF in $CONFDIR/callflow.conf $HOME/.callflow/callflow.conf callflow.conf; do [[ -f $CONF ]] && . $CONF done @@ -278,9 +278,6 @@ TITLE="$inputfile" fi -[[ $WITH_SESSION == "yes" ]] && echo " * Session token to use: $SESSION" - - ################################## # order file ################################## Modified: man/callflow.1 =================================================================== --- man/callflow.1 2010-05-18 19:52:33 UTC (rev 99) +++ man/callflow.1 2010-05-19 21:58:06 UTC (rev 100) @@ -304,6 +304,13 @@ i. clean up all the /tmp files +.SH "FILES" +The system-wide configuration file \fI/etc/callflow.conf\fR, and the personal ones \fI$HOME/.callflow.conf\fR +and \fIcallflow.conf\fR are used by callflow. If the system-wide configuration file exists, it is read first, +overriding the default settings. If the personal configuration files exists, they are read next, overriding +any previous values. + + .SH TO DO It would be much nicer to take the tshark filtered output and build an intermediate XML representation of it. Then use XSLT to transform it into the SVG file. This way you could write up illustrative sequence diagrams more easily and make use of more tools that can manipulate XML. @@ -314,6 +321,10 @@ Specify output filenames and locations on the command line. +.SH "SEE ALSO" +Callflow project page at \fIhttp://callflow.sourceforge.net\fR + + .SH AUTHORS Man page created by Arnaud Morin <arn...@gm...>. This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |
From: Richard B. <ri...@ra...> - 2010-05-19 21:18:18
|
Hi Arnaud, Op woensdag 19 mei 2010 18:50:19 schreef Arnaud MORIN: > > I'm not talking about the argument, but the variable itself (inside > > the code) Like: > > line 19: noLocalLoop=0 > > would become > > localLoop=1 or better localLoop=yes or true > > > > The current argument name --no-loop is okay for me. > > > > Ok, so I am Ok to rename the variable too ;) > > Will you do it, or me? I don't care. Hmmm, if you do it, it is less work for me ;) If you don't I'll take care for it :) > > I see your reason, why you would call it --tshark-display-filter > > as you approach it from the inside (from inside callflow, where > > tshark is used). I approach it from the outside, where the user > > feed callflow (the blackbox) with a pcap file, obtained from either > > tcpdump, snoop, wireshark, perhaps tshark. All these tools create > > pcap files hence my proposal for --pcap-filter. > > > > If --tshark-display-filter is used as name, and imagine that the > > filter logic for pcap is changed from e.g. tshark to grep or awk, > > should the argument name be changed? I also believe that the user > > should not be bothered with the callflow internals, although using > > --tshark-display-filter is very clear what it will be capable of > > doing, but that can be explained in the manpage too. > > > > You're right, but pcap-filter let suppose that the cap file is pcap, or > > either tshark, wireshark, tcpdump can save flow in other format, not pcap. > However, the filter is still the same. So I think pcap is not a really good > name, but as you explain it, tshark is not a good one too. I propose to use > cap-filter, it shows that the filter will be apply to a capture file taken > from application like wireshark, tcpdump. OK --cap-filter, capture-filter -- Richard |
From: Arnaud M. <arn...@gm...> - 2010-05-19 16:50:45
|
On Wed, May 19, 2010 at 12:53 PM, Richard Bos <ml...@ra...> wrote: > On Wed, May 19, 2010 at 11:52:40AM +0200, Arnaud MORIN wrote: > > On Tue, May 18, 2010 at 10:14 PM, Richard <ri...@ra...> wrote: > > > > > Hi Arnuad, > > > > > > some issues that the last hacking session: > > > > > > - Why not remove the commented echo lines in the argument parser? You > can > > > always get them back, from the svn history. > > > > > > I think they could still be used for debugging... > > Hmm. Okay. > > > > > - Would it be okay to alter the variable noLocalLoop to LocalLoop (of > > > course > > > also inverse the checks). It is always hard to read variables that > start > > > with > > > no.... > > > > > > It can be done, but the thing we can do is to rename (again!) this > option > > to something like: --remove-local-loop, and so rename the variable too. > > What do you think about that? > > I'm not talking about the argument, but the variable itself (inside > the code) Like: > line 19: noLocalLoop=0 > would become > localLoop=1 or better localLoop=yes or true > > The current argument name --no-loop is okay for me. > > Ok, so I am Ok to rename the variable too ;) Will you do it, or me? > > > > - Would it be possible to rename the --filter option to --pcap-filter. > In > > > the > > > future there could be other filters for other input files (like > logfiles). > > > To > > > prevent confusion in the future the use of --pcap-filter would be > better I > > > believe. > > > > > > Instead of pcap-filter, perhaps tshark-display-filter is better as it > is a > > true tshark display filter. Agree? > > I see your reason, why you would call it --tshark-display-filter > as you approach it from the inside (from inside callflow, where > tshark is used). I approach it from the outside, where the user > feed callflow (the blackbox) with a pcap file, obtained from either > tcpdump, snoop, wireshark, perhaps tshark. All these tools create > pcap files hence my proposal for --pcap-filter. > > If --tshark-display-filter is used as name, and imagine that the > filter logic for pcap is changed from e.g. tshark to grep or awk, > should the argument name be changed? I also believe that the user > should not be bothered with the callflow internals, although using > --tshark-display-filter is very clear what it will be capable of > doing, but that can be explained in the manpage too. > > You're right, but pcap-filter let suppose that the cap file is pcap, or either tshark, wireshark, tcpdump can save flow in other format, not pcap. However, the filter is still the same. So I think pcap is not a really good name, but as you explain it, tshark is not a good one too. I propose to use cap-filter, it shows that the filter will be apply to a capture file taken from application like wireshark, tcpdump. > -- > Richard > > > > > > ------------------------------------------------------------------------------ > > _______________________________________________ > Callflow-svn mailing list > Cal...@li... > https://lists.sourceforge.net/lists/listinfo/callflow-svn > |
From: Richard B. <ml...@ra...> - 2010-05-19 10:53:23
|
On Wed, May 19, 2010 at 11:52:40AM +0200, Arnaud MORIN wrote: > On Tue, May 18, 2010 at 10:14 PM, Richard <ri...@ra...> wrote: > > > Hi Arnuad, > > > > some issues that the last hacking session: > > > > - Why not remove the commented echo lines in the argument parser? You can > > always get them back, from the svn history. > > > > I think they could still be used for debugging... Hmm. Okay. > > - Would it be okay to alter the variable noLocalLoop to LocalLoop (of > > course > > also inverse the checks). It is always hard to read variables that start > > with > > no.... > > > > It can be done, but the thing we can do is to rename (again!) this option > to something like: --remove-local-loop, and so rename the variable too. > What do you think about that? I'm not talking about the argument, but the variable itself (inside the code) Like: line 19: noLocalLoop=0 would become localLoop=1 or better localLoop=yes or true The current argument name --no-loop is okay for me. > > - Would it be possible to rename the --filter option to --pcap-filter. In > > the > > future there could be other filters for other input files (like logfiles). > > To > > prevent confusion in the future the use of --pcap-filter would be better I > > believe. > > > > Instead of pcap-filter, perhaps tshark-display-filter is better as it is a > true tshark display filter. Agree? I see your reason, why you would call it --tshark-display-filter as you approach it from the inside (from inside callflow, where tshark is used). I approach it from the outside, where the user feed callflow (the blackbox) with a pcap file, obtained from either tcpdump, snoop, wireshark, perhaps tshark. All these tools create pcap files hence my proposal for --pcap-filter. If --tshark-display-filter is used as name, and imagine that the filter logic for pcap is changed from e.g. tshark to grep or awk, should the argument name be changed? I also believe that the user should not be bothered with the callflow internals, although using --tshark-display-filter is very clear what it will be capable of doing, but that can be explained in the manpage too. -- Richard |
From: Richard B. <ml...@ra...> - 2010-05-19 10:42:24
|
On Wed, May 19, 2010 at 12:28:56PM +0200, Arnaud MORIN wrote: > > > 2- I forgot to remove the 'echo * Session token to use:', I used it for > > > debug... > > > > I see. Should this line > > [[ $WITH_SESSION == "yes" ]] && echo " * Session token to use: $SESSION" > > be removed from callflow? > > > > Yes OK, I'll do that. > > > 4- no-session-token is not usefull because if you do not want to use the > > > session token, you can remove it by using --session-token "" > > > > I now. But having the --no-session-token is consistent, with the other > > arguments "--no-..." versus the arguments that enables something. > > > So can --session-token "" still be used? Definately! -- Richard |
From: Arnaud M. <arn...@gm...> - 2010-05-19 10:29:23
|
On Wed, May 19, 2010 at 11:49 AM, Richard Bos <ml...@ra...> wrote: > Arnaud, > > On Wed, May 19, 2010 at 11:40:59AM +0200, Arnaud MORIN wrote: > > He Richard, > > > > 1- What is the missing file error? (eap.xml?) > > It's an error created by wireshark. I'm not bothered by it. > > Ok > > > 2- I forgot to remove the 'echo * Session token to use:', I used it for > > debug... > > I see. Should this line > [[ $WITH_SESSION == "yes" ]] && echo " * Session token to use: $SESSION" > be removed from callflow? > > Yes > > > 3- About the color message error, are you sure to use the correct > > callflow.conf file in /etc ? My callflow.conf file has a default COLORS > > value, so the error should not happen... > > Yes. I played the stupid user, who configured COLORS= > in his / her callflow.conf file. > > Ok ;) > > > 4- no-session-token is not usefull because if you do not want to use the > > session token, you can remove it by using --session-token "" > > I now. But having the --no-session-token is consistent, with the other > arguments "--no-..." versus the arguments that enables something. > So can --session-token "" still be used? > > -- > Richard > > > > On Tue, May 18, 2010 at 9:17 PM, Richard <ri...@ra...> wrote: > > > > > Op dinsdag 18 mei 2010 14:57:33 schreef u: > > > > With your last patch, this bug is not anymore relevant, is it ok on > your > > > > side? > > > > > > I can still get the error.... > > > > > > pcap> ./callflow.svn --session-token "" trace.pcap > > > * Session token to use: > > > > > > Could not open file: 'eap.xml', error: No such file or directory > > > Could not open file: 'eap.xml', error: No such file or directory > > > Could not open file: 'eap.xml', error: No such file or directory > > > awk: /tmp/callflow.awk.16320:141: (FILENAME=trace/callflow.short FNR=1) > > > fataal: scalair 'color' wordt gebruikt als array > > > > > > I'll fix it with: > > > [[ -z "$COLORS" ]]; then > > > COLORS="......................" > > > fi > > > > > > I'll also add a --no-session-token > > > > > > > > > > On Fri, May 14, 2010 at 8:43 PM, Richard <ri...@ra...> wrote: > > > > > Hello Arnuad, > > > > > > > > > > commit 84 is not good: > > > > > > > > > > > > > > http://callflow.svn.sourceforge.net/viewvc/callflow/callflow?r1=84&r2=86& > > > > >pathrev=86 > > > > > > > > > > The result can be: > > > > > awk: /tmp/callflow.awk.9784:134: (FILENAME=trace/callflow.short > FNR=1) > > > > > fataal: > > > > > scalair 'color' wordt gebruikt als array > > > > > trace/callflow.svg:69: parser error : Premature end of data in tag > svg > > > > > line 18 > > > > > ** (inkscape:10725): WARNING **: Specified document > trace/callflow.svg > > > > > cannot > > > > > be opened (is it valid SVG file?) > > > > > > > > > > > > > > > That's because: > > > > > I use a callflow.conf in the current directory: > > > > > pcap> ls callflow.conf > > > > > callflow.conf > > > > > pcap> ./callflow.svn --with-session trace.pcap > > > > > > > > > > On purpose I removed the definition of the COLORS variable. With > your > > > > > patch > > > > > in place there are now no colors defined.... > > > > > > > > > > The question is whether we should support this (missing COLORS > > > variable). > > > > > If > > > > > we should, the construction should become: > > > > > > > > > > else [[ -z "$COLORS" ]]; then > > > > > COLORS="......................" > > > > > fi > > > > > > > > > > > > > > > -- > > > > > Richard > > > > > > > > > > -- > > > Richard > > > > > > > ------------------------------------------------------------------------------ > > > > > _______________________________________________ > > Callflow-svn mailing list > > Cal...@li... > > https://lists.sourceforge.net/lists/listinfo/callflow-svn > > |
From: Arnaud M. <arn...@gm...> - 2010-05-19 10:22:22
|
Ok now, reply are sent to callflow SVN On Wed, May 19, 2010 at 12:08 PM, Arnaud MORIN <arn...@is...> wrote: > test mail > |
From: Arnaud M. <arn...@is...> - 2010-05-19 10:08:57
|
test mail |
From: Arnaud M. <arn...@gm...> - 2010-05-19 09:53:06
|
On Tue, May 18, 2010 at 10:14 PM, Richard <ri...@ra...> wrote: > Hi Arnuad, > > some issues that the last hacking session: > > - Why not remove the commented echo lines in the argument parser? You can > always get them back, from the svn history. > > I think they could still be used for debugging... > - Would it be okay to alter the variable noLocalLoop to LocalLoop (of > course > also inverse the checks). It is always hard to read variables that start > with > no.... > > It can be done, but the thing we can do is to rename (again!) this option to something like: --remove-local-loop, and so rename the variable too. What do you think about that? > - Would it be possible to rename the --filter option to --pcap-filter. In > the > future there could be other filters for other input files (like logfiles). > To > prevent confusion in the future the use of --pcap-filter would be better I > believe. > > Instead of pcap-filter, perhaps tshark-display-filter is better as it is a true tshark display filter. Agree? > -- > Richard > -- Arnaud |
From: Arnaud M. <arn...@gm...> - 2010-05-19 09:41:26
|
He Richard, 1- What is the missing file error? (eap.xml?) 2- I forgot to remove the 'echo * Session token to use:', I used it for debug... 3- About the color message error, are you sure to use the correct callflow.conf file in /etc ? My callflow.conf file has a default COLORS value, so the error should not happen... 4- no-session-token is not usefull because if you do not want to use the session token, you can remove it by using --session-token "" On Tue, May 18, 2010 at 9:17 PM, Richard <ri...@ra...> wrote: > Op dinsdag 18 mei 2010 14:57:33 schreef u: > > With your last patch, this bug is not anymore relevant, is it ok on your > > side? > > I can still get the error.... > > pcap> ./callflow.svn --session-token "" trace.pcap > * Session token to use: > > Could not open file: 'eap.xml', error: No such file or directory > Could not open file: 'eap.xml', error: No such file or directory > Could not open file: 'eap.xml', error: No such file or directory > awk: /tmp/callflow.awk.16320:141: (FILENAME=trace/callflow.short FNR=1) > fataal: scalair 'color' wordt gebruikt als array > > I'll fix it with: > [[ -z "$COLORS" ]]; then > COLORS="......................" > fi > > I'll also add a --no-session-token > > > > On Fri, May 14, 2010 at 8:43 PM, Richard <ri...@ra...> wrote: > > > Hello Arnuad, > > > > > > commit 84 is not good: > > > > > > > http://callflow.svn.sourceforge.net/viewvc/callflow/callflow?r1=84&r2=86& > > >pathrev=86 > > > > > > The result can be: > > > awk: /tmp/callflow.awk.9784:134: (FILENAME=trace/callflow.short FNR=1) > > > fataal: > > > scalair 'color' wordt gebruikt als array > > > trace/callflow.svg:69: parser error : Premature end of data in tag svg > > > line 18 > > > ** (inkscape:10725): WARNING **: Specified document trace/callflow.svg > > > cannot > > > be opened (is it valid SVG file?) > > > > > > > > > That's because: > > > I use a callflow.conf in the current directory: > > > pcap> ls callflow.conf > > > callflow.conf > > > pcap> ./callflow.svn --with-session trace.pcap > > > > > > On purpose I removed the definition of the COLORS variable. With your > > > patch > > > in place there are now no colors defined.... > > > > > > The question is whether we should support this (missing COLORS > variable). > > > If > > > we should, the construction should become: > > > > > > else [[ -z "$COLORS" ]]; then > > > COLORS="......................" > > > fi > > > > > > > > > -- > > > Richard > > > > -- > Richard > |
From: Arnaud M. <arn...@gm...> - 2010-05-19 09:31:40
|
Hi Richard, If people do not like the default color, either they can change the callflow.conf in /etc/ (for all cap files) or add a callflow.conf in the current directory (only for the current cap file) . But if you really want to use another conf file in /home, let's use it, but in my point of view, it's not a really good way to configure an application, because when you are looking to change something in the configuration, you have to be aware about all configuration files... But, that is not a really big problem for me if you would like to add the /home file :). You can commit the change if you want. Cheers, Arnaud On Tue, May 18, 2010 at 8:59 PM, Richard <ri...@ra...> wrote: > Hi Arnaud, > > Op dinsdag 18 mei 2010 13:33:20 schreef u: > > Ok, I am just looking on your patch. > > > > I think that we may not use $HOME/.callflow/callflow.conf as it in not > not > > really usefull and add a complicated conf management. I hope you agree? > > No, I don't agree ;) Let's discuss if that is okay with you. What if I > don't > like the default colors (that is how people are). This means that with the > current code, one needs to create the file callflow.conf each time > (assuming > that callflow is run each time from a different directory). With the > $HOME/.callflow/callflow.conf conf file, I can specify the colors once for > always. > > The file only need to contain: > $ cat $HOME/.callflow/callflow.conf conf > COLORS="a bunch of colors" > ============ > > I don't see why this complicates configuration management. it's very > normal > to have configuration files in $HOME/.<name>, actually I expect callflow to > such a possibility...... > > Hopefully you agree to add the file $HOME/.callflow/callflow.conf to the > configuration files? The man page can refer to it in the FILES section. > > -- > Richard > |
From: <rb...@us...> - 2010-05-18 19:52:39
|
Revision: 99 http://callflow.svn.sourceforge.net/callflow/?rev=99&view=rev Author: rbos Date: 2010-05-18 19:52:33 +0000 (Tue, 18 May 2010) Log Message: ----------- - Remove undeeded (at least for bash) ; - Define variable that was present but undefined (ERR_ARGUMENT) - Define at least 1 color in case COLORS is undefined - Added no-session-token - Reflect added no-session-token argument in the session-token processing - Updated manpage to reflect changes Modified Paths: -------------- callflow man/callflow.1 Modified: callflow =================================================================== --- callflow 2010-05-18 19:15:55 UTC (rev 98) +++ callflow 2010-05-18 19:52:33 UTC (rev 99) @@ -14,13 +14,17 @@ ################################## CONFDIR="/etc/callflow"; keepSL=0 # do not keep cap.short and cap.long files -removeDF=0; # do not remove duplicate frames -order=0; # do not build order file -noLocalLoop=0; # do not take into account flows from and to the same element (rounded flows) +removeDF=0 # do not remove duplicate frames +order=0 # do not build order file +noLocalLoop=0 # do not take into account flows from and to the same element (rounded flows) +WITH_SESSION=yes readonly VersionSVN="$Id$"; #DO NOT EDIT THIS LINE BY HAND, DATE IS AUTOMATICALLY ADDED BY SUBVERSION readonly PRGVRSN=$(awk '{split($4, A, "-"); print A[1] A[2] A[3] "." $3}' <<< "$VersionSVN") readonly PRGNAME=$(basename $0) +# Define exit values +readonly ERR_ARGUMENT=2 + ################################## # Check configuration files : # callflow.conf, session, order, colors @@ -65,6 +69,11 @@ COLORS=$(cat colors) fi +[[ -z "$COLORS" ]] && { + # At least one color is needed, to prevent errors + COLORS="black" +} + function usage() { ( echo "$SHORTHELP" @@ -93,6 +102,10 @@ --no-loops Prevent flows from and to the same equipment to be represented. + --no-session-token + Disable the session detection (show ID and colorization), for more + information see the --session-token argument. + --no-time Do not show the time. @@ -113,8 +126,7 @@ You should use this option in order to overwrite the default value. If you want to disable the session detection (show ID and - colorization), you should use a empty session token: - --session-token "" + colorization), you should use: --no-session-token. --title <title> Use <title> as title in the callflow. If not specified the @@ -137,7 +149,8 @@ # Command line argument parsing, the allowed arguments are # alphabetically listed, keep it this way please. -LOPT="filter:,help,order-file:,no-loops,no-time,remove-duplicate-frames,session-token:,title:,width-between-hosts:,use-cache,version" +LOPT="filter:,help,order-file:,no-loops,no-session-token,no-time,remove-duplicate-frames" +LOPT="$LOPT,session-token:,title:,width-between-hosts:,use-cache,version" # Note that we use `"$@"' to let each command-line parameter expand to a # separate word. The quotes around `$@' are essential! @@ -167,6 +180,9 @@ noLocalLoop=1; #echo " * Flows from and to the same equipment will not be shown" ;; + --no-session-token) + WITH_SESSION=no + ;; --no-time) OPT_SHOW_TIME=no #echo " * Time will not be shown" @@ -183,7 +199,11 @@ ;; --session-token) SESSION="$2"; shift - echo " * Session token to use: $SESSION" + if [[ -n "$SESSION" ]]; then + WITH_SESSION=yes + else + WITH_SESSION=no + fi ;; --title) OPT_TITLE="$2"; shift @@ -201,7 +221,6 @@ --version|-v) echo "$PRGNAME version: $PRGVRSN"; exit;; --) shift; break;; *) echo "unknow argument \"$1\""; exit $ERR_ARGUMENT;; - ;; esac shift done @@ -259,6 +278,9 @@ TITLE="$inputfile" fi +[[ $WITH_SESSION == "yes" ]] && echo " * Session token to use: $SESSION" + + ################################## # order file ################################## @@ -362,7 +384,7 @@ fi # Add session ID and colorization -if [ ! $SESSION == "" ]; then +if [[ $WITH_SESSION == "yes" ]]; then awk -f $SETUPDIR/scripts/marksession.awk -v session_token="$SESSION" -v destDir=$DESTDIR < $DESTDIR/callflow.short > $DESTDIR/callflow.short.new rm $DESTDIR/callflow.short mv $DESTDIR/callflow.short.new $DESTDIR/callflow.short Modified: man/callflow.1 =================================================================== --- man/callflow.1 2010-05-18 19:15:55 UTC (rev 98) +++ man/callflow.1 2010-05-18 19:52:33 UTC (rev 99) @@ -68,6 +68,12 @@ Prevent flows from and to the same equipment to be represented. .TP +.PD +.B --no-session-token +Disable the session detection (show ID and colorization), for more information +see the --session-token argument. + +.TP .PD 0 .B --no-time Do not show the time. @@ -92,7 +98,7 @@ .TP .PD 0 .BI --session-token " session" -Add a session ID to sequence lines and color lines related to this session ID. This option is available by default and the value is 'Call-Id:' (depending on your callflow configuration). You should use this option in order to overwrite the default value. If you want to disable the session detection (show ID and colorization), you should use a empty session token: --session-token '' +Add a session ID to sequence lines and color lines related to this session ID. This option is available by default and the value is 'Call-Id:' (depending on your callflow configuration). You should use this option in order to overwrite the default value. If you want to disable the session detection (show ID and colorization), you should --no-session-token. .TP .PD 0 This was sent by the SourceForge.net collaborative development platform, the world's largest Open Source development site. |