Re: [cadcdev-tiki] initial SDL and DC ports pushed to SVN

[Dan P. <ba...@al...>]

On Nov 17, Sam Steele wrote:

> The only problem is that pch.h is including kos.h, which includes dc/ 
> fmath.h before any other header files.  Once those macros are  
> defined, you can't use them as a function name or gcc will barf.   
> xylogmover.cpp was the only cpp file that was calling the functions  
> as Tiki::Math:fsin() instead of using namespace Tiki::math;  fsin();

The thing about it is that it makes a kind of inconsistent situation
between the different ports. I guess if someone really wants DC support
then it's not a huge burden...

I seem to remember there being some conflict on one of the other platforms
though. Like maybe their libc actually had functions called fsin().

> I considered removing kos.h from pch.h, and just including the  
> headers from KOS that are actually needed, but kos/include/assert.h  
> ends up including kos.h anyway, so it was kind of pointless.

Now that actually sounds like a bug (the assert thing). A header that basic
shouldn't end up including so much.


BTW do you guys have any suggestions on the email notification for SVN check
ins? It wasn't a big deal when it was just KOS, but now that we have multiple
active projects in the one repo, it's starting to become confusing what the
commit messages mean without some context. We could prepend Tiki checkins
with "tiki:" (what I did in my internal repo, which is nice since it stays
with the history itself) or we could list changed files in the notification
emails, etc... or I could probably split the Tiki stuff into its own repo,
though that's a bit of a pain now that it's in the KOS one.