[cadcdev-svn-commits] [SCM] branch master updated. v2.0.0-1510-g688c85db

[falcovorbis <fal...@us...>]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "A pseudo Operating System for the Dreamcast.".

The branch, master has been updated
       via  688c85db2fb0255ce4aff8cdabbeb2c4c099d65b (commit)
      from  8f4089dac331d7d2ca85701453b98f66baf1532e (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 688c85db2fb0255ce4aff8cdabbeb2c4c099d65b
Author: darcagn <da...@pr...>
Date:   Sat Aug 31 23:28:31 2024 -0500

    Remove FD_SETSIZE setting from environ.sh (#719)

-----------------------------------------------------------------------

Summary of changes:
 doc/environ.sh.sample | 15 ---------------
 include/kos/opts.h    |  5 +++--
 kernel/fs/fs.c        |  7 +++----
 3 files changed, 6 insertions(+), 21 deletions(-)

diff --git a/doc/environ.sh.sample b/doc/environ.sh.sample
index ad12f47e..f1a0989d 100644
--- a/doc/environ.sh.sample
+++ b/doc/environ.sh.sample
@@ -144,21 +144,6 @@ export KOS_CFLAGS="${KOS_CFLAGS} -O2"
 #
 #export KOS_CFLAGS="${KOS_CFLAGS} -freorder-blocks-algorithm=simple -flto=auto"
 
-# RAM-Saving Optimization
-#
-# Uncomment the line below to reduce the default size of FD_SETSIZE from the
-# default value of 1024 to 64. FD_SETSIZE defines the maximum number of files
-# that can be opened simultaneously, including files on the ramdisk, romdisk, 
-# CD, VMU, network sockets, etc. The default setting allows 1024 files to be
-# opened at once, which is typically more than most use cases require.
-#
-# By reducing this value, you can save approximately ~11.25 KB of RAM, which 
-# can be particularly useful when porting large games to the Dreamcast that 
-# are strapped for memory. However, be cautious not to set it too low, as this 
-# may limit the number of files and sockets that can be opened simultaneously.
-#
-# export KOS_CFLAGS="${KOS_CFLAGS} -DFD_SETSIZE=64"
-
 # Frame Pointers
 #
 # Controls whether frame pointers are emitted or not. Disabled by
diff --git a/include/kos/opts.h b/include/kos/opts.h
index fe005278..66eedea2 100644
--- a/include/kos/opts.h
+++ b/include/kos/opts.h
@@ -129,8 +129,9 @@ __BEGIN_DECLS
 #define FS_RAMDISK_MAX_FILES 8
 #endif
 
-/** \brief  The number of distinct file descriptors that can be in use at a
-            time. This value can be overwritten in environ.sh */
+/** \brief  The number of distinct file descriptors, including files and
+            network sockets, that can be in use at a time. Decreasing this
+            value can reduce memory usage.  */
 #ifndef FD_SETSIZE
 #define FD_SETSIZE 1024
 #endif
diff --git a/kernel/fs/fs.c b/kernel/fs/fs.c
index d1efca3a..e0e0339c 100644
--- a/kernel/fs/fs.c
+++ b/kernel/fs/fs.c
@@ -197,10 +197,9 @@ static int fs_hnd_assign(fs_hnd_t *hnd) {
             break;
 
     if(i >= FD_SETSIZE) {
-        if(FD_SETSIZE != 1024)
-            dbglog(DBG_ERROR, "fs_hnd_assign: Update -DFD_SETSIZE flag in \
-                  environ.sh to support additional files being opened. Current \
-                  limit is %d\n", FD_SETSIZE);
+        dbglog(DBG_ERROR, "fs_hnd_assign: Update FD_SETSIZE definition in \
+              opts.h to support additional files being opened. Current \
+              limit is %d\n", FD_SETSIZE);
 
         fs_hnd_unref(hnd);
         errno = EMFILE;


hooks/post-receive
-- 
A pseudo Operating System for the Dreamcast.