|
From: falcovorbis <fal...@us...> - 2024-08-08 11:20:18
|
This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "A pseudo Operating System for the Dreamcast.".
The branch, skmp_pvr_bg_fix has been created
at e0b526286e4e8cd83a4459610b3cc3718cdf5ad7 (commit)
- Log -----------------------------------------------------------------
commit e0b526286e4e8cd83a4459610b3cc3718cdf5ad7
Author: Falco Girgis <gyr...@gm...>
Date: Tue Aug 6 17:42:48 2024 -0500
Fixed overflow with writing pvr bg plane.
- skmp (correctly) reported that our little loop to copy the internally
populated pvr_bkg_poly_t polygon (which gets color info from
pvr_set_bg_color()) was looping too far.
* structure is only 60 bytes, we looped for 64 and then wrote
another word even beyond that.
- swapped implementation to use memcpy() based on sizeof(pvr_bkg_poly_t)
which is safer, and is smart enough to do per-word operations when
they are valid (not here, lolz).
- removed final vrl[0x11] = 0 assignment, as it clearly wasn't
necessary and doesn't appear to even be doing anything useful at-all.
The BG polygon types are special and don't need end-of-list flags, and
interpolate the 4th vertex, more like PVR sprites.
-----------------------------------------------------------------------
hooks/post-receive
--
A pseudo Operating System for the Dreamcast.
|