[cadcdev-svn-commits] [SCM] branch master updated. v2.0.0-364-g956a83c

[Lawrence S. <ljs...@us...>]

This is an automated email from the git hooks/post-receive script. It was
generated because a ref change was pushed to the repository containing
the project "A pseudo Operating System for the Dreamcast.".

The branch, master has been updated
       via  956a83c75c40b17197474162beae60d055cf6cbb (commit)
      from  d0187df0c0cc7ce2e7853d8160e1c4eeb3479cb4 (commit)

Those revisions listed above that are new to this repository have
not appeared on any other notification email; so we list those
revisions in full, below.

- Log -----------------------------------------------------------------
commit 956a83c75c40b17197474162beae60d055cf6cbb
Author: Lawrence Sebald <ljs...@us...>
Date:   Tue Feb 11 23:36:35 2020 -0500

    Clean up implicit fallthroughs in the kernel tree.

-----------------------------------------------------------------------

Summary of changes:
 kernel/arch/dreamcast/kernel/gdb_stub.c | 1 +
 kernel/arch/dreamcast/kernel/init.c     | 1 +
 kernel/net/net_arp.c                    | 2 ++
 3 files changed, 4 insertions(+)

diff --git a/kernel/arch/dreamcast/kernel/gdb_stub.c b/kernel/arch/dreamcast/kernel/gdb_stub.c
index f837c89..386e58e 100644
--- a/kernel/arch/dreamcast/kernel/gdb_stub.c
+++ b/kernel/arch/dreamcast/kernel/gdb_stub.c
@@ -819,6 +819,7 @@ gdb_handle_exception(int exceptionVector) {
                 /* sAA..AA   Step one instruction from AA..AA(optional) */
             case 's':
                 stepping = 1;
+                __fallthrough;
             case 'c': {
                 /* tRY, to read optional parameter, pc unchanged if no parm */
                 if(hexToInt(&ptr, &addr))
diff --git a/kernel/arch/dreamcast/kernel/init.c b/kernel/arch/dreamcast/kernel/init.c
index 36392b9..f54e0e6 100644
--- a/kernel/arch/dreamcast/kernel/init.c
+++ b/kernel/arch/dreamcast/kernel/init.c
@@ -267,6 +267,7 @@ void arch_exit() {
     switch(arch_exit_path) {
         default:
             dbglog(DBG_CRITICAL, "arch: arch_exit_path has invalid value!\n");
+            __fallthrough;
         case ARCH_EXIT_RETURN:
             arch_return();
             break;
diff --git a/kernel/net/net_arp.c b/kernel/net/net_arp.c
index 360e742..b181497 100644
--- a/kernel/net/net_arp.c
+++ b/kernel/net/net_arp.c
@@ -288,6 +288,8 @@ int net_arp_input(netif_t *nif, const uint8 *pkt_in, int len) {
     switch(pkt->opcode[1]) {
         case 1: /* ARP Request */
             net_arp_send(nif, pkt);
+            __fallthrough; /* Yes, this really should fall through here. */
+
         case 2: /* ARP Reply */
             /* Insert into ARP cache */
             net_arp_insert(nif, pkt->hw_send, pkt->pr_send,


hooks/post-receive
-- 
A pseudo Operating System for the Dreamcast.