Re: [KOS] Patch needed to build with GCC 5.1.1

[Luke B. <ka...@gm...>]

Hi, I've attached a patch to fix this as I've just hit it again on another
machine. Thanks!

On 2 August 2015 at 16:24, Luke Benstead <ka...@gm...> wrote:

> Yeah sorry, just the cast and the inline thing :)
>
> You should give GitHub or GitLab a play, it makes it far easier for people
> to contribute if they've already got changes in their tree. Issue tracking
> and reviewing is much easier too than on SF.
>
> Anyway, thanks for applying the patches, I'll upload anymore I come up
> with to the patch tracker. Looking at porting SDL 2 as I need it for my
> game engine :)
>
> On Sun, 2 Aug 2015 15:38 Lawrence Sebald <ljs...@us...>
> wrote:
>
>> With regard to the GCC related issue… In that thread you linked to from
>> OpenWRT, is anything needed to make it compile other than the last patch
>> (the one that has the int cast and the __gnu_inline__ stuff)? The rest of
>> that looks extraneous to the situation at hand (at least as reported by the
>> DragonflyBSD issue that that part of the patch was derived from). I’m just
>> checking, since I don’t actually have any machines handy that have GCC 5.x
>> on them (and I don’t even have GCC period on my normal dev machine — I only
>> have Clang installed here).
>>
>> As for libpng, I’ve gone ahead and applied your patch and pushed it up to
>> the repository.
>>
>> Also, with regard to GitHub  while we do have a mirror of the repository
>> on GitHub (https://github.com/ljsebald/KallistiOS and
>> https://github.com/ljsebald/kos-ports specifically), the
>> primary/canonical repository is on SourceForge and will stay there for the
>> foreseeable future. The preferred way of dealing with patches is to format
>> them exactly as you have for the libpng one and either submit them on the
>> patches tracker on SourceForge. Generally I’ll notice them if they’re
>> posted to the mailing list too, but the patches tracker would be the
>> “correct” way to dispense with them. Truth be told, I’ve never dealt with
>> pull requests on GitHub. ;-)
>>
>> - Lawrence
>>
>> On Aug 2, 2015, at 4:15 AM, Luke Benstead <ka...@gm...> wrote:
>>
>> Also it appears libpng-1.6.17 has been replaced here:
>> ftp://ftp.simplesystems.org/pub/libpng/png/src/libpng16/
>>
>> Now it only hosts 1.6.18, so either we need to bump the version in
>> kos-ports, or find 1.6.17 hosted elsewhere. I've attached a patch which
>> updates to *.18.
>>
>> On 2 August 2015 at 08:57, Luke Benstead <ka...@gm...> wrote:
>>
>>> Hi there!
>>>
>>> I wasn't sure where bug reports for Kos are supposed to go, so I figured
>>> just emailing here might be the best thing to do.
>>>
>>> I had some trouble compiling Kos on Fedora 22 which ships with GCC
>>> 5.1.1. Turns out that the openwrt project had exactly the same compilation
>>> issue and this is the patch to GCC that fixes it:
>>> https://github.com/981213/openwrt/commit/f1a46cdab03240df27d7632a2adac509d58118e8
>>>
>>> After applying that to my local tree, Kos compiled successfully.
>>>
>>> Luke.
>>>
>>> P.S. Just as a side note, any chance of moving over to GitHub? Normally
>>> I'd just be able to send a pull request for this kind of thing, but
>>> sourceforge doesn't seem to have something similar.
>>>
>>
>> <0001-Bump-the-libpng-version-to-1.6.18.patch>
>> ------------------------------------------------------------------------------
>> _______________________________________________
>> cadcdev-kallistios mailing list
>> cad...@li...
>> https://lists.sourceforge.net/lists/listinfo/cadcdev-kallistios
>>
>>
>>
>> ------------------------------------------------------------------------------
>> _______________________________________________
>> cadcdev-kallistios mailing list
>> cad...@li...
>> https://lists.sourceforge.net/lists/listinfo/cadcdev-kallistios
>>
>