Re: [Bugs-r-devel] SF.net SVN: bugs-r: [66] trunk/R2WinBUGS/R

[Uwe L. <li...@st...>]

Gregor Gorjanc wrote:
> Uwe Ligges wrote:
> ...
>>
>> Thank you for the update!
>>
>> Unfortunately, this are inappropriate usages of ifelse(): We know that
>> we are working with a length 1 logical vectors here. Using ifelse() is
>> more insecure and inefficient in such a case!
>>
>> I'll change that myself to if(){} else{}.
> 
> I used ifelse to avoid clutter, but if(){} else{} is also Ok for me. 
> Thanks!
> 
>>> -  if(useWINE && (substr(bugs.directory, start=2, stop=2) == ":")) {
>>> +  if(useWINE && (substr(bugs.directory, 2, 2) == ":")) {
>>
>> Is there a good reason for making this code less secure?
> 
> S-PLUS, does not have arguments (I do not know why) in substr and it 
> fails with "secure version".

I see, thanks! My Windows version of S-PLUS does not have substr() at 
all, hence I thought yours would not have as well. S-PLUS seems to have 
a lot differences between operating systems.

Uwe




> 
> Gregor