From: Gregor G. <gre...@bf...> - 2006-12-12 12:12:34
|
Hi Ben, I would like to discuss about changes you propose. I will start at the end with wineutils. First, it is hard for me to read this diffs, since they are not standard i.e. lines are mostly marked with ! and not with + /-. You propose change to win2native, which is OK, but why. This function is used only in bugs.run.R and is needed only for old wine tweak i.e. using .wine/config file. It is not needed if winepath is available. My plan is to abandon .wine/config since winepath is around quite a long time. Therefore I would prefer to keep this the way it is and to migrate to winepath part. I agree about native2win i.e. addition of WINEPATH=Sys.getenv("WINEPATH"). But would like to discuss this in next email. Ben Bolker wrote: ... > *** wineutils.R 2006-10-08 14:07:50.000000000 -0400 > --- /home/ben/bugs-r/trunk/R2WinBUGS/R/wineutils.R 2006-12-10 16:21:31.000000000 -0500 > *************** > *** 43,58 **** > } > > ! win2native <- function(x, useWINE=.Platform$OS.type != "windows", newWINE=TRUE, > ! WINEPATH=Sys.getenv("WINEPATH")) { # win -> native > ! if (useWINE && !newWINE) winedriveTr(x) > ! if (useWINE && newWINE) { > ! system(paste(WINEPATH,' \"',x,'\"',sep=""), intern=TRUE) > ! } else x > } > > ! native2win <- function(x, useWINE=.Platform$OS.type != "windows", newWINE=TRUE, > ! WINEPATH=Sys.getenv("WINEPATH")) { # native -> win > if (useWINE && !newWINE) return(winedriveRTr(x)) > if (useWINE && newWINE) { > x <- system(paste(WINEPATH, "-w", x), intern = TRUE) > --- 43,54 ---- > } > > ! win2native <- function(x, useWINE=.Platform$OS.type != "windows") { # win -> native > ! if (useWINE) winedriveTr(x) > ! else x > } > > ! native2win <- function(x, useWINE=.Platform$OS.type != "windows", newWINE=TRUE) { # native -> win > if (useWINE && !newWINE) return(winedriveRTr(x)) > if (useWINE && newWINE) { > x <- system(paste(WINEPATH, "-w", x), intern = TRUE) |