#9 bdd_reorder_auto() early exit doesn't work.

v1.0 (example)
open
nobody
code (7)
5
2011-11-07
2011-11-07
Dmitry
No

Found using Coverity static code checker. Inside bdd_reorder_auto(() function using '!bdd_reorder_ready' (line 1629 below) to early exit. However, bdd_reorder_ready is a function name, so bdd_reorder_ready is a function pointer that is never NULL. So the early exit can never be triggered.

1618 int bdd_reorder_ready(void)
1619 {
1620 if (bddreordermethod == BDD_REORDER_NONE || vartree == NULL ||
1621 bddreordertimes == 0 || reorderdisabled)
1622 return 0;
1623 return 1;
1624 }
1625
1626
1627 void bdd_reorder_auto(void)
1628 {
Event boolean_controlling_expr_is_constant: controlling expression is constant
1629 if (!bdd_reorder_ready)
^
1630 return;

Discussion


Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks