browserunit-development

Re: [Browserunit-development] method naming conventions - refactoring request

[Achim D. <do...@pr...>]

Hi Jonathan,

> Any thoughts or concerns?

I forgot that I have changed the filtering code a lot. I have not yet 
checked in the changes. Please give me one or two days to check in the 
refactored version, before you start renaming methods.

Achim

Re: [Browserunit-development] method naming conventions - refactoring request

[Achim D. <do...@pr...>]

Hi Jonathan,

> Looking through the source code, I see we have a couple of different styles for
> method names. I'm suggesting we go with the C# standard of "methodName" rather
> than the "underscore_style". I am probably the originator of the method name
> styles because of my Ruby background. Ruby developers are strict about
> "this_case", and get upset if you use "thisCase".

I favor none of both. The underscore version is more Watir like, and the 
pascal style version is more common for C# developers. Because 
browserUnit will probably not be used very much from other C# libs, 
beside NUnit test code, I would not care to much about common C# style. 
But if you think it would make writing tests easier for most of our 
users, I have no problem changing the naming convention.

> I'm proposing we do a refactoring of method names to convert the underscore
> names to the camelCase style. I'm willing to take this on, but will need a bit
> of help getting started. I imagine the refactoring will be straight-forward
> using ReSharper with Visual Studio.
> 
> Any thoughts or concerns?

Feel free to start and to ask questions. But you are right: Using 
ReSharper is should be quite easy. If I find the time, I'll help, but I 
could not promise something at the moment.

Achim

[Browserunit-development] method naming conventions - refactoring request

[<jk...@te...>]

Hi Achim;

Looking through the source code, I see we have a couple of different styles for
method names. I'm suggesting we go with the C# standard of "methodName" rather
than the "underscore_style". I am probably the originator of the method name
styles because of my Ruby background. Ruby developers are strict about
"this_case", and get upset if you use "thisCase".

I'm proposing we do a refactoring of method names to convert the underscore
names to the camelCase style. I'm willing to take this on, but will need a bit
of help getting started. I imagine the refactoring will be straight-forward
using ReSharper with Visual Studio.

Any thoughts or concerns?

Thanks;

-Jonathan

[Browserunit-development] Image and SelectList support

[Achim D. <do...@pr...>]

Hi Jonathan,

find attached an new release with some support for images and select 
lists. See lines 126 - 142 of 
http://svn.sourceforge.net/viewvc/browserunit/trunk/browserUnit.Tests/ControlsTests.cs?view=markup 
for details.

Selection of options by their name does not yet work. I have to figure 
out how to do that.

Achim