#270 Inconsistency in following the Coding Standards

Untested
open
5
2014-11-22
2014-04-20
No

I found an inconsitency in following the BRL-CAD Coding Guidelines in the source code of BRL-CAD in Index: src/mged/vparse.c. This rectification is in reference to the article "Braces" in the HACKING file at line no. 720.

Thanks!

1 Attachments

Discussion

  • Gauravjeet Singh

    Hey Albert,
    I guess you are correct with usage of braces, but the placement of braces is still wrong.
    Without braces only the first statement comes under if block, but after applying this patch two statements would come under if block. So IMHO you need to put just one condition under if block.

     
    • Albert Coder

      Albert Coder - 2014-11-24

      Hi Gauravjeet,

      Just checked your comment, I have rectified what I missed.

      I have pre-checked the patch by applying it using the following command:

      patch vparse.c < edit.patch

      Thanks!

       

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:





No, thanks