#120 Reduction in src/sig

closed-rejected
5
2012-08-14
2012-06-18
No

Programmes d-i and f-i are almost the same, so the common code is put into int.c/int.h (function toInt, which is called in both programmes). Difference in usage is put into char *usage variable. Making, running - successful. The results're the same before and after reduction. Variable usage is tested too.

Discussion

  • Ksenija Slivko

    Ksenija Slivko - 2012-07-22

    Patch's updated. Necessary comments are added, some included headers are deleted

     
  • Ksenija Slivko

    Ksenija Slivko - 2012-07-29

    updated patch for src/sig

     
  • Ksenija Slivko

    Ksenija Slivko - 2012-07-29

    Patch updated. This patch must go together with patch #3538342, because
    Makefile.am and CMakeLists.txt are the same for them.

     
  • Sean Morrison

    Sean Morrison - 2012-08-14

    the patch does not include build system updates to use the new files

     
  • Sean Morrison

    Sean Morrison - 2012-08-14

    This patch doesn't provide updates to the build system to declare/use the new int.c/int.h files. More importantly, this breaks the f-i tool. Note the fread() calls in both call sizeof(ibuf[0]) for reading. For d-i, this is a double. For f-i, this is a float. You made both a double which is wrong for f-i and will result in the wrong number of bytes being read.

     
  • Sean Morrison

    Sean Morrison - 2012-08-14
    • labels: --> Compilation
    • assigned_to: nobody --> brlcad
    • status: open --> closed-rejected
     

Log in to post a comment.

Get latest updates about Open Source Projects, Conferences and News.

Sign up for the SourceForge newsletter:

JavaScript is required for this form.





No, thanks