Thread: [brlcad-tracker] [ brlcad-Patches-3527142 ] refactored part of libbu/lex.c
Open Source Solid Modeling CAD
Brought to you by:
brlcad
From: SourceForge.net <no...@so...> - 2012-05-16 03:18:58
|
Patches item #3527142, was opened at 2012-05-15 20:18 Message generated for change (Tracker Item Submitted) made by crdueck You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=640804&aid=3527142&group_id=105292 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: crdueck (crdueck) Assigned to: Nobody/Anonymous (nobody) Summary: refactored part of libbu/lex.c Initial Comment: refactored section of lex.c which deals with beginning whitespace and comments. removed a goto loop and cleaned up some of the logic, it seems much more readable now. made 2 minor whitespace changes i'm confident that the code is correct, but suggestions on how to test this would be appreciated. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=640804&aid=3527142&group_id=105292 |
From: SourceForge.net <no...@so...> - 2012-05-21 04:02:45
|
Patches item #3527142, was opened at 2012-05-15 20:18 Message generated for change (Comment added) made by crdueck You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=640804&aid=3527142&group_id=105292 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: crdueck (crdueck) Assigned to: Nobody/Anonymous (nobody) Summary: refactored part of libbu/lex.c Initial Comment: refactored section of lex.c which deals with beginning whitespace and comments. removed a goto loop and cleaned up some of the logic, it seems much more readable now. made 2 minor whitespace changes i'm confident that the code is correct, but suggestions on how to test this would be appreciated. ---------------------------------------------------------------------- >Comment By: crdueck (crdueck) Date: 2012-05-20 21:02 Message: made a coding style fix. the main goal of this patch was to improve readability, i'd appreciate feedback if that goal was reached. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=640804&aid=3527142&group_id=105292 |
From: SourceForge.net <no...@so...> - 2012-05-23 02:46:06
|
Patches item #3527142, was opened at 2012-05-15 20:18 Message generated for change (Comment added) made by brlcad You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=640804&aid=3527142&group_id=105292 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: crdueck (crdueck) Assigned to: Nobody/Anonymous (nobody) Summary: refactored part of libbu/lex.c Initial Comment: refactored section of lex.c which deals with beginning whitespace and comments. removed a goto loop and cleaned up some of the logic, it seems much more readable now. made 2 minor whitespace changes i'm confident that the code is correct, but suggestions on how to test this would be appreciated. ---------------------------------------------------------------------- >Comment By: Sean Morrison (brlcad) Date: 2012-05-22 19:46 Message: Just a note, file attachments don't have a date so give them unique filenames that indicate the version of the file when you give updates (e.g., lex.patch, lex.v2.patch, etc). ---------------------------------------------------------------------- Comment By: crdueck (crdueck) Date: 2012-05-20 21:02 Message: made a coding style fix. the main goal of this patch was to improve readability, i'd appreciate feedback if that goal was reached. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=640804&aid=3527142&group_id=105292 |
From: SourceForge.net <no...@so...> - 2012-05-23 02:55:44
|
Patches item #3527142, was opened at 2012-05-15 20:18 Message generated for change (Comment added) made by brlcad You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=640804&aid=3527142&group_id=105292 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Pending >Resolution: Postponed Priority: 5 Private: No Submitted By: crdueck (crdueck) >Assigned to: Sean Morrison (brlcad) Summary: refactored part of libbu/lex.c Initial Comment: refactored section of lex.c which deals with beginning whitespace and comments. removed a goto loop and cleaned up some of the logic, it seems much more readable now. made 2 minor whitespace changes i'm confident that the code is correct, but suggestions on how to test this would be appreciated. ---------------------------------------------------------------------- >Comment By: Sean Morrison (brlcad) Date: 2012-05-22 19:55 Message: As for how to test this change, the 'joint' command in mged is what uses the bu_lex() interace. The "joint load" subcommand loads a text 'joint' file. It'd take a bit to figure out how to use it, but feel free to give it a try after going through a couple of the mged tutorials (available on the website). The patch can't reasonably be applied until it is tested, unfortunately since it's a logic restructuring that could easily have unintended parser changes. ---------------------------------------------------------------------- Comment By: Sean Morrison (brlcad) Date: 2012-05-22 19:46 Message: Just a note, file attachments don't have a date so give them unique filenames that indicate the version of the file when you give updates (e.g., lex.patch, lex.v2.patch, etc). ---------------------------------------------------------------------- Comment By: crdueck (crdueck) Date: 2012-05-20 21:02 Message: made a coding style fix. the main goal of this patch was to improve readability, i'd appreciate feedback if that goal was reached. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=640804&aid=3527142&group_id=105292 |
From: SourceForge.net <no...@so...> - 2012-05-30 23:27:02
|
Patches item #3527142, was opened at 2012-05-15 20:18 Message generated for change (Settings changed) made by crdueck You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=640804&aid=3527142&group_id=105292 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None >Status: Closed >Resolution: Accepted Priority: 5 Private: No Submitted By: crdueck (crdueck) >Assigned to: CT Johnson (ctjctj) Summary: refactored part of libbu/lex.c Initial Comment: refactored section of lex.c which deals with beginning whitespace and comments. removed a goto loop and cleaned up some of the logic, it seems much more readable now. made 2 minor whitespace changes i'm confident that the code is correct, but suggestions on how to test this would be appreciated. ---------------------------------------------------------------------- >Comment By: crdueck (crdueck) Date: 2012-05-30 16:27 Message: revised version applied in r50774 ---------------------------------------------------------------------- Comment By: Sean Morrison (brlcad) Date: 2012-05-22 19:55 Message: As for how to test this change, the 'joint' command in mged is what uses the bu_lex() interace. The "joint load" subcommand loads a text 'joint' file. It'd take a bit to figure out how to use it, but feel free to give it a try after going through a couple of the mged tutorials (available on the website). The patch can't reasonably be applied until it is tested, unfortunately since it's a logic restructuring that could easily have unintended parser changes. ---------------------------------------------------------------------- Comment By: Sean Morrison (brlcad) Date: 2012-05-22 19:46 Message: Just a note, file attachments don't have a date so give them unique filenames that indicate the version of the file when you give updates (e.g., lex.patch, lex.v2.patch, etc). ---------------------------------------------------------------------- Comment By: crdueck (crdueck) Date: 2012-05-20 21:02 Message: made a coding style fix. the main goal of this patch was to improve readability, i'd appreciate feedback if that goal was reached. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=640804&aid=3527142&group_id=105292 |
From: SourceForge.net <no...@so...> - 2012-05-31 00:01:50
|
Patches item #3527142, was opened at 2012-05-15 20:18 Message generated for change (Settings changed) made by brlcad You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=640804&aid=3527142&group_id=105292 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Closed Resolution: Accepted Priority: 5 Private: No Submitted By: crdueck (crdueck) >Assigned to: crdueck (crdueck) Summary: refactored part of libbu/lex.c Initial Comment: refactored section of lex.c which deals with beginning whitespace and comments. removed a goto loop and cleaned up some of the logic, it seems much more readable now. made 2 minor whitespace changes i'm confident that the code is correct, but suggestions on how to test this would be appreciated. ---------------------------------------------------------------------- Comment By: crdueck (crdueck) Date: 2012-05-30 16:27 Message: revised version applied in r50774 ---------------------------------------------------------------------- Comment By: Sean Morrison (brlcad) Date: 2012-05-22 19:55 Message: As for how to test this change, the 'joint' command in mged is what uses the bu_lex() interace. The "joint load" subcommand loads a text 'joint' file. It'd take a bit to figure out how to use it, but feel free to give it a try after going through a couple of the mged tutorials (available on the website). The patch can't reasonably be applied until it is tested, unfortunately since it's a logic restructuring that could easily have unintended parser changes. ---------------------------------------------------------------------- Comment By: Sean Morrison (brlcad) Date: 2012-05-22 19:46 Message: Just a note, file attachments don't have a date so give them unique filenames that indicate the version of the file when you give updates (e.g., lex.patch, lex.v2.patch, etc). ---------------------------------------------------------------------- Comment By: crdueck (crdueck) Date: 2012-05-20 21:02 Message: made a coding style fix. the main goal of this patch was to improve readability, i'd appreciate feedback if that goal was reached. ---------------------------------------------------------------------- You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=640804&aid=3527142&group_id=105292 |