Screenshot instructions:
Windows
Mac
Red Hat Linux
Ubuntu
Click URL instructions:
Rightclick on ad, choose "Copy Link", then paste here →
(This may not be possible with some types of ads)
From: SourceForge.net <noreply@so...>  20120402 22:17:59

Patches item #3514278, was opened at 20120402 15:17 Message generated for change (Tracker Item Submitted) made by aldabest You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=640804&aid=3514278&group_id=105292 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: None Group: None Status: Open Resolution: None Priority: 5 Private: No Submitted By: Al_Da_Best (aldabest) Assigned to: Nobody/Anonymous (nobody) Summary: Added functions for Volume, Centroid and Surface Area ell.c Initial Comment: Not entirely convinced by my centroid function on two fronts. Firstly, the passing of the array point_t, secondly, it does seem quite redundant since there is nothing to calculate but I put it there anyway. Volume calculation is easy. Surface Area calculate is messy. I put a set of IF statements in, to see if it's a sphere, prolate spheroid or oblate spheroid as those are easy to caclulate. A triaxial ellipsoid is relatively complex and I couldn't get the calculations in, possibly a lack of understanding them or how to implement them in code (Involves integrals) on my part (it's not something I regularly calculate). Instead I put in a formula that estimates the surface area to within a ~1% error. Feedback is welcome naturally. Whilst not specifically related to my GSOC proposal (http://brlcad.org/wiki/User:Al_Da_Best), I have learnt a lot about the codebase whilst putting these in, as I did a large amount of looking at other functions to see how things were done. I did try to follow the HACKING guide, though I think I can improve in that area.  You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=640804&aid=3514278&group_id=105292 
From: SourceForge.net <noreply@so...>  20120403 02:44:08

Patches item #3514278, was opened at 20120402 15:17 Message generated for change (Comment added) made by brlcad You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=640804&aid=3514278&group_id=105292 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. >Category: Analysis Group: None >Status: Pending >Resolution: Rejected Priority: 5 Private: No Submitted By: Al_Da_Best (aldabest) >Assigned to: Sean Morrison (brlcad) Summary: Added functions for Volume, Centroid and Surface Area ell.c Initial Comment: Not entirely convinced by my centroid function on two fronts. Firstly, the passing of the array point_t, secondly, it does seem quite redundant since there is nothing to calculate but I put it there anyway. Volume calculation is easy. Surface Area calculate is messy. I put a set of IF statements in, to see if it's a sphere, prolate spheroid or oblate spheroid as those are easy to caclulate. A triaxial ellipsoid is relatively complex and I couldn't get the calculations in, possibly a lack of understanding them or how to implement them in code (Involves integrals) on my part (it's not something I regularly calculate). Instead I put in a formula that estimates the surface area to within a ~1% error. Feedback is welcome naturally. Whilst not specifically related to my GSOC proposal (http://brlcad.org/wiki/User:Al_Da_Best), I have learnt a lot about the codebase whilst putting these in, as I did a large amount of looking at other functions to see how things were done. I did try to follow the HACKING guide, though I think I can improve in that area.  >Comment By: Sean Morrison (brlcad) Date: 20120402 19:44 Message: Thanks Al, You made things a bit complicated for yourself by doing three all at once, so bonus points for effort but I do see some problems with the patch: At a glance, rt_ell_sfa() does not follow our HACKING guidelines with regards to expected coding style for braces... Also, your choice of signature conventions for the new functions is rather inconsistent with all the other functions in that file. Return values are either void or return codes, not data. Output parameters should be passed as pointers (and validated as nonnull). Last note, the surface area cannot be an estimate. If it's not exact, it's not useful. We already can calculate an approximation to an arbitrary precision via sampling. If it's too hard to solve the general case (apply a transformation matrix so the vectors are axisaligned), just leave it off the patch. Please update the patch addressing those comments and we'll revisit it.  You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=640804&aid=3514278&group_id=105292 
From: SourceForge.net <noreply@so...>  20120403 02:59:00

Patches item #3514278, was opened at 20120402 15:17 Message generated for change (Comment added) made by brlcad You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=640804&aid=3514278&group_id=105292 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Analysis Group: None Status: Pending Resolution: Rejected Priority: 5 Private: No Submitted By: Al_Da_Best (aldabest) Assigned to: Sean Morrison (brlcad) Summary: Added functions for Volume, Centroid and Surface Area ell.c Initial Comment: Not entirely convinced by my centroid function on two fronts. Firstly, the passing of the array point_t, secondly, it does seem quite redundant since there is nothing to calculate but I put it there anyway. Volume calculation is easy. Surface Area calculate is messy. I put a set of IF statements in, to see if it's a sphere, prolate spheroid or oblate spheroid as those are easy to caclulate. A triaxial ellipsoid is relatively complex and I couldn't get the calculations in, possibly a lack of understanding them or how to implement them in code (Involves integrals) on my part (it's not something I regularly calculate). Instead I put in a formula that estimates the surface area to within a ~1% error. Feedback is welcome naturally. Whilst not specifically related to my GSOC proposal (http://brlcad.org/wiki/User:Al_Da_Best), I have learnt a lot about the codebase whilst putting these in, as I did a large amount of looking at other functions to see how things were done. I did try to follow the HACKING guide, though I think I can improve in that area.  >Comment By: Sean Morrison (brlcad) Date: 20120402 19:59 Message: Also noticed that your volume calculation is wrong. You multiply by one instead of 4/3rds due to rounding.  Comment By: Sean Morrison (brlcad) Date: 20120402 19:44 Message: Thanks Al, You made things a bit complicated for yourself by doing three all at once, so bonus points for effort but I do see some problems with the patch: At a glance, rt_ell_sfa() does not follow our HACKING guidelines with regards to expected coding style for braces... Also, your choice of signature conventions for the new functions is rather inconsistent with all the other functions in that file. Return values are either void or return codes, not data. Output parameters should be passed as pointers (and validated as nonnull). Last note, the surface area cannot be an estimate. If it's not exact, it's not useful. We already can calculate an approximation to an arbitrary precision via sampling. If it's too hard to solve the general case (apply a transformation matrix so the vectors are axisaligned), just leave it off the patch. Please update the patch addressing those comments and we'll revisit it.  You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=640804&aid=3514278&group_id=105292 
From: SourceForge.net <noreply@so...>  20120403 22:31:18

Patches item #3514278, was opened at 20120402 15:17 Message generated for change (Comment added) made by aldabest You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=640804&aid=3514278&group_id=105292 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Analysis Group: None >Status: Open Resolution: Rejected Priority: 5 Private: No Submitted By: Al_Da_Best (aldabest) Assigned to: Sean Morrison (brlcad) Summary: Added functions for Volume, Centroid and Surface Area ell.c Initial Comment: Not entirely convinced by my centroid function on two fronts. Firstly, the passing of the array point_t, secondly, it does seem quite redundant since there is nothing to calculate but I put it there anyway. Volume calculation is easy. Surface Area calculate is messy. I put a set of IF statements in, to see if it's a sphere, prolate spheroid or oblate spheroid as those are easy to caclulate. A triaxial ellipsoid is relatively complex and I couldn't get the calculations in, possibly a lack of understanding them or how to implement them in code (Involves integrals) on my part (it's not something I regularly calculate). Instead I put in a formula that estimates the surface area to within a ~1% error. Feedback is welcome naturally. Whilst not specifically related to my GSOC proposal (http://brlcad.org/wiki/User:Al_Da_Best), I have learnt a lot about the codebase whilst putting these in, as I did a large amount of looking at other functions to see how things were done. I did try to follow the HACKING guide, though I think I can improve in that area.  >Comment By: Al_Da_Best (aldabest) Date: 20120403 15:31 Message: Thanks for the feedback, have uploaded an updated version. Changed all functions to return an int, 1 being bad with a null pointer. Removed the approximation for an ellipsoid, I had another look at calculating it but it requires integration of things that I can't find straightforward answers to on wolfram, wikipedia or a few google searches. I did add in support for oblate/prolate spheroids in all 3 axis however, and created two functions for handling the calculations for those. With regards to having axis aligned vectors, would rt_ell_prep handle this beforehand?  Comment By: Sean Morrison (brlcad) Date: 20120402 19:59 Message: Also noticed that your volume calculation is wrong. You multiply by one instead of 4/3rds due to rounding.  Comment By: Sean Morrison (brlcad) Date: 20120402 19:44 Message: Thanks Al, You made things a bit complicated for yourself by doing three all at once, so bonus points for effort but I do see some problems with the patch: At a glance, rt_ell_sfa() does not follow our HACKING guidelines with regards to expected coding style for braces... Also, your choice of signature conventions for the new functions is rather inconsistent with all the other functions in that file. Return values are either void or return codes, not data. Output parameters should be passed as pointers (and validated as nonnull). Last note, the surface area cannot be an estimate. If it's not exact, it's not useful. We already can calculate an approximation to an arbitrary precision via sampling. If it's too hard to solve the general case (apply a transformation matrix so the vectors are axisaligned), just leave it off the patch. Please update the patch addressing those comments and we'll revisit it.  You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=640804&aid=3514278&group_id=105292 
From: SourceForge.net <noreply@so...>  20120405 06:32:11

Patches item #3514278, was opened at 20120402 15:17 Message generated for change (Comment added) made by crdueck You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=640804&aid=3514278&group_id=105292 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Analysis Group: None Status: Open Resolution: Rejected Priority: 5 Private: No Submitted By: Al_Da_Best (aldabest) Assigned to: Sean Morrison (brlcad) Summary: Added functions for Volume, Centroid and Surface Area ell.c Initial Comment: Not entirely convinced by my centroid function on two fronts. Firstly, the passing of the array point_t, secondly, it does seem quite redundant since there is nothing to calculate but I put it there anyway. Volume calculation is easy. Surface Area calculate is messy. I put a set of IF statements in, to see if it's a sphere, prolate spheroid or oblate spheroid as those are easy to caclulate. A triaxial ellipsoid is relatively complex and I couldn't get the calculations in, possibly a lack of understanding them or how to implement them in code (Involves integrals) on my part (it's not something I regularly calculate). Instead I put in a formula that estimates the surface area to within a ~1% error. Feedback is welcome naturally. Whilst not specifically related to my GSOC proposal (http://brlcad.org/wiki/User:Al_Da_Best), I have learnt a lot about the codebase whilst putting these in, as I did a large amount of looking at other functions to see how things were done. I did try to follow the HACKING guide, though I think I can improve in that area.  Comment By: crdueck (crdueck) Date: 20120404 23:32 Message: hi aldabest, there is an error in your rt_ell_obl(), the line *ell_sfa = (2 * M_PI * a2) + (M_PI * (c / e) * log((1.0 + e)/(1.0  e))); should be *ell_sfa = (2.0 * M_PI * a2) + (M_PI * (c2 / e) * log((1.0 + e) / (1.0  e))); just a small oversight, i noticed it because I'm writing an ell surface area function myself.  Comment By: Al_Da_Best (aldabest) Date: 20120403 15:31 Message: Thanks for the feedback, have uploaded an updated version. Changed all functions to return an int, 1 being bad with a null pointer. Removed the approximation for an ellipsoid, I had another look at calculating it but it requires integration of things that I can't find straightforward answers to on wolfram, wikipedia or a few google searches. I did add in support for oblate/prolate spheroids in all 3 axis however, and created two functions for handling the calculations for those. With regards to having axis aligned vectors, would rt_ell_prep handle this beforehand?  Comment By: Sean Morrison (brlcad) Date: 20120402 19:59 Message: Also noticed that your volume calculation is wrong. You multiply by one instead of 4/3rds due to rounding.  Comment By: Sean Morrison (brlcad) Date: 20120402 19:44 Message: Thanks Al, You made things a bit complicated for yourself by doing three all at once, so bonus points for effort but I do see some problems with the patch: At a glance, rt_ell_sfa() does not follow our HACKING guidelines with regards to expected coding style for braces... Also, your choice of signature conventions for the new functions is rather inconsistent with all the other functions in that file. Return values are either void or return codes, not data. Output parameters should be passed as pointers (and validated as nonnull). Last note, the surface area cannot be an estimate. If it's not exact, it's not useful. We already can calculate an approximation to an arbitrary precision via sampling. If it's too hard to solve the general case (apply a transformation matrix so the vectors are axisaligned), just leave it off the patch. Please update the patch addressing those comments and we'll revisit it.  You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=640804&aid=3514278&group_id=105292 
From: SourceForge.net <noreply@so...>  20120405 09:22:59

Patches item #3514278, was opened at 20120402 15:17 Message generated for change (Comment added) made by aldabest You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=640804&aid=3514278&group_id=105292 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Analysis Group: None Status: Open Resolution: Rejected Priority: 5 Private: No Submitted By: Al_Da_Best (aldabest) Assigned to: Sean Morrison (brlcad) Summary: Added functions for Volume, Centroid and Surface Area ell.c Initial Comment: Not entirely convinced by my centroid function on two fronts. Firstly, the passing of the array point_t, secondly, it does seem quite redundant since there is nothing to calculate but I put it there anyway. Volume calculation is easy. Surface Area calculate is messy. I put a set of IF statements in, to see if it's a sphere, prolate spheroid or oblate spheroid as those are easy to caclulate. A triaxial ellipsoid is relatively complex and I couldn't get the calculations in, possibly a lack of understanding them or how to implement them in code (Involves integrals) on my part (it's not something I regularly calculate). Instead I put in a formula that estimates the surface area to within a ~1% error. Feedback is welcome naturally. Whilst not specifically related to my GSOC proposal (http://brlcad.org/wiki/User:Al_Da_Best), I have learnt a lot about the codebase whilst putting these in, as I did a large amount of looking at other functions to see how things were done. I did try to follow the HACKING guide, though I think I can improve in that area.  >Comment By: Al_Da_Best (aldabest) Date: 20120405 02:22 Message: Thanks for pointing that out. Also made me realise some of my iflogic was out so I fixed that too.  Comment By: crdueck (crdueck) Date: 20120404 23:32 Message: hi aldabest, there is an error in your rt_ell_obl(), the line *ell_sfa = (2 * M_PI * a2) + (M_PI * (c / e) * log((1.0 + e)/(1.0  e))); should be *ell_sfa = (2.0 * M_PI * a2) + (M_PI * (c2 / e) * log((1.0 + e) / (1.0  e))); just a small oversight, i noticed it because I'm writing an ell surface area function myself.  Comment By: Al_Da_Best (aldabest) Date: 20120403 15:31 Message: Thanks for the feedback, have uploaded an updated version. Changed all functions to return an int, 1 being bad with a null pointer. Removed the approximation for an ellipsoid, I had another look at calculating it but it requires integration of things that I can't find straightforward answers to on wolfram, wikipedia or a few google searches. I did add in support for oblate/prolate spheroids in all 3 axis however, and created two functions for handling the calculations for those. With regards to having axis aligned vectors, would rt_ell_prep handle this beforehand?  Comment By: Sean Morrison (brlcad) Date: 20120402 19:59 Message: Also noticed that your volume calculation is wrong. You multiply by one instead of 4/3rds due to rounding.  Comment By: Sean Morrison (brlcad) Date: 20120402 19:44 Message: Thanks Al, You made things a bit complicated for yourself by doing three all at once, so bonus points for effort but I do see some problems with the patch: At a glance, rt_ell_sfa() does not follow our HACKING guidelines with regards to expected coding style for braces... Also, your choice of signature conventions for the new functions is rather inconsistent with all the other functions in that file. Return values are either void or return codes, not data. Output parameters should be passed as pointers (and validated as nonnull). Last note, the surface area cannot be an estimate. If it's not exact, it's not useful. We already can calculate an approximation to an arbitrary precision via sampling. If it's too hard to solve the general case (apply a transformation matrix so the vectors are axisaligned), just leave it off the patch. Please update the patch addressing those comments and we'll revisit it.  You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=640804&aid=3514278&group_id=105292 
From: SourceForge.net <noreply@so...>  20120527 14:31:52

Patches item #3514278, was opened at 20120402 15:17 Message generated for change (Comment added) made by brlcad You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=640804&aid=3514278&group_id=105292 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Analysis Group: None >Status: Pending Resolution: Rejected Priority: 5 Private: No Submitted By: Al_Da_Best (aldabest) Assigned to: Sean Morrison (brlcad) Summary: Added functions for Volume, Centroid and Surface Area ell.c Initial Comment: Not entirely convinced by my centroid function on two fronts. Firstly, the passing of the array point_t, secondly, it does seem quite redundant since there is nothing to calculate but I put it there anyway. Volume calculation is easy. Surface Area calculate is messy. I put a set of IF statements in, to see if it's a sphere, prolate spheroid or oblate spheroid as those are easy to caclulate. A triaxial ellipsoid is relatively complex and I couldn't get the calculations in, possibly a lack of understanding them or how to implement them in code (Involves integrals) on my part (it's not something I regularly calculate). Instead I put in a formula that estimates the surface area to within a ~1% error. Feedback is welcome naturally. Whilst not specifically related to my GSOC proposal (http://brlcad.org/wiki/User:Al_Da_Best), I have learnt a lot about the codebase whilst putting these in, as I did a large amount of looking at other functions to see how things were done. I did try to follow the HACKING guide, though I think I can improve in that area.  >Comment By: Sean Morrison (brlcad) Date: 20120527 07:31 Message: Should this patch be closed out since you resubmitted a new tracker item?  Comment By: Al_Da_Best (aldabest) Date: 20120405 02:22 Message: Thanks for pointing that out. Also made me realise some of my iflogic was out so I fixed that too.  Comment By: crdueck (crdueck) Date: 20120404 23:32 Message: hi aldabest, there is an error in your rt_ell_obl(), the line *ell_sfa = (2 * M_PI * a2) + (M_PI * (c / e) * log((1.0 + e)/(1.0  e))); should be *ell_sfa = (2.0 * M_PI * a2) + (M_PI * (c2 / e) * log((1.0 + e) / (1.0  e))); just a small oversight, i noticed it because I'm writing an ell surface area function myself.  Comment By: Al_Da_Best (aldabest) Date: 20120403 15:31 Message: Thanks for the feedback, have uploaded an updated version. Changed all functions to return an int, 1 being bad with a null pointer. Removed the approximation for an ellipsoid, I had another look at calculating it but it requires integration of things that I can't find straightforward answers to on wolfram, wikipedia or a few google searches. I did add in support for oblate/prolate spheroids in all 3 axis however, and created two functions for handling the calculations for those. With regards to having axis aligned vectors, would rt_ell_prep handle this beforehand?  Comment By: Sean Morrison (brlcad) Date: 20120402 19:59 Message: Also noticed that your volume calculation is wrong. You multiply by one instead of 4/3rds due to rounding.  Comment By: Sean Morrison (brlcad) Date: 20120402 19:44 Message: Thanks Al, You made things a bit complicated for yourself by doing three all at once, so bonus points for effort but I do see some problems with the patch: At a glance, rt_ell_sfa() does not follow our HACKING guidelines with regards to expected coding style for braces... Also, your choice of signature conventions for the new functions is rather inconsistent with all the other functions in that file. Return values are either void or return codes, not data. Output parameters should be passed as pointers (and validated as nonnull). Last note, the surface area cannot be an estimate. If it's not exact, it's not useful. We already can calculate an approximation to an arbitrary precision via sampling. If it's too hard to solve the general case (apply a transformation matrix so the vectors are axisaligned), just leave it off the patch. Please update the patch addressing those comments and we'll revisit it.  You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=640804&aid=3514278&group_id=105292 
From: SourceForge.net <noreply@so...>  20120527 15:54:35

Patches item #3514278, was opened at 20120402 15:17 Message generated for change (Comment added) made by aldabest You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=640804&aid=3514278&group_id=105292 Please note that this message will contain a full copy of the comment thread, including the initial issue submission, for this request, not just the latest update. Category: Analysis Group: None >Status: Closed Resolution: Rejected Priority: 5 Private: No Submitted By: Al_Da_Best (aldabest) Assigned to: Sean Morrison (brlcad) Summary: Added functions for Volume, Centroid and Surface Area ell.c Initial Comment: Not entirely convinced by my centroid function on two fronts. Firstly, the passing of the array point_t, secondly, it does seem quite redundant since there is nothing to calculate but I put it there anyway. Volume calculation is easy. Surface Area calculate is messy. I put a set of IF statements in, to see if it's a sphere, prolate spheroid or oblate spheroid as those are easy to caclulate. A triaxial ellipsoid is relatively complex and I couldn't get the calculations in, possibly a lack of understanding them or how to implement them in code (Involves integrals) on my part (it's not something I regularly calculate). Instead I put in a formula that estimates the surface area to within a ~1% error. Feedback is welcome naturally. Whilst not specifically related to my GSOC proposal (http://brlcad.org/wiki/User:Al_Da_Best), I have learnt a lot about the codebase whilst putting these in, as I did a large amount of looking at other functions to see how things were done. I did try to follow the HACKING guide, though I think I can improve in that area.  >Comment By: Al_Da_Best (aldabest) Date: 20120527 08:54 Message: Yes it should, sorry. Closed it now (I think)  Comment By: Sean Morrison (brlcad) Date: 20120527 07:31 Message: Should this patch be closed out since you resubmitted a new tracker item?  Comment By: Al_Da_Best (aldabest) Date: 20120405 02:22 Message: Thanks for pointing that out. Also made me realise some of my iflogic was out so I fixed that too.  Comment By: crdueck (crdueck) Date: 20120404 23:32 Message: hi aldabest, there is an error in your rt_ell_obl(), the line *ell_sfa = (2 * M_PI * a2) + (M_PI * (c / e) * log((1.0 + e)/(1.0  e))); should be *ell_sfa = (2.0 * M_PI * a2) + (M_PI * (c2 / e) * log((1.0 + e) / (1.0  e))); just a small oversight, i noticed it because I'm writing an ell surface area function myself.  Comment By: Al_Da_Best (aldabest) Date: 20120403 15:31 Message: Thanks for the feedback, have uploaded an updated version. Changed all functions to return an int, 1 being bad with a null pointer. Removed the approximation for an ellipsoid, I had another look at calculating it but it requires integration of things that I can't find straightforward answers to on wolfram, wikipedia or a few google searches. I did add in support for oblate/prolate spheroids in all 3 axis however, and created two functions for handling the calculations for those. With regards to having axis aligned vectors, would rt_ell_prep handle this beforehand?  Comment By: Sean Morrison (brlcad) Date: 20120402 19:59 Message: Also noticed that your volume calculation is wrong. You multiply by one instead of 4/3rds due to rounding.  Comment By: Sean Morrison (brlcad) Date: 20120402 19:44 Message: Thanks Al, You made things a bit complicated for yourself by doing three all at once, so bonus points for effort but I do see some problems with the patch: At a glance, rt_ell_sfa() does not follow our HACKING guidelines with regards to expected coding style for braces... Also, your choice of signature conventions for the new functions is rather inconsistent with all the other functions in that file. Return values are either void or return codes, not data. Output parameters should be passed as pointers (and validated as nonnull). Last note, the surface area cannot be an estimate. If it's not exact, it's not useful. We already can calculate an approximation to an arbitrary precision via sampling. If it's too hard to solve the general case (apply a transformation matrix so the vectors are axisaligned), just leave it off the patch. Please update the patch addressing those comments and we'll revisit it.  You can respond by visiting: https://sourceforge.net/tracker/?func=detail&atid=640804&aid=3514278&group_id=105292 