On Mar 27, 2012, at 02:26 PM, Ksenija Slivko <ksuzee91@...> wrote:
Now I have some questions. I've tried to make my first patch. I found some duplication with Simian in three files from the same directory. It was real copy-past (3 functions with the same body), so I decided to make one function for this files. I wrote about it here
(everything's clear for me there), but, as I understand, it's not enough.
It's usually a few days before patches can be reviewed as they tend to take a fair bit of time, but there are a few things you can do to help make things easier. First off, patch files are just text files so you can open them with an editor and see what is inside them. Does it have everything you intended to include? Does it have too much? Did you change just "one thing"? Those are things you should look for and when we review a patch, that's the first thing we do too.
Next, you can try to apply your patch to an unmodified source checkout . Does your patch apply  cleanly? If not, you probably did something wrong or need to redo the patch or you're in the wrong directory. ;)
 svn co https://brlcad.svn.sourceforge.net/svnroot/brlcad/brlcad/trunk brlcad
 patch -p0 < your_patch_file
There must be also correct commit from the terminal. So what is supposed to do after svn diff > brlcad.patch? Because after that I have some problems with traditional svn-commands =)
You upload that brlcadpatch file to Sourceforge. You won't get commit privileges until you've made a few successful patches. Keep them small and simple and reviewing them becomes quick and easy. Just upload your file to the Sourceforge patches tracker like you did. From there you can ask a dev in IRC to review it or just wait (someone eventually will). Then just include a link to any patches in your application so we can easily find them.