I've just finished reviewing nearly a dozen patches and they were nearly all invalid, did not apply cleanly, or had other coding issues. This is very disappointing. I asked in an earlier e-mail to CHECK YOUR PATCHES. Everyone with a patch submitted needs to do this right away. Check ALL of your submissions to make sure they are correct.
It's a waste of time, your time and your mentor's time to have to review patches repeatedly when they have blatant problems. If you are not sure about something, you need to be asking questions. It's clear some of you have never made a patch file before. There are many many tutorials around the web on how to do this with an svn checkout very easily. Copy-pasted source code is not acceptable.
Check your patches submissions to make sure:
1) they are valid patch files, not copy-pasted text
2) you provide a brief description of what the patch does
3) you identify any other patches that must be applied first
4) your patch applies! "patch -p0 < yourpatchfile" should work
5) your code has proper headers/footers
6) your code conforms to our style, read HACKING
7) your code compiles!
Do NOT wait for someone to review your patch to tell you the problems. Check them yourself. Make it as easy as possible to review your patch submissions. If you do not have commit access, you must update or post a patch every day. Failure to do this is really not an option at this point.
Get latest updates about Open Source Projects, Conferences and News.